From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC v2 04/16] ARM: highbank: remove custom .init_time hook
Date: Tue, 27 Aug 2013 23:27:58 +0200 [thread overview]
Message-ID: <1377638890-371-5-git-send-email-sebastian.hesselbarth@gmail.com> (raw)
In-Reply-To: <1376964271-22715-1-git-send-email-sebastian.hesselbarth@gmail.com>
With arch/arm calling of_clk_init(NULL) from time_init(), we can now
remove custom .init_time hooks. Highbank clock provider need a reference
to system registers, as a workaround current clk driver maps those
independent of arch code now.
Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Acked-by: Rob Herring <rob.herring@calxeda.com>
---
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: Mike Turquette <mturquette@linaro.org>
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-kernel at vger.kernel.org
---
arch/arm/mach-highbank/highbank.c | 23 +++++++----------------
drivers/clk/clk-highbank.c | 10 +++++++---
2 files changed, 14 insertions(+), 19 deletions(-)
diff --git a/arch/arm/mach-highbank/highbank.c b/arch/arm/mach-highbank/highbank.c
index 8881579..fa36d14 100644
--- a/arch/arm/mach-highbank/highbank.c
+++ b/arch/arm/mach-highbank/highbank.c
@@ -27,7 +27,6 @@
#include <linux/of_address.h>
#include <linux/smp.h>
#include <linux/amba/bus.h>
-#include <linux/clk-provider.h>
#include <asm/cacheflush.h>
#include <asm/cputype.h>
@@ -88,20 +87,6 @@ static void __init highbank_init_irq(void)
#endif
}
-static void __init highbank_timer_init(void)
-{
- struct device_node *np;
-
- /* Map system registers */
- np = of_find_compatible_node(NULL, NULL, "calxeda,hb-sregs");
- sregs_base = of_iomap(np, 0);
- WARN_ON(!sregs_base);
-
- of_clk_init(NULL);
-
- clocksource_of_init();
-}
-
static void highbank_power_off(void)
{
highbank_set_pwr_shutdown();
@@ -160,6 +145,13 @@ static struct notifier_block highbank_platform_nb = {
static void __init highbank_init(void)
{
+ struct device_node *np;
+
+ /* Map system registers */
+ np = of_find_compatible_node(NULL, NULL, "calxeda,hb-sregs");
+ sregs_base = of_iomap(np, 0);
+ WARN_ON(!sregs_base);
+
pm_power_off = highbank_power_off;
highbank_pm_init();
@@ -178,7 +170,6 @@ static const char *highbank_match[] __initconst = {
DT_MACHINE_START(HIGHBANK, "Highbank")
.smp = smp_ops(highbank_smp_ops),
.init_irq = highbank_init_irq,
- .init_time = highbank_timer_init,
.init_machine = highbank_init,
.dt_compat = highbank_match,
.restart = highbank_restart,
diff --git a/drivers/clk/clk-highbank.c b/drivers/clk/clk-highbank.c
index 2e08cb0..2e7e9d9 100644
--- a/drivers/clk/clk-highbank.c
+++ b/drivers/clk/clk-highbank.c
@@ -20,8 +20,7 @@
#include <linux/clk-provider.h>
#include <linux/io.h>
#include <linux/of.h>
-
-extern void __iomem *sregs_base;
+#include <linux/of_address.h>
#define HB_PLL_LOCK_500 0x20000000
#define HB_PLL_LOCK 0x10000000
@@ -280,6 +279,7 @@ static __init struct clk *hb_clk_init(struct device_node *node, const struct clk
const char *clk_name = node->name;
const char *parent_name;
struct clk_init_data init;
+ struct device_node *srnp;
int rc;
rc = of_property_read_u32(node, "reg", ®);
@@ -290,7 +290,11 @@ static __init struct clk *hb_clk_init(struct device_node *node, const struct clk
if (WARN_ON(!hb_clk))
return NULL;
- hb_clk->reg = sregs_base + reg;
+ /* Map system registers */
+ srnp = of_find_compatible_node(NULL, NULL, "calxeda,hb-sregs");
+ hb_clk->reg = of_iomap(srnp, 0);
+ BUG_ON(!hb_clk->reg);
+ hb_clk->reg += reg;
of_property_read_string(node, "clock-output-names", &clk_name);
--
1.7.2.5
next prev parent reply other threads:[~2013-08-27 21:27 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 2:04 [RFC 00/17] ARM: provide common arch init for DT clocks Sebastian Hesselbarth
2013-08-20 2:04 ` [RFC 10/17] ARM: nspire: remove custom .init_time hook Sebastian Hesselbarth
[not found] ` <1376964271-22715-7-git-send-email-sebastian.hesselbarth@gmail.com>
2013-08-20 7:26 ` [RFC 06/17] ARM: imx: " Sascha Hauer
2013-08-20 8:48 ` Sebastian Hesselbarth
2013-08-20 9:10 ` Sascha Hauer
2013-08-20 9:20 ` Sebastian Hesselbarth
2013-08-20 10:20 ` Russell King - ARM Linux
2013-08-20 10:37 ` Sebastian Hesselbarth
2013-08-20 10:42 ` Russell King - ARM Linux
2013-08-20 10:46 ` Sebastian Hesselbarth
[not found] ` <1376964271-22715-9-git-send-email-sebastian.hesselbarth@gmail.com>
2013-08-20 12:50 ` [RFC 08/17] ARM: mvebu: " Ezequiel Garcia
2013-08-20 13:12 ` Sebastian Hesselbarth
2013-08-20 14:01 ` Ezequiel Garcia
2013-08-23 10:06 ` Gregory CLEMENT
2013-08-23 10:32 ` Sebastian Hesselbarth
2013-08-23 11:39 ` Gregory CLEMENT
2013-08-23 12:13 ` Sebastian Hesselbarth
2013-08-23 14:23 ` Gregory CLEMENT
2013-08-23 14:34 ` Gregory CLEMENT
[not found] ` <1376964271-22715-3-git-send-email-sebastian.hesselbarth@gmail.com>
2013-08-20 15:46 ` [RFC 02/17] ARM: call clk_of_init from time_init Stephen Warren
2013-08-20 19:47 ` Sebastian Hesselbarth
2013-08-20 19:52 ` Stephen Warren
2013-08-20 20:19 ` Sebastian Hesselbarth
2013-08-21 18:54 ` Arnd Bergmann
2013-08-22 7:25 ` Mike Turquette
2013-08-22 17:28 ` Arnd Bergmann
2013-08-20 20:44 ` Arnd Bergmann
2013-08-20 20:57 ` Stephen Warren
2013-08-21 18:51 ` Arnd Bergmann
[not found] ` <1376964271-22715-6-git-send-email-sebastian.hesselbarth@gmail.com>
2013-08-20 19:12 ` [RFC 05/17] ARM: highbank: remove custom .init_time hook Rob Herring
2013-08-20 20:01 ` Sebastian Hesselbarth
[not found] ` <1376964271-22715-18-git-send-email-sebastian.hesselbarth@gmail.com>
2013-08-23 0:26 ` [RFC 17/17] clk: zynq: remove call to of_clk_init Sören Brinkmann
2013-08-23 0:59 ` Sören Brinkmann
2013-08-23 7:32 ` Steffen Trumtrar
2013-08-23 16:00 ` Sören Brinkmann
2013-08-23 23:38 ` Steffen Trumtrar
2013-08-26 11:15 ` Michal Simek
2013-08-26 12:07 ` Steffen Trumtrar
2013-08-26 12:53 ` Sebastian Hesselbarth
2013-08-26 15:14 ` Michal Simek
2013-08-26 15:31 ` Steffen Trumtrar
2013-08-26 15:16 ` Sören Brinkmann
2013-08-26 15:33 ` Steffen Trumtrar
2013-08-23 9:30 ` Sebastian Hesselbarth
2013-08-23 17:19 ` Sören Brinkmann
2013-08-23 17:44 ` Sebastian Hesselbarth
2013-08-23 23:22 ` Steffen Trumtrar
2013-08-26 15:20 ` Sören Brinkmann
2013-08-27 21:27 ` [PATCH RFC v2 00/16] ARM: provide common arch init for DT clocks Sebastian Hesselbarth
2013-08-27 21:27 ` [PATCH RFC v2 01/16] ARM: call clk_of_init from time_init Sebastian Hesselbarth
2013-08-27 22:19 ` Sören Brinkmann
2013-08-27 22:58 ` Sebastian Hesselbarth
2013-08-27 23:20 ` Sören Brinkmann
2013-08-29 13:45 ` Arnd Bergmann
2013-09-04 19:32 ` Sebastian Hesselbarth
2013-09-04 20:41 ` Sören Brinkmann
2013-09-04 20:52 ` Sebastian Hesselbarth
2013-09-04 20:59 ` Sören Brinkmann
2013-09-05 9:34 ` Arnd Bergmann
2013-08-27 21:27 ` [PATCH RFC v2 02/16] ARM: dove: remove custom .init_time hook Sebastian Hesselbarth
2013-08-27 21:27 ` [PATCH RFC v2 03/16] ARM: exynos: " Sebastian Hesselbarth
2013-08-27 21:27 ` Sebastian Hesselbarth [this message]
2013-08-27 23:13 ` [PATCH RFC v2 04/16] ARM: highbank: " Mike Turquette
2013-08-27 21:27 ` [PATCH RFC v2 05/16] ARM: imx: " Sebastian Hesselbarth
2013-08-29 11:00 ` Shawn Guo
2013-08-27 21:28 ` [PATCH RFC v2 06/16] ARM: kirkwood: " Sebastian Hesselbarth
2013-08-27 21:28 ` [PATCH RFC v2 07/16] ARM: mvebu: " Sebastian Hesselbarth
2013-08-28 6:28 ` Gregory CLEMENT
2013-08-27 21:28 ` [PATCH RFC v2 08/16] ARM: mxs: " Sebastian Hesselbarth
2013-08-27 23:16 ` Mike Turquette
2013-08-29 11:08 ` Shawn Guo
2013-08-29 11:32 ` Sebastian Hesselbarth
2013-08-29 12:58 ` Shawn Guo
2013-08-27 21:28 ` [PATCH RFC v2 09/16] ARM: nspire: " Sebastian Hesselbarth
2013-08-27 21:28 ` [PATCH RFC v2 10/16] ARM: rockchip: " Sebastian Hesselbarth
2013-08-27 21:28 ` [PATCH RFC v2 11/16] ARM: socfpga: remove call to of_clk_init Sebastian Hesselbarth
2013-08-29 15:38 ` Dinh Nguyen
2013-08-29 17:23 ` Arnd Bergmann
2013-08-27 21:28 ` [PATCH RFC v2 12/16] ARM: sti: remove custom .init_time hook Sebastian Hesselbarth
2013-08-29 16:29 ` [STLinux Kernel] " Srinivas KANDAGATLA
2013-08-27 21:28 ` [PATCH RFC v2 13/16] ARM: tegra: split tegra_pmc_init() in two Sebastian Hesselbarth
2013-08-27 21:59 ` Stephen Warren
2013-08-27 22:09 ` Sebastian Hesselbarth
2013-09-11 19:56 ` Stephen Warren
2013-09-12 6:21 ` Sebastian Hesselbarth
2013-09-12 16:32 ` Stephen Warren
2013-08-27 21:28 ` [PATCH RFC v2 14/16] ARM: vexpress: remove custom .init_time hook Sebastian Hesselbarth
2013-08-29 13:35 ` Arnd Bergmann
2013-08-29 18:16 ` Sebastian Hesselbarth
2013-08-30 10:02 ` Jon Medhurst (Tixy)
2013-08-30 11:39 ` Russell King - ARM Linux
2013-08-30 13:12 ` Pawel Moll
2013-08-27 21:28 ` [PATCH RFC v2 15/16] clk: vt8500: remove call to of_clk_init Sebastian Hesselbarth
2013-08-27 23:16 ` Mike Turquette
2013-08-29 13:42 ` Arnd Bergmann
2013-08-27 21:28 ` [PATCH RFC v2 16/16] ARM: zynq: Don't call of_clk_init() Sebastian Hesselbarth
2013-08-29 13:37 ` Arnd Bergmann
2013-08-29 14:21 ` Michal Simek
2013-08-29 17:20 ` Arnd Bergmann
2013-08-29 18:14 ` Michal Simek
2013-08-29 18:20 ` Sebastian Hesselbarth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377638890-371-5-git-send-email-sebastian.hesselbarth@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).