From: ben.dooks@codethink.co.uk (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 19/19] ARM: atomic64: fix endian-ness in atomic.h
Date: Wed, 28 Aug 2013 12:45:59 +0100 [thread overview]
Message-ID: <1377690359-25397-20-git-send-email-ben.dooks@codethink.co.uk> (raw)
In-Reply-To: <1377690359-25397-1-git-send-email-ben.dooks@codethink.co.uk>
From: Victor Kamensky <victor.kamensky@linaro.org>
Fix inline asm for atomic64_xxx functions in arm atomic.h. Instead of
%H operand specifiers code should use %Q for least significant part
of the value, and %R for the most significant part of the value. %H
always returns the higher of the two register numbers, and therefore
it is not endian neutral. %H should be used with ldrexd and strexd
instructions.
Signed-off-by: Victor Kamensky <victor.kamensky@linaro.org>
Acked-by: Will Deacon <will.deacon@arm.com>
---
arch/arm/include/asm/atomic.h | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/arch/arm/include/asm/atomic.h b/arch/arm/include/asm/atomic.h
index da1c77d..6447a0b 100644
--- a/arch/arm/include/asm/atomic.h
+++ b/arch/arm/include/asm/atomic.h
@@ -301,8 +301,8 @@ static inline void atomic64_add(u64 i, atomic64_t *v)
__asm__ __volatile__("@ atomic64_add\n"
"1: ldrexd %0, %H0, [%3]\n"
-" adds %0, %0, %4\n"
-" adc %H0, %H0, %H4\n"
+" adds %Q0, %Q0, %Q4\n"
+" adc %R0, %R0, %R4\n"
" strexd %1, %0, %H0, [%3]\n"
" teq %1, #0\n"
" bne 1b"
@@ -320,8 +320,8 @@ static inline u64 atomic64_add_return(u64 i, atomic64_t *v)
__asm__ __volatile__("@ atomic64_add_return\n"
"1: ldrexd %0, %H0, [%3]\n"
-" adds %0, %0, %4\n"
-" adc %H0, %H0, %H4\n"
+" adds %Q0, %Q0, %Q4\n"
+" adc %R0, %R0, %R4\n"
" strexd %1, %0, %H0, [%3]\n"
" teq %1, #0\n"
" bne 1b"
@@ -341,8 +341,8 @@ static inline void atomic64_sub(u64 i, atomic64_t *v)
__asm__ __volatile__("@ atomic64_sub\n"
"1: ldrexd %0, %H0, [%3]\n"
-" subs %0, %0, %4\n"
-" sbc %H0, %H0, %H4\n"
+" subs %Q0, %Q0, %Q4\n"
+" sbc %R0, %R0, %R4\n"
" strexd %1, %0, %H0, [%3]\n"
" teq %1, #0\n"
" bne 1b"
@@ -360,8 +360,8 @@ static inline u64 atomic64_sub_return(u64 i, atomic64_t *v)
__asm__ __volatile__("@ atomic64_sub_return\n"
"1: ldrexd %0, %H0, [%3]\n"
-" subs %0, %0, %4\n"
-" sbc %H0, %H0, %H4\n"
+" subs %Q0, %Q0, %Q4\n"
+" sbc %R0, %R0, %R4\n"
" strexd %1, %0, %H0, [%3]\n"
" teq %1, #0\n"
" bne 1b"
@@ -428,9 +428,9 @@ static inline u64 atomic64_dec_if_positive(atomic64_t *v)
__asm__ __volatile__("@ atomic64_dec_if_positive\n"
"1: ldrexd %0, %H0, [%3]\n"
-" subs %0, %0, #1\n"
-" sbc %H0, %H0, #0\n"
-" teq %H0, #0\n"
+" subs %Q0, %Q0, #1\n"
+" sbc %R0, %R0, #0\n"
+" teq %R0, #0\n"
" bmi 2f\n"
" strexd %1, %0, %H0, [%3]\n"
" teq %1, #0\n"
@@ -459,8 +459,8 @@ static inline int atomic64_add_unless(atomic64_t *v, u64 a, u64 u)
" teqeq %H0, %H5\n"
" moveq %1, #0\n"
" beq 2f\n"
-" adds %0, %0, %6\n"
-" adc %H0, %H0, %H6\n"
+" adds %Q0, %Q0, %Q6\n"
+" adc %R0, %R0, %R6\n"
" strexd %2, %0, %H0, [%4]\n"
" teq %2, #0\n"
" bne 1b\n"
--
1.7.10.4
prev parent reply other threads:[~2013-08-28 11:45 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 21:38 3.11-rc7 big-endian support Ben Dooks
2013-08-27 21:38 ` [PATCH 01/19] ARM: fix ARCH_IXP4xx usage of ARCH_SUPPORTS_BIG_ENDIAN Ben Dooks
2013-08-27 21:38 ` [PATCH 02/19] ARM: asm: Add ARM_BE8() assembly helper Ben Dooks
2013-08-27 21:38 ` [PATCH 03/19] ARM: fixup_pv_table bug when CPU_ENDIAN_BE8 Ben Dooks
2013-08-28 16:54 ` Dave Martin
2013-08-27 21:38 ` [PATCH 04/19] ARM: set BE8 if LE in head code Ben Dooks
2013-08-28 10:21 ` Thomas Petazzoni
2013-08-28 16:42 ` Dave Martin
2013-08-27 21:38 ` [PATCH 05/19] ARM: pl01x debug code endian fix Ben Dooks
2013-08-28 17:03 ` Dave Martin
2013-08-27 21:38 ` [PATCH 06/19] ARM: twd: data " Ben Dooks
2013-08-27 21:38 ` [PATCH 07/19] ARM: smp_scu: data endian fixes Ben Dooks
2013-08-27 21:38 ` [PATCH 08/19] highbank: enable big-endian Ben Dooks
2013-08-28 15:21 ` Rob Herring
2013-08-30 18:50 ` Ben Dooks
2013-08-27 21:38 ` [PATCH 09/19] mvebu: support running big-endian Ben Dooks
2013-08-27 21:38 ` [PATCH 10/19] vexpress: add big endian support Ben Dooks
2013-08-27 21:38 ` [PATCH 11/19] ARM: alignment: correctly decode instructions in BE8 mode Ben Dooks
2013-08-28 16:44 ` Dave Martin
2013-08-27 21:38 ` [PATCH 12/19] ARM: traps: use <asm/opcodes.h> to get correct instruction order Ben Dooks
2013-08-28 11:22 ` Dave Martin
2013-08-27 21:38 ` [PATCH 13/19] ARM: module: correctly relocate instructions in BE8 Ben Dooks
2013-08-28 16:46 ` Dave Martin
2013-08-27 21:38 ` [PATCH 14/19] ARM: set --be8 when linking modules Ben Dooks
2013-08-28 16:38 ` Dave Martin
2013-08-30 18:55 ` Ben Dooks
2013-08-27 21:38 ` [PATCH 15/19] ARM: hardware: fix endian-ness in <hardware/coresight.h> Ben Dooks
2013-08-27 21:38 ` [PATCH 16/19] ARM: net: fix arm instruction endian-ness in bpf_jit_32.c Ben Dooks
2013-08-28 16:47 ` Dave Martin
2013-08-27 21:38 ` [PATCH 17/19] ARM: Correct BUG() assembly to ensure it is endian-agnostic Ben Dooks
2013-08-28 16:48 ` Dave Martin
2013-08-27 21:38 ` [PATCH 18/19] ARM: kdgb: use <asm/opcodes.h> for data to be assembled as intruction Ben Dooks
2013-08-28 16:50 ` Dave Martin
2013-08-27 21:38 ` [PATCH 19/19] ARM: atomic64: fix endian-ness in atomic.h Ben Dooks
2013-08-27 22:02 ` 3.11-rc7 big-endian support Ben Dooks
2013-08-29 9:59 ` Thomas Petazzoni
2013-08-29 10:23 ` Ben Dooks
2013-08-29 10:28 ` Thomas Petazzoni
2013-08-29 15:53 ` Victor Kamensky
2013-08-29 17:17 ` Ben Dooks
2013-08-28 11:45 ` re-send patch series due to mta issues Ben Dooks
2013-08-28 11:45 ` [PATCH 01/19] ARM: fix ARCH_IXP4xx usage of ARCH_SUPPORTS_BIG_ENDIAN Ben Dooks
2013-08-28 11:45 ` [PATCH 02/19] ARM: asm: Add ARM_BE8() assembly helper Ben Dooks
2013-08-28 11:45 ` [PATCH 03/19] ARM: fixup_pv_table bug when CPU_ENDIAN_BE8 Ben Dooks
2013-08-28 11:45 ` [PATCH 04/19] ARM: set BE8 if LE in head code Ben Dooks
2013-08-28 11:45 ` [PATCH 05/19] ARM: pl01x debug code endian fix Ben Dooks
2013-08-28 11:45 ` [PATCH 06/19] ARM: twd: data " Ben Dooks
2013-08-28 11:45 ` [PATCH 07/19] ARM: smp_scu: data endian fixes Ben Dooks
2013-08-28 11:45 ` [PATCH 08/19] highbank: enable big-endian Ben Dooks
2013-08-28 11:45 ` [PATCH 09/19] mvebu: support running big-endian Ben Dooks
2013-08-28 11:45 ` [PATCH 10/19] vexpress: add big endian support Ben Dooks
2013-08-28 11:45 ` [PATCH 11/19] ARM: alignment: correctly decode instructions in BE8 mode Ben Dooks
2013-08-28 19:40 ` Sergei Shtylyov
2013-08-30 18:47 ` Ben Dooks
2013-08-28 11:45 ` [PATCH 12/19] ARM: traps: use <asm/opcodes.h> to get correct instruction order Ben Dooks
2013-08-28 11:45 ` [PATCH 13/19] ARM: module: correctly relocate instructions in BE8 Ben Dooks
2013-08-28 11:45 ` [PATCH 14/19] ARM: set --be8 when linking modules Ben Dooks
2013-08-28 11:45 ` [PATCH 15/19] ARM: hardware: fix endian-ness in <hardware/coresight.h> Ben Dooks
2013-08-28 11:45 ` [PATCH 16/19] ARM: net: fix arm instruction endian-ness in bpf_jit_32.c Ben Dooks
2013-08-28 11:45 ` [PATCH 17/19] ARM: Correct BUG() assembly to ensure it is endian-agnostic Ben Dooks
2013-08-28 11:45 ` [PATCH 18/19] ARM: kdgb: use <asm/opcodes.h> for data to be assembled as intruction Ben Dooks
2013-08-28 11:45 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377690359-25397-20-git-send-email-ben.dooks@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).