* [PATCH] serial: imx: initialize the local variable
@ 2013-08-29 8:29 Huang Shijie
2013-08-29 14:12 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Huang Shijie @ 2013-08-29 8:29 UTC (permalink / raw)
To: linux-arm-kernel
The slave_config is not initialized, so some of its fields may
be set with random data which may causes the failure in the following
dmaengine_prep_slave_sg().
This patch fixes this issue.
Signed-off-by: Huang Shijie <b32955@freescale.com>
---
drivers/tty/serial/imx.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 2c13155..a0ebbc9 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -979,7 +979,7 @@ static void imx_uart_dma_exit(struct imx_port *sport)
static int imx_uart_dma_init(struct imx_port *sport)
{
- struct dma_slave_config slave_config;
+ struct dma_slave_config slave_config = {};
struct device *dev = sport->port.dev;
int ret;
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] serial: imx: initialize the local variable
2013-08-29 8:29 [PATCH] serial: imx: initialize the local variable Huang Shijie
@ 2013-08-29 14:12 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2013-08-29 14:12 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Aug 29, 2013 at 04:29:25PM +0800, Huang Shijie wrote:
> The slave_config is not initialized, so some of its fields may
> be set with random data which may causes the failure in the following
> dmaengine_prep_slave_sg().
>
> This patch fixes this issue.
>
> Signed-off-by: Huang Shijie <b32955@freescale.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> drivers/tty/serial/imx.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> index 2c13155..a0ebbc9 100644
> --- a/drivers/tty/serial/imx.c
> +++ b/drivers/tty/serial/imx.c
> @@ -979,7 +979,7 @@ static void imx_uart_dma_exit(struct imx_port *sport)
>
> static int imx_uart_dma_init(struct imx_port *sport)
> {
> - struct dma_slave_config slave_config;
> + struct dma_slave_config slave_config = {};
> struct device *dev = sport->port.dev;
> int ret;
>
> --
> 1.7.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-29 14:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-29 8:29 [PATCH] serial: imx: initialize the local variable Huang Shijie
2013-08-29 14:12 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).