* [PATCH 0/2] Enable all cpus in Exynos5420
@ 2013-09-05 9:24 Chander Kashyap
2013-09-05 9:24 ` [PATCH 1/2] clocksource: mct: extend mct to support 8 local interrupts for Exynos5420 Chander Kashyap
2013-09-05 9:24 ` [PATCH 2/2] arm: dt: Exynos5420: populate cpu node enteries to 8 cpus Chander Kashyap
0 siblings, 2 replies; 7+ messages in thread
From: Chander Kashyap @ 2013-09-05 9:24 UTC (permalink / raw)
To: linux-arm-kernel
Exynos5420 is an octacore SoC. This patch series enables the remaining 4 cores.
Chander Kashyap (2):
clocksource: mct: extend mct to support 8 local interrupts for
Exynos5420
arm: dt: Exynos5420: populate cpu node enteries to 8 cpus
arch/arm/boot/dts/exynos5420.dtsi | 37 +++++++++++++++++++++++++++++++++++--
drivers/clocksource/exynos_mct.c | 4 ++++
2 files changed, 39 insertions(+), 2 deletions(-)
--
1.7.9.5
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] clocksource: mct: extend mct to support 8 local interrupts for Exynos5420
2013-09-05 9:24 [PATCH 0/2] Enable all cpus in Exynos5420 Chander Kashyap
@ 2013-09-05 9:24 ` Chander Kashyap
2013-09-05 9:24 ` [PATCH 2/2] arm: dt: Exynos5420: populate cpu node enteries to 8 cpus Chander Kashyap
1 sibling, 0 replies; 7+ messages in thread
From: Chander Kashyap @ 2013-09-05 9:24 UTC (permalink / raw)
To: linux-arm-kernel
Exynos5420 is octacore SoC from Samsung. Hence extend exynos-mct clocksource
driver to support 8 local interrupts.
Also extend dt entries for 8 interrupts.
Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
---
arch/arm/boot/dts/exynos5420.dtsi | 9 +++++++--
drivers/clocksource/exynos_mct.c | 4 ++++
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 6ce2f94..e97c87b 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -69,7 +69,8 @@
compatible = "samsung,exynos4210-mct";
reg = <0x101C0000 0x800>;
interrupt-parent = <&mct_map>;
- interrupts = <0>, <1>, <2>, <3>, <4>, <5>, <6>, <7>;
+ interrupts = <0>, <1>, <2>, <3>, <4>, <5>, <6>, <7>,
+ <8>, <9>, <10>, <11>;
clocks = <&clock 1>, <&clock 315>;
clock-names = "fin_pll", "mct";
@@ -84,7 +85,11 @@
<4 &gic 0 120 0>,
<5 &gic 0 121 0>,
<6 &gic 0 122 0>,
- <7 &gic 0 123 0>;
+ <7 &gic 0 123 0>,
+ <8 &gic 0 128 0>,
+ <9 &gic 0 129 0>,
+ <10 &gic 0 130 0>,
+ <11 &gic 0 131 0>;
};
};
diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_mct.c
index b2bbc41..ff4711e 100644
--- a/drivers/clocksource/exynos_mct.c
+++ b/drivers/clocksource/exynos_mct.c
@@ -71,6 +71,10 @@ enum {
MCT_L1_IRQ,
MCT_L2_IRQ,
MCT_L3_IRQ,
+ MCT_L4_IRQ,
+ MCT_L5_IRQ,
+ MCT_L6_IRQ,
+ MCT_L7_IRQ,
MCT_NR_IRQS,
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] arm: dt: Exynos5420: populate cpu node enteries to 8 cpus
2013-09-05 9:24 [PATCH 0/2] Enable all cpus in Exynos5420 Chander Kashyap
2013-09-05 9:24 ` [PATCH 1/2] clocksource: mct: extend mct to support 8 local interrupts for Exynos5420 Chander Kashyap
@ 2013-09-05 9:24 ` Chander Kashyap
2013-09-05 9:55 ` Tomasz Figa
1 sibling, 1 reply; 7+ messages in thread
From: Chander Kashyap @ 2013-09-05 9:24 UTC (permalink / raw)
To: linux-arm-kernel
Exynos5420 is octacore SoC from samsung.
Hence populate all the cpu node enteries.
Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
---
arch/arm/boot/dts/exynos5420.dtsi | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index e97c87b..59489f6 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -57,6 +57,34 @@
reg = <0x3>;
clock-frequency = <1800000000>;
};
+
+ cpu4: cpu at 4 {
+ device_type = "cpu";
+ compatible = "arm,cortex-a7";
+ reg = <0x100>;
+ clock-frequency = <1000000000>;
+ };
+
+ cpu5: cpu at 5 {
+ device_type = "cpu";
+ compatible = "arm,cortex-a7";
+ reg = <0x101>;
+ clock-frequency = <1000000000>;
+ };
+
+ cpu6: cpu at 6 {
+ device_type = "cpu";
+ compatible = "arm,cortex-a7";
+ reg = <0x102>;
+ clock-frequency = <1000000000>;
+ };
+
+ cpu7: cpu at 7 {
+ device_type = "cpu";
+ compatible = "arm,cortex-a7";
+ reg = <0x103>;
+ clock-frequency = <1000000000>;
+ };
};
clock: clock-controller at 0x10010000 {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] arm: dt: Exynos5420: populate cpu node enteries to 8 cpus
2013-09-05 9:24 ` [PATCH 2/2] arm: dt: Exynos5420: populate cpu node enteries to 8 cpus Chander Kashyap
@ 2013-09-05 9:55 ` Tomasz Figa
2013-09-05 10:03 ` Chander Kashyap
0 siblings, 1 reply; 7+ messages in thread
From: Tomasz Figa @ 2013-09-05 9:55 UTC (permalink / raw)
To: linux-arm-kernel
Hi Chander,
On Thursday 05 of September 2013 14:54:46 Chander Kashyap wrote:
> Exynos5420 is octacore SoC from samsung.
> Hence populate all the cpu node enteries.
>
> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
> ---
> arch/arm/boot/dts/exynos5420.dtsi | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
> b/arch/arm/boot/dts/exynos5420.dtsi index e97c87b..59489f6 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -57,6 +57,34 @@
> reg = <0x3>;
> clock-frequency = <1800000000>;
> };
> +
> + cpu4: cpu at 4 {
I believe this is a typo. The @unit-address suffix should match the value
of reg property.
> + device_type = "cpu";
> + compatible = "arm,cortex-a7";
> + reg = <0x100>;
> + clock-frequency = <1000000000>;
> + };
> +
> + cpu5: cpu at 5 {
Ditto.
> + device_type = "cpu";
> + compatible = "arm,cortex-a7";
> + reg = <0x101>;
> + clock-frequency = <1000000000>;
> + };
> +
> + cpu6: cpu at 6 {
Ditto.
> + device_type = "cpu";
> + compatible = "arm,cortex-a7";
> + reg = <0x102>;
> + clock-frequency = <1000000000>;
> + };
> +
> + cpu7: cpu at 7 {
Ditto.
> + device_type = "cpu";
> + compatible = "arm,cortex-a7";
> + reg = <0x103>;
> + clock-frequency = <1000000000>;
> + };
> };
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] arm: dt: Exynos5420: populate cpu node enteries to 8 cpus
2013-09-05 9:55 ` Tomasz Figa
@ 2013-09-05 10:03 ` Chander Kashyap
2013-09-05 10:10 ` Tomasz Figa
0 siblings, 1 reply; 7+ messages in thread
From: Chander Kashyap @ 2013-09-05 10:03 UTC (permalink / raw)
To: linux-arm-kernel
Hi Tomasz,
On 5 September 2013 15:25, Tomasz Figa <t.figa@samsung.com> wrote:
> Hi Chander,
>
> On Thursday 05 of September 2013 14:54:46 Chander Kashyap wrote:
>> Exynos5420 is octacore SoC from samsung.
>> Hence populate all the cpu node enteries.
>>
>> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
>> ---
>> arch/arm/boot/dts/exynos5420.dtsi | 28 ++++++++++++++++++++++++++++
>> 1 file changed, 28 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
>> b/arch/arm/boot/dts/exynos5420.dtsi index e97c87b..59489f6 100644
>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>> @@ -57,6 +57,34 @@
>> reg = <0x3>;
>> clock-frequency = <1800000000>;
>> };
>> +
>> + cpu4: cpu at 4 {
>
> I believe this is a typo. The @unit-address suffix should match the value
> of reg property.
No this is not typo. It is the MPIDR value of the cpu. (24 bits of
MPIDR register).
>
>> + device_type = "cpu";
>> + compatible = "arm,cortex-a7";
>> + reg = <0x100>;
>> + clock-frequency = <1000000000>;
>> + };
>> +
>> + cpu5: cpu at 5 {
>
> Ditto.
>
>> + device_type = "cpu";
>> + compatible = "arm,cortex-a7";
>> + reg = <0x101>;
>> + clock-frequency = <1000000000>;
>> + };
>> +
>> + cpu6: cpu at 6 {
>
> Ditto.
>
>> + device_type = "cpu";
>> + compatible = "arm,cortex-a7";
>> + reg = <0x102>;
>> + clock-frequency = <1000000000>;
>> + };
>> +
>> + cpu7: cpu at 7 {
>
> Ditto.
>
>> + device_type = "cpu";
>> + compatible = "arm,cortex-a7";
>> + reg = <0x103>;
>> + clock-frequency = <1000000000>;
>> + };
>> };
>
> Best regards,
> Tomasz
>
--
with warm regards,
Chander Kashyap
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] arm: dt: Exynos5420: populate cpu node enteries to 8 cpus
2013-09-05 10:03 ` Chander Kashyap
@ 2013-09-05 10:10 ` Tomasz Figa
2013-09-05 10:15 ` Chander Kashyap
0 siblings, 1 reply; 7+ messages in thread
From: Tomasz Figa @ 2013-09-05 10:10 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 05 of September 2013 15:33:17 Chander Kashyap wrote:
> Hi Tomasz,
>
> On 5 September 2013 15:25, Tomasz Figa <t.figa@samsung.com> wrote:
> > Hi Chander,
> >
> > On Thursday 05 of September 2013 14:54:46 Chander Kashyap wrote:
> >> Exynos5420 is octacore SoC from samsung.
> >> Hence populate all the cpu node enteries.
> >>
> >> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
> >> ---
> >>
> >> arch/arm/boot/dts/exynos5420.dtsi | 28 ++++++++++++++++++++++++++++
> >> 1 file changed, 28 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
> >> b/arch/arm/boot/dts/exynos5420.dtsi index e97c87b..59489f6 100644
> >> --- a/arch/arm/boot/dts/exynos5420.dtsi
> >> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> >> @@ -57,6 +57,34 @@
> >>
> >> reg = <0x3>;
> >> clock-frequency = <1800000000>;
> >>
> >> };
> >>
> >> +
> >> + cpu4: cpu at 4 {
> >
> > I believe this is a typo. The @unit-address suffix should match the
> > value of reg property.
>
> No this is not typo. It is the MPIDR value of the cpu. (24 bits of
> MPIDR register).
Right. This is what the reg property should be set to. However, the @unit-
address prefix of node name should match the value of reg property, so if
the value of reg property is 0x100, then the node should be named cpu at 100.
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] arm: dt: Exynos5420: populate cpu node enteries to 8 cpus
2013-09-05 10:10 ` Tomasz Figa
@ 2013-09-05 10:15 ` Chander Kashyap
0 siblings, 0 replies; 7+ messages in thread
From: Chander Kashyap @ 2013-09-05 10:15 UTC (permalink / raw)
To: linux-arm-kernel
On 5 September 2013 15:40, Tomasz Figa <t.figa@samsung.com> wrote:
> On Thursday 05 of September 2013 15:33:17 Chander Kashyap wrote:
>> Hi Tomasz,
>>
>> On 5 September 2013 15:25, Tomasz Figa <t.figa@samsung.com> wrote:
>> > Hi Chander,
>> >
>> > On Thursday 05 of September 2013 14:54:46 Chander Kashyap wrote:
>> >> Exynos5420 is octacore SoC from samsung.
>> >> Hence populate all the cpu node enteries.
>> >>
>> >> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
>> >> ---
>> >>
>> >> arch/arm/boot/dts/exynos5420.dtsi | 28 ++++++++++++++++++++++++++++
>> >> 1 file changed, 28 insertions(+)
>> >>
>> >> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
>> >> b/arch/arm/boot/dts/exynos5420.dtsi index e97c87b..59489f6 100644
>> >> --- a/arch/arm/boot/dts/exynos5420.dtsi
>> >> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>> >> @@ -57,6 +57,34 @@
>> >>
>> >> reg = <0x3>;
>> >> clock-frequency = <1800000000>;
>> >>
>> >> };
>> >>
>> >> +
>> >> + cpu4: cpu at 4 {
>> >
>> > I believe this is a typo. The @unit-address suffix should match the
>> > value of reg property.
>>
>> No this is not typo. It is the MPIDR value of the cpu. (24 bits of
>> MPIDR register).
>
> Right. This is what the reg property should be set to. However, the @unit-
> address prefix of node name should match the value of reg property, so if
> the value of reg property is 0x100, then the node should be named cpu at 100.
Ah ok,
Thanks. I will spin out a new version and send
>
> Best regards,
> Tomasz
>
--
with warm regards,
Chander Kashyap
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-09-05 10:15 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-05 9:24 [PATCH 0/2] Enable all cpus in Exynos5420 Chander Kashyap
2013-09-05 9:24 ` [PATCH 1/2] clocksource: mct: extend mct to support 8 local interrupts for Exynos5420 Chander Kashyap
2013-09-05 9:24 ` [PATCH 2/2] arm: dt: Exynos5420: populate cpu node enteries to 8 cpus Chander Kashyap
2013-09-05 9:55 ` Tomasz Figa
2013-09-05 10:03 ` Chander Kashyap
2013-09-05 10:10 ` Tomasz Figa
2013-09-05 10:15 ` Chander Kashyap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).