* [PATCH 1/2] ARM: dts: imx53-qsb: add TVE entry
@ 2013-09-11 9:51 Lucas Stach
2013-09-11 9:51 ` [PATCH 2/2] ARM: dts: imx53-qsb: select open-drain mode for i2c1 pads Lucas Stach
2013-09-13 6:58 ` [PATCH 1/2] ARM: dts: imx53-qsb: add TVE entry Shawn Guo
0 siblings, 2 replies; 5+ messages in thread
From: Lucas Stach @ 2013-09-11 9:51 UTC (permalink / raw)
To: linux-arm-kernel
From: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
arch/arm/boot/dts/imx53-qsb.dts | 25 +++++++++++++++++++++++--
1 file changed, 23 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx53-qsb.dts b/arch/arm/boot/dts/imx53-qsb.dts
index 512a1f6..2031ccc 100644
--- a/arch/arm/boot/dts/imx53-qsb.dts
+++ b/arch/arm/boot/dts/imx53-qsb.dts
@@ -156,6 +156,15 @@
};
};
+ tve {
+ pinctrl_vga_sync_1: vgasync-grp1 {
+ fsl,pins = <
+ /* VGA_HSYNC, VSYNC with max drive strength */
+ MX53_PAD_EIM_OE__IPU_DI1_PIN7 0xe6
+ MX53_PAD_EIM_RW__IPU_DI1_PIN8 0xe6
+ >;
+ };
+ };
};
&uart1 {
@@ -263,8 +272,8 @@
};
ldo8_reg: ldo8 {
- regulator-min-microvolt = <1200000>;
- regulator-max-microvolt = <3600000>;
+ regulator-min-microvolt = <2750000>;
+ regulator-max-microvolt = <2750000>;
regulator-always-on;
};
@@ -297,6 +306,18 @@
status = "okay";
};
+&tve {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_vga_sync_1>;
+ ddc = <&i2c2>;
+ fsl,tve-mode = "vga";
+ status = "okay";
+ dac-supply = <&ldo7_reg>;
+
+ fsl,hsync-pin = <7>; /* IPU DI1 PIN7 via EIM_OE */
+ fsl,vsync-pin = <8>; /* IPU DI1 PIN8 via EIM_RW */
+};
+
&usbh1 {
status = "okay";
};
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] ARM: dts: imx53-qsb: select open-drain mode for i2c1 pads
2013-09-11 9:51 [PATCH 1/2] ARM: dts: imx53-qsb: add TVE entry Lucas Stach
@ 2013-09-11 9:51 ` Lucas Stach
2013-09-13 6:58 ` [PATCH 1/2] ARM: dts: imx53-qsb: add TVE entry Shawn Guo
1 sibling, 0 replies; 5+ messages in thread
From: Lucas Stach @ 2013-09-11 9:51 UTC (permalink / raw)
To: linux-arm-kernel
The pull-ups on this bus are connected to the 1.8V plane.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
arch/arm/boot/dts/imx53-qsb.dts | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx53-qsb.dts b/arch/arm/boot/dts/imx53-qsb.dts
index 2031ccc..29d81da 100644
--- a/arch/arm/boot/dts/imx53-qsb.dts
+++ b/arch/arm/boot/dts/imx53-qsb.dts
@@ -155,6 +155,16 @@
>;
};
};
+
+ i2c1 {
+ /* open drain */
+ pinctrl_i2c1_qsb: i2c1grp-1 {
+ fsl,pins = <
+ MX53_PAD_CSI0_DAT8__I2C1_SDA 0x400001cc
+ MX53_PAD_CSI0_DAT9__I2C1_SCL 0x400001cc
+ >;
+ };
+ };
tve {
pinctrl_vga_sync_1: vgasync-grp1 {
@@ -189,7 +199,7 @@
&i2c1 {
pinctrl-names = "default";
- pinctrl-0 = <&pinctrl_i2c1_1>;
+ pinctrl-0 = <&pinctrl_i2c1_qsb>;
status = "okay";
accelerometer: mma8450 at 1c {
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 1/2] ARM: dts: imx53-qsb: add TVE entry
2013-09-11 9:51 [PATCH 1/2] ARM: dts: imx53-qsb: add TVE entry Lucas Stach
2013-09-11 9:51 ` [PATCH 2/2] ARM: dts: imx53-qsb: select open-drain mode for i2c1 pads Lucas Stach
@ 2013-09-13 6:58 ` Shawn Guo
2013-09-13 8:25 ` Philipp Zabel
1 sibling, 1 reply; 5+ messages in thread
From: Shawn Guo @ 2013-09-13 6:58 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 11, 2013 at 11:51:07AM +0200, Lucas Stach wrote:
> From: Philipp Zabel <p.zabel@pengutronix.de>
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> arch/arm/boot/dts/imx53-qsb.dts | 25 +++++++++++++++++++++++--
> 1 file changed, 23 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx53-qsb.dts b/arch/arm/boot/dts/imx53-qsb.dts
> index 512a1f6..2031ccc 100644
> --- a/arch/arm/boot/dts/imx53-qsb.dts
> +++ b/arch/arm/boot/dts/imx53-qsb.dts
> @@ -156,6 +156,15 @@
> };
> };
>
> + tve {
> + pinctrl_vga_sync_1: vgasync-grp1 {
> + fsl,pins = <
> + /* VGA_HSYNC, VSYNC with max drive strength */
> + MX53_PAD_EIM_OE__IPU_DI1_PIN7 0xe6
> + MX53_PAD_EIM_RW__IPU_DI1_PIN8 0xe6
> + >;
> + };
> + };
> };
>
> &uart1 {
> @@ -263,8 +272,8 @@
> };
>
> ldo8_reg: ldo8 {
> - regulator-min-microvolt = <1200000>;
> - regulator-max-microvolt = <3600000>;
> + regulator-min-microvolt = <2750000>;
> + regulator-max-microvolt = <2750000>;
Instead of having nothing in commit log, you can explain a little bit
why the change is needed in there.
> regulator-always-on;
> };
>
> @@ -297,6 +306,18 @@
> status = "okay";
> };
>
> +&tve {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_vga_sync_1>;
> + ddc = <&i2c2>;
> + fsl,tve-mode = "vga";
Are these custom properties documented anywhere? I cannot find the
device tree bindings document for them. Anyway, it should be another
patch to provide the document, if you like.
> + status = "okay";
Nit: please put 'status' at the bottom of the property list.
> + dac-supply = <&ldo7_reg>;
> +
Nit: drop this blank line.
Shawn
> + fsl,hsync-pin = <7>; /* IPU DI1 PIN7 via EIM_OE */
> + fsl,vsync-pin = <8>; /* IPU DI1 PIN8 via EIM_RW */
> +};
> +
> &usbh1 {
> status = "okay";
> };
> --
> 1.8.4.rc3
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] ARM: dts: imx53-qsb: add TVE entry
2013-09-13 6:58 ` [PATCH 1/2] ARM: dts: imx53-qsb: add TVE entry Shawn Guo
@ 2013-09-13 8:25 ` Philipp Zabel
2013-09-13 8:38 ` Shawn Guo
0 siblings, 1 reply; 5+ messages in thread
From: Philipp Zabel @ 2013-09-13 8:25 UTC (permalink / raw)
To: linux-arm-kernel
Hi Shawn,
Am Freitag, den 13.09.2013, 14:58 +0800 schrieb Shawn Guo:
> On Wed, Sep 11, 2013 at 11:51:07AM +0200, Lucas Stach wrote:
> > From: Philipp Zabel <p.zabel@pengutronix.de>
> >
> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > ---
> > arch/arm/boot/dts/imx53-qsb.dts | 25 +++++++++++++++++++++++--
> > 1 file changed, 23 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/imx53-qsb.dts b/arch/arm/boot/dts/imx53-qsb.dts
> > index 512a1f6..2031ccc 100644
> > --- a/arch/arm/boot/dts/imx53-qsb.dts
> > +++ b/arch/arm/boot/dts/imx53-qsb.dts
> > @@ -156,6 +156,15 @@
> > };
> > };
> >
> > + tve {
> > + pinctrl_vga_sync_1: vgasync-grp1 {
> > + fsl,pins = <
> > + /* VGA_HSYNC, VSYNC with max drive strength */
> > + MX53_PAD_EIM_OE__IPU_DI1_PIN7 0xe6
> > + MX53_PAD_EIM_RW__IPU_DI1_PIN8 0xe6
> > + >;
> > + };
> > + };
> > };
> >
> > &uart1 {
> > @@ -263,8 +272,8 @@
> > };
> >
> > ldo8_reg: ldo8 {
> > - regulator-min-microvolt = <1200000>;
> > - regulator-max-microvolt = <3600000>;
> > + regulator-min-microvolt = <2750000>;
> > + regulator-max-microvolt = <2750000>;
>
> Instead of having nothing in commit log, you can explain a little bit
> why the change is needed in there.
>
> > regulator-always-on;
> > };
> >
> > @@ -297,6 +306,18 @@
> > status = "okay";
> > };
> >
> > +&tve {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_vga_sync_1>;
> > + ddc = <&i2c2>;
> > + fsl,tve-mode = "vga";
>
> Are these custom properties documented anywhere? I cannot find the
> device tree bindings document for them. Anyway, it should be another
> patch to provide the document, if you like.
No, and I'd actually like to get rid of them, eventually.
If we can use the CDF/V4L2 entity model, the TVE will just be an encoder
entity with an output pad connected to a VGA connector node (or FBAS, or
S-Video, ...).
The ddc i2c bus property should then be placed on the actual (VGA)
connector node. Also the tve-mode could be inferred from the type of
connector (and even changed at runtime if there's both an S-Video and a
Composite connector, for example).
Maybe I should send a minimal patch without the two custom device tree
properties for now?
> > + status = "okay";
>
> Nit: please put 'status' at the bottom of the property list.
Ok.
> > + dac-supply = <&ldo7_reg>;
> > +
>
> Nit: drop this blank line.
Will do.
> Shawn
>
> > + fsl,hsync-pin = <7>; /* IPU DI1 PIN7 via EIM_OE */
> > + fsl,vsync-pin = <8>; /* IPU DI1 PIN8 via EIM_RW */
> > +};
> > +
> > &usbh1 {
> > status = "okay";
> > };
> > --
> > 1.8.4.rc3
> >
regards
Philipp
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] ARM: dts: imx53-qsb: add TVE entry
2013-09-13 8:25 ` Philipp Zabel
@ 2013-09-13 8:38 ` Shawn Guo
0 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2013-09-13 8:38 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Sep 13, 2013 at 10:25:10AM +0200, Philipp Zabel wrote:
> > > @@ -297,6 +306,18 @@
> > > status = "okay";
> > > };
> > >
> > > +&tve {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&pinctrl_vga_sync_1>;
> > > + ddc = <&i2c2>;
> > > + fsl,tve-mode = "vga";
> >
> > Are these custom properties documented anywhere? I cannot find the
> > device tree bindings document for them. Anyway, it should be another
> > patch to provide the document, if you like.
>
> No, and I'd actually like to get rid of them, eventually.
>
> If we can use the CDF/V4L2 entity model, the TVE will just be an encoder
> entity with an output pad connected to a VGA connector node (or FBAS, or
> S-Video, ...).
> The ddc i2c bus property should then be placed on the actual (VGA)
> connector node. Also the tve-mode could be inferred from the type of
> connector (and even changed at runtime if there's both an S-Video and a
> Composite connector, for example).
>
> Maybe I should send a minimal patch without the two custom device tree
> properties for now?
Yeah, sounds good.
Shawn
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-09-13 8:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-11 9:51 [PATCH 1/2] ARM: dts: imx53-qsb: add TVE entry Lucas Stach
2013-09-11 9:51 ` [PATCH 2/2] ARM: dts: imx53-qsb: select open-drain mode for i2c1 pads Lucas Stach
2013-09-13 6:58 ` [PATCH 1/2] ARM: dts: imx53-qsb: add TVE entry Shawn Guo
2013-09-13 8:25 ` Philipp Zabel
2013-09-13 8:38 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).