linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: dwmw2@infradead.org (David Woodhouse)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/8] Add the Quadspi driver for vf610-twr
Date: Thu, 12 Sep 2013 15:03:16 +0100	[thread overview]
Message-ID: <1378994596.2627.449.camel@shinybook.infradead.org> (raw)
In-Reply-To: <20130912134345.GQ29403@sirena.org.uk>

On Thu, 2013-09-12 at 14:43 +0100, Mark Brown wrote:
> 
> > I only know what's in the patch that you have also received, but it
> > seems to be a table of commands. To send a given command to the flash,
> > you write the actual command to the some slot in the LUT, then 'trigger'
> > it by writing its index to another register.
> 
> OK, so the LUT itself isn't a generic mtd thing, though the commands
> it's apparently sending are?

Kind of.

Imagine you have a controller with a set of SRAM buffers for transmit
data.

One might normally imagine that when you get a request to make a
transaction, you'd load the data-to-be-sent into one of the buffers,
then trigger a "send from buffer <X>".

Not so in this case. The controller driver appears "know", in advance,
what commands are going to be sent. It preloads its buffers (the LUT)
with what it *expects* us to send, and when we make a request it'll just
trigger a send from the appropriate buffer. And it will crap itself if
we actually try to send anything *different*.

Or so I understand it.

So to go back to your question: the commands that it "knows" we are
going to send are indeed specific to (one particular type of) SPI NOR
flash. But there's nothing on the MTD side which justifies that
assumption. Even if you use a different type of SPI NOR flash which uses
different opcodes for its commands, this broken scheme will fall over.

Unless, as I say, I've completely misunderstood what's going on here.
Huang?

-- 
dwmw2

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5745 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130912/61d78a7d/attachment-0001.bin>

  reply	other threads:[~2013-09-12 14:03 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-30  2:07 [PATCH v3 0/8] Add the Quadspi driver for vf610-twr Huang Shijie
2013-08-30  2:07 ` [PATCH v3 1/8] mtd: m25p80: move the spi-nor commands to a header Huang Shijie
2013-08-30  2:07 ` [PATCH v3 2/8] mtd: m25p80: add support for Spansion s25fl128s chip Huang Shijie
2013-08-30  2:07 ` [PATCH v3 3/8] mtd: m25p80: add the quad-read support Huang Shijie
2013-08-30  2:07 ` [PATCH v3 4/8] mtd: m25p80: add the DDR " Huang Shijie
2013-08-30  2:07 ` [PATCH v3 5/8] spi: Add Freescale QuadSpi driver Huang Shijie
2013-09-10 18:09   ` Mark Brown
2013-09-11  2:40     ` Huang Shijie
2013-09-11 10:39       ` Mark Brown
2013-08-30  2:07 ` [PATCH v3 6/8] Documentation: add the binding file for Quadspi driver Huang Shijie
2013-08-30  2:07 ` [PATCH v3 7/8] ARM: dts: vf610: change the PAD values for Quadspi Huang Shijie
2013-08-30  2:07 ` [PATCH v3 8/8] ARM: dts: vf610-twr: Add SPI NOR support Huang Shijie
2013-09-04  2:16 ` [PATCH v3 0/8] Add the Quadspi driver for vf610-twr Huang Shijie
2013-09-04  9:55   ` Mark Brown
2013-09-04 10:29     ` Huang Shijie
2013-09-04 11:33       ` Mark Brown
2013-09-05  1:43         ` Huang Shijie
2013-09-04 13:45           ` thomas.langer at lantiq.com
2013-09-05  2:04             ` Huang Shijie
2013-09-05  4:25               ` Gupta, Pekon
2013-09-05  5:34                 ` Huang Shijie
2013-09-05  6:32                   ` Gupta, Pekon
2013-09-05  7:45                     ` Huang Shijie
2013-09-05  9:11                       ` Gupta, Pekon
2013-09-05  9:30                         ` Huang Shijie
2013-09-05 13:50                           ` Mark Brown
2013-09-06  2:36                             ` Huang Shijie
2013-09-08 13:47                               ` Mark Brown
2013-09-09  3:07                                 ` Huang Shijie
2013-09-09 15:14                                   ` Mark Brown
2013-09-10  6:59                                     ` Huang Shijie
2013-09-10 18:07                                       ` Mark Brown
2013-09-11  2:38                                         ` Huang Shijie
2013-09-11 10:41                                           ` Mark Brown
2013-09-11 10:54                                             ` Huang Shijie
2013-09-11 11:30                                               ` Mark Brown
2013-09-11 12:26                                                 ` Gupta, Pekon
2013-09-11 12:35                                                   ` Mark Brown
2013-09-12  9:18                                                 ` Huang Shijie
2013-09-12 10:20                                                   ` Mark Brown
2013-09-13  3:30                                                     ` Huang Shijie
2013-09-12 15:32                                                       ` David Woodhouse
2013-09-12 10:39                                                   ` David Woodhouse
2013-09-12 10:56                                                     ` Gupta, Pekon
2013-09-12 11:17                                                       ` David Woodhouse
2013-09-12 11:48                                                         ` Mark Brown
2013-09-12 11:55                                                           ` Russell King - ARM Linux
2013-09-12 13:24                                                             ` Mark Brown
2013-09-12 13:25                                                             ` Ricard Wanderlof
2013-09-12 14:10                                                               ` Russell King - ARM Linux
2013-09-12 12:02                                                           ` David Woodhouse
2013-09-12 13:43                                                             ` Mark Brown
2013-09-12 14:03                                                               ` David Woodhouse [this message]
2013-09-12 14:40                                                                 ` Mark Brown
2013-09-13  3:14                                                                 ` Huang Shijie
2013-09-11 14:05                                               ` David Woodhouse
2013-09-11 15:07                                                 ` Mark Brown
     [not found]                                   ` <20130909151450 <52318953.6090405@freescale.com>
     [not found]                                     ` <52318953.6090405@freescale.com>
2013-09-12  9:50                                       ` David Woodhouse
2013-09-12 10:19                                         ` Mark Brown
2013-09-13  2:58                                         ` Huang Shijie
2013-09-12 15:22                                           ` David Woodhouse
2013-09-13  4:12                                             ` Huang Shijie
2013-09-12 16:26                                               ` David Woodhouse
2013-09-13  3:06                                                 ` Huang Shijie
2013-09-12 16:27                                               ` Fabio Estevam
2013-09-13  2:21                                                 ` Huang Shijie
2013-09-12 20:56                                               ` Mark Brown
2013-09-13  4:55                                                 ` Huang Shijie
2013-09-13 10:21                                                   ` Mark Brown
2013-09-16  2:40                                                     ` Huang Shijie
2013-09-16 10:19                                                       ` Mark Brown
2013-09-16 10:27                                                         ` Huang Shijie
2013-09-16 11:06                                                           ` Mark Brown
2013-09-17  2:14                                                             ` Huang Shijie
2013-09-17 10:51                                                               ` Mark Brown
2013-09-17 15:05                                                                 ` Gerhard Sittig
2013-09-17 16:49                                                                   ` Gerhard Sittig
2013-09-17 19:54                                                                     ` Sourav Poddar
2013-09-17 19:13                                                                   ` Mark Brown
2013-09-18 15:40                                                                     ` David Woodhouse
2013-09-18 16:00                                                                       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378994596.2627.449.camel@shinybook.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).