[PATCH 01/10] clk: bcm2835: Remove duplicate inclusion of clk-provider.h

[PATCH 01/10] clk: bcm2835: Remove duplicate inclusion of clk-provider.h

[Sachin Kamat]

clk-provider.h was included twice.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Stephen Warren <swarren@wwwdotorg.org>
---
 drivers/clk/clk-bcm2835.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/clk/clk-bcm2835.c b/drivers/clk/clk-bcm2835.c
index 5fb4ff5..676077d 100644
--- a/drivers/clk/clk-bcm2835.c
+++ b/drivers/clk/clk-bcm2835.c
@@ -20,7 +20,6 @@
 #include <linux/clk-provider.h>
 #include <linux/clkdev.h>
 #include <linux/clk/bcm2835.h>
-#include <linux/clk-provider.h>
 #include <linux/of.h>
 
 static const struct of_device_id clk_match[] __initconst = {
-- 
1.7.9.5

[PATCH 02/10] clk: SPEAr: Staticize clk_frac_ops

[Sachin Kamat]

clk_frac_ops is local to this file. Make it static.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/clk/spear/clk-frac-synth.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/spear/clk-frac-synth.c b/drivers/clk/spear/clk-frac-synth.c
index 958aa3a..dffd4ce 100644
--- a/drivers/clk/spear/clk-frac-synth.c
+++ b/drivers/clk/spear/clk-frac-synth.c
@@ -116,7 +116,7 @@ static int clk_frac_set_rate(struct clk_hw *hw, unsigned long drate,
 	return 0;
 }
 
-struct clk_ops clk_frac_ops = {
+static struct clk_ops clk_frac_ops = {
 	.recalc_rate = clk_frac_recalc_rate,
 	.round_rate = clk_frac_round_rate,
 	.set_rate = clk_frac_set_rate,
-- 
1.7.9.5

[PATCH 03/10] clk: tegra: Staticize local variables in clk-pll.c

[Sachin Kamat]

Local variables used only in this file are made static.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Stephen Warren <swarren@wwwdotorg.org>
---
 drivers/clk/tegra/clk-pll.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c
index 197074a..76ed452 100644
--- a/drivers/clk/tegra/clk-pll.c
+++ b/drivers/clk/tegra/clk-pll.c
@@ -1340,7 +1340,7 @@ struct clk *tegra_clk_register_plle(const char *name, const char *parent_name,
 }
 
 #ifdef CONFIG_ARCH_TEGRA_114_SOC
-const struct clk_ops tegra_clk_pllxc_ops = {
+static const struct clk_ops tegra_clk_pllxc_ops = {
 	.is_enabled = clk_pll_is_enabled,
 	.enable = clk_pll_iddq_enable,
 	.disable = clk_pll_iddq_disable,
@@ -1349,7 +1349,7 @@ const struct clk_ops tegra_clk_pllxc_ops = {
 	.set_rate = clk_pllxc_set_rate,
 };
 
-const struct clk_ops tegra_clk_pllm_ops = {
+static const struct clk_ops tegra_clk_pllm_ops = {
 	.is_enabled = clk_pll_is_enabled,
 	.enable = clk_pll_iddq_enable,
 	.disable = clk_pll_iddq_disable,
@@ -1358,7 +1358,7 @@ const struct clk_ops tegra_clk_pllm_ops = {
 	.set_rate = clk_pllm_set_rate,
 };
 
-const struct clk_ops tegra_clk_pllc_ops = {
+static const struct clk_ops tegra_clk_pllc_ops = {
 	.is_enabled = clk_pll_is_enabled,
 	.enable = clk_pllc_enable,
 	.disable = clk_pllc_disable,
@@ -1367,7 +1367,7 @@ const struct clk_ops tegra_clk_pllc_ops = {
 	.set_rate = clk_pllc_set_rate,
 };
 
-const struct clk_ops tegra_clk_pllre_ops = {
+static const struct clk_ops tegra_clk_pllre_ops = {
 	.is_enabled = clk_pll_is_enabled,
 	.enable = clk_pll_iddq_enable,
 	.disable = clk_pll_iddq_disable,
@@ -1376,7 +1376,7 @@ const struct clk_ops tegra_clk_pllre_ops = {
 	.set_rate = clk_pllre_set_rate,
 };
 
-const struct clk_ops tegra_clk_plle_tegra114_ops = {
+static const struct clk_ops tegra_clk_plle_tegra114_ops = {
 	.is_enabled =  clk_pll_is_enabled,
 	.enable = clk_plle_tegra114_enable,
 	.disable = clk_plle_tegra114_disable,
-- 
1.7.9.5

[PATCH 04/10] clk: tegra: Staticize tegra_clk_periph_nodiv_ops

[Sachin Kamat]

tegra_clk_periph_nodiv_ops is used only in this file. Make it static.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Stephen Warren <swarren@wwwdotorg.org>
---
 drivers/clk/tegra/clk-periph.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/tegra/clk-periph.c b/drivers/clk/tegra/clk-periph.c
index b2309d3..2c0bfa2 100644
--- a/drivers/clk/tegra/clk-periph.c
+++ b/drivers/clk/tegra/clk-periph.c
@@ -162,7 +162,7 @@ const struct clk_ops tegra_clk_periph_ops = {
 	.disable = clk_periph_disable,
 };
 
-const struct clk_ops tegra_clk_periph_nodiv_ops = {
+static const struct clk_ops tegra_clk_periph_nodiv_ops = {
 	.get_parent = clk_periph_get_parent,
 	.set_parent = clk_periph_set_parent,
 	.is_enabled = clk_periph_is_enabled,
-- 
1.7.9.5

[PATCH 05/10] clk: socfpga: Use NULL instead of 0

[Sachin Kamat]

'div_reg' is a pointer. Assign NULL instead of 0.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Dinh Nguyen <dinguyen@altera.com>
---
 drivers/clk/socfpga/clk.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/socfpga/clk.c b/drivers/clk/socfpga/clk.c
index 5bb848c..454ddc1 100644
--- a/drivers/clk/socfpga/clk.c
+++ b/drivers/clk/socfpga/clk.c
@@ -292,7 +292,7 @@ static void __init socfpga_gate_clk_init(struct device_node *node,
 		socfpga_clk->shift = div_reg[1];
 		socfpga_clk->width = div_reg[2];
 	} else {
-		socfpga_clk->div_reg = 0;
+		socfpga_clk->div_reg = NULL;
 	}
 
 	of_property_read_string(node, "clock-output-names", &clk_name);
-- 
1.7.9.5

[PATCH 06/10] clk: versatile: Staticize clk_sp810_timerclken_of_get

[Sachin Kamat]

clk_sp810_timerclken_of_get is used only in this file. Make it static.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/clk/versatile/clk-sp810.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/versatile/clk-sp810.c b/drivers/clk/versatile/clk-sp810.c
index bf9b15a..c6e86a9 100644
--- a/drivers/clk/versatile/clk-sp810.c
+++ b/drivers/clk/versatile/clk-sp810.c
@@ -123,7 +123,7 @@ static const struct clk_ops clk_sp810_timerclken_ops = {
 	.set_parent = clk_sp810_timerclken_set_parent,
 };
 
-struct clk *clk_sp810_timerclken_of_get(struct of_phandle_args *clkspec,
+static struct clk *clk_sp810_timerclken_of_get(struct of_phandle_args *clkspec,
 		void *data)
 {
 	struct clk_sp810 *sp810 = data;
-- 
1.7.9.5

[PATCH 07/10] clk: mvebu: Staticize of_cpu_clk_setup

[Sachin Kamat]

'of_cpu_clk_setup' is used only in this file. Make it static.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
---
 drivers/clk/mvebu/clk-cpu.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/mvebu/clk-cpu.c b/drivers/clk/mvebu/clk-cpu.c
index 1466865..8ebf757 100644
--- a/drivers/clk/mvebu/clk-cpu.c
+++ b/drivers/clk/mvebu/clk-cpu.c
@@ -101,7 +101,7 @@ static const struct clk_ops cpu_ops = {
 	.set_rate = clk_cpu_set_rate,
 };
 
-void __init of_cpu_clk_setup(struct device_node *node)
+static void __init of_cpu_clk_setup(struct device_node *node)
 {
 	struct cpu_clk *cpuclk;
 	void __iomem *clock_complex_base = of_iomap(node, 0);
-- 
1.7.9.5

[PATCH 08/10] clk: vt8500: Staticize vtwm_pll_ops

[Sachin Kamat]

'vtwm_pll_ops' is local to this file. Make it static.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Tony Prisk <linux@prisktech.co.nz>
---
 drivers/clk/clk-vt8500.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c
index 82306f5..a45e7a6 100644
--- a/drivers/clk/clk-vt8500.c
+++ b/drivers/clk/clk-vt8500.c
@@ -620,7 +620,7 @@ static unsigned long vtwm_pll_recalc_rate(struct clk_hw *hw,
 	return pll_freq;
 }
 
-const struct clk_ops vtwm_pll_ops = {
+static const struct clk_ops vtwm_pll_ops = {
 	.round_rate = vtwm_pll_round_rate,
 	.set_rate = vtwm_pll_set_rate,
 	.recalc_rate = vtwm_pll_recalc_rate,
-- 
1.7.9.5

[PATCH 09/10] clk: ux500: Remove extra semicolon

[Sachin Kamat]

Extra semicolon is redundant. Remove it.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
---
 drivers/clk/ux500/clk-prcmu.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/ux500/clk-prcmu.c b/drivers/clk/ux500/clk-prcmu.c
index 293a288..e2d63bc 100644
--- a/drivers/clk/ux500/clk-prcmu.c
+++ b/drivers/clk/ux500/clk-prcmu.c
@@ -36,7 +36,7 @@ static int clk_prcmu_prepare(struct clk_hw *hw)
 	if (!ret)
 		clk->is_prepared = 1;
 
-	return ret;;
+	return ret;
 }
 
 static void clk_prcmu_unprepare(struct clk_hw *hw)
-- 
1.7.9.5

[PATCH 10/10] clk: max77686: Remove redundant break

[Sachin Kamat]

'break' after 'goto' is redundant. Remove it.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Jonghwa Lee <jonghwa3.lee@samsung.com>
---
 drivers/clk/clk-max77686.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/clk/clk-max77686.c b/drivers/clk/clk-max77686.c
index 9f57bc3..b4a1a97 100644
--- a/drivers/clk/clk-max77686.c
+++ b/drivers/clk/clk-max77686.c
@@ -157,11 +157,9 @@ static int max77686_clk_probe(struct platform_device *pdev)
 			case MAX77686_CLK_AP:
 				dev_err(&pdev->dev, "Fail to register CLK_AP\n");
 				goto err_clk_ap;
-				break;
 			case MAX77686_CLK_CP:
 				dev_err(&pdev->dev, "Fail to register CLK_CP\n");
 				goto err_clk_cp;
-				break;
 			case MAX77686_CLK_PMIC:
 				dev_err(&pdev->dev, "Fail to register CLK_PMIC\n");
 				goto err_clk_pmic;
-- 
1.7.9.5

[PATCH 02/10] clk: SPEAr: Staticize clk_frac_ops

[Viresh Kumar]

On 13 September 2013 14:53, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> clk_frac_ops is local to this file. Make it static.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> ---
>  drivers/clk/spear/clk-frac-synth.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/spear/clk-frac-synth.c b/drivers/clk/spear/clk-frac-synth.c
> index 958aa3a..dffd4ce 100644
> --- a/drivers/clk/spear/clk-frac-synth.c
> +++ b/drivers/clk/spear/clk-frac-synth.c
> @@ -116,7 +116,7 @@ static int clk_frac_set_rate(struct clk_hw *hw, unsigned long drate,
>         return 0;
>  }
>
> -struct clk_ops clk_frac_ops = {
> +static struct clk_ops clk_frac_ops = {
>         .recalc_rate = clk_frac_recalc_rate,
>         .round_rate = clk_frac_round_rate,
>         .set_rate = clk_frac_set_rate,

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

[PATCH 07/10] clk: mvebu: Staticize of_cpu_clk_setup

[Gregory CLEMENT]

On 13/09/2013 11:23, Sachin Kamat wrote:
> 'of_cpu_clk_setup' is used only in this file. Make it static.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>

Good catch, it should have been part of the "f640c0f clk: mvebu: Use
common of_clk_init() function" commit.

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

> ---
>  drivers/clk/mvebu/clk-cpu.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/mvebu/clk-cpu.c b/drivers/clk/mvebu/clk-cpu.c
> index 1466865..8ebf757 100644
> --- a/drivers/clk/mvebu/clk-cpu.c
> +++ b/drivers/clk/mvebu/clk-cpu.c
> @@ -101,7 +101,7 @@ static const struct clk_ops cpu_ops = {
>  	.set_rate = clk_cpu_set_rate,
>  };
>  
> -void __init of_cpu_clk_setup(struct device_node *node)
> +static void __init of_cpu_clk_setup(struct device_node *node)
>  {
>  	struct cpu_clk *cpuclk;
>  	void __iomem *clock_complex_base = of_iomap(node, 0);
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[PATCH 05/10] clk: socfpga: Use NULL instead of 0

[Dinh Nguyen]

On Fri, 2013-09-13 at 14:53 +0530, Sachin Kamat wrote:
> 'div_reg' is a pointer. Assign NULL instead of 0.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Dinh Nguyen <dinguyen@altera.com>
> ---
>  drivers/clk/socfpga/clk.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/socfpga/clk.c b/drivers/clk/socfpga/clk.c
> index 5bb848c..454ddc1 100644
> --- a/drivers/clk/socfpga/clk.c
> +++ b/drivers/clk/socfpga/clk.c
> @@ -292,7 +292,7 @@ static void __init socfpga_gate_clk_init(struct device_node *node,
>  		socfpga_clk->shift = div_reg[1];
>  		socfpga_clk->width = div_reg[2];
>  	} else {
> -		socfpga_clk->div_reg = 0;
> +		socfpga_clk->div_reg = NULL;
>  	}
>  
>  	of_property_read_string(node, "clock-output-names", &clk_name);

Acked-by: Dinh Nguyen <dinguyen@altera.com>

[PATCH 09/10] clk: ux500: Remove extra semicolon

[Ulf Hansson]

On 13 September 2013 11:23, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Extra semicolon is redundant. Remove it.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> ---
>  drivers/clk/ux500/clk-prcmu.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/ux500/clk-prcmu.c b/drivers/clk/ux500/clk-prcmu.c
> index 293a288..e2d63bc 100644
> --- a/drivers/clk/ux500/clk-prcmu.c
> +++ b/drivers/clk/ux500/clk-prcmu.c
> @@ -36,7 +36,7 @@ static int clk_prcmu_prepare(struct clk_hw *hw)
>         if (!ret)
>                 clk->is_prepared = 1;
>
> -       return ret;;
> +       return ret;
>  }
>
>  static void clk_prcmu_unprepare(struct clk_hw *hw)
> --
> 1.7.9.5
>

Acked-by: Ulf Hansson <ulf.hansson@linaro.org>

[PATCH 01/10] clk: bcm2835: Remove duplicate inclusion of clk-provider.h

[Sachin Kamat]

Mike,

On 13 September 2013 14:53, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> clk-provider.h was included twice.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> ---
>  drivers/clk/clk-bcm2835.c |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/clk/clk-bcm2835.c b/drivers/clk/clk-bcm2835.c
> index 5fb4ff5..676077d 100644
> --- a/drivers/clk/clk-bcm2835.c
> +++ b/drivers/clk/clk-bcm2835.c
> @@ -20,7 +20,6 @@
>  #include <linux/clk-provider.h>
>  #include <linux/clkdev.h>
>  #include <linux/clk/bcm2835.h>
> -#include <linux/clk-provider.h>
>  #include <linux/of.h>
>
>  static const struct of_device_id clk_match[] __initconst = {
> --
> 1.7.9.5
>

Gentle ping on this series.

-- 
With warm regards,
Sachin

[PATCH 01/10] clk: bcm2835: Remove duplicate inclusion of clk-provider.h

[Sachin Kamat]

 Hi Mike,

On 13 September 2013 14:53, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> clk-provider.h was included twice.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> ---
>  drivers/clk/clk-bcm2835.c |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/clk/clk-bcm2835.c b/drivers/clk/clk-bcm2835.c
> index 5fb4ff5..676077d 100644
> --- a/drivers/clk/clk-bcm2835.c
> +++ b/drivers/clk/clk-bcm2835.c
> @@ -20,7 +20,6 @@
>  #include <linux/clk-provider.h>
>  #include <linux/clkdev.h>
>  #include <linux/clk/bcm2835.h>
> -#include <linux/clk-provider.h>
>  #include <linux/of.h>
>
>  static const struct of_device_id clk_match[] __initconst = {
> --
> 1.7.9.5
>

 Gentle ping.

-- 
With warm regards,
Sachin

[PATCH 03/10] clk: tegra: Staticize local variables in clk-pll.c

[Sachin Kamat]

Local variables used only in this file are made static.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Stephen Warren <swarren@nvidia.com>
---
 drivers/clk/tegra/clk-pll.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c
index 197074a..76ed452 100644
--- a/drivers/clk/tegra/clk-pll.c
+++ b/drivers/clk/tegra/clk-pll.c
@@ -1340,7 +1340,7 @@ struct clk *tegra_clk_register_plle(const char *name, const char *parent_name,
 }
 
 #ifdef CONFIG_ARCH_TEGRA_114_SOC
-const struct clk_ops tegra_clk_pllxc_ops = {
+static const struct clk_ops tegra_clk_pllxc_ops = {
 	.is_enabled = clk_pll_is_enabled,
 	.enable = clk_pll_iddq_enable,
 	.disable = clk_pll_iddq_disable,
@@ -1349,7 +1349,7 @@ const struct clk_ops tegra_clk_pllxc_ops = {
 	.set_rate = clk_pllxc_set_rate,
 };
 
-const struct clk_ops tegra_clk_pllm_ops = {
+static const struct clk_ops tegra_clk_pllm_ops = {
 	.is_enabled = clk_pll_is_enabled,
 	.enable = clk_pll_iddq_enable,
 	.disable = clk_pll_iddq_disable,
@@ -1358,7 +1358,7 @@ const struct clk_ops tegra_clk_pllm_ops = {
 	.set_rate = clk_pllm_set_rate,
 };
 
-const struct clk_ops tegra_clk_pllc_ops = {
+static const struct clk_ops tegra_clk_pllc_ops = {
 	.is_enabled = clk_pll_is_enabled,
 	.enable = clk_pllc_enable,
 	.disable = clk_pllc_disable,
@@ -1367,7 +1367,7 @@ const struct clk_ops tegra_clk_pllc_ops = {
 	.set_rate = clk_pllc_set_rate,
 };
 
-const struct clk_ops tegra_clk_pllre_ops = {
+static const struct clk_ops tegra_clk_pllre_ops = {
 	.is_enabled = clk_pll_is_enabled,
 	.enable = clk_pll_iddq_enable,
 	.disable = clk_pll_iddq_disable,
@@ -1376,7 +1376,7 @@ const struct clk_ops tegra_clk_pllre_ops = {
 	.set_rate = clk_pllre_set_rate,
 };
 
-const struct clk_ops tegra_clk_plle_tegra114_ops = {
+static const struct clk_ops tegra_clk_plle_tegra114_ops = {
 	.is_enabled =  clk_pll_is_enabled,
 	.enable = clk_plle_tegra114_enable,
 	.disable = clk_plle_tegra114_disable,
-- 
1.7.9.5

[PATCH 03/10] clk: tegra: Staticize local variables in clk-pll.c

[Stephen Warren]

On 10/08/2013 05:17 AM, Sachin Kamat wrote:
> Local variables used only in this file are made static.

This might conflict with some of the cod re-org patches that Peter has
sent. Peter, can you please check. If it does, Peter may as well roll
this into his repost of all the Tegra clock patches...

[PATCH 03/10] clk: tegra: Staticize local variables in clk-pll.c

[Peter De Schrijver]

On Tue, Oct 08, 2013 at 06:09:24PM +0200, Stephen Warren wrote:
> On 10/08/2013 05:17 AM, Sachin Kamat wrote:
> > Local variables used only in this file are made static.
> 

Conceptually they are still exported. So I think it's counterintuitive to
declare them static. Unless you expect namespace problems, I would rather
leave it as is.

Cheers,

Peter.

[PATCH 03/10] clk: tegra: Staticize local variables in clk-pll.c

[Stephen Warren]

On 10/10/2013 05:13 AM, Peter De Schrijver wrote:
> On Tue, Oct 08, 2013 at 06:09:24PM +0200, Stephen Warren wrote:
>> On 10/08/2013 05:17 AM, Sachin Kamat wrote:
>>> Local variables used only in this file are made static.
>>
> 
> Conceptually they are still exported. So I think it's counterintuitive to
> declare them static. Unless you expect namespace problems, I would rather
> leave it as is.

I forget exactly which symbols this patch changed, but presumably
they're only exported via pointers rather than by symbol name, and isn't
that exactly what static is for?

[PATCH 03/10] clk: tegra: Staticize local variables in clk-pll.c

[Peter De Schrijver]

On Thu, Oct 10, 2013 at 06:07:38PM +0200, Stephen Warren wrote:
> On 10/10/2013 05:13 AM, Peter De Schrijver wrote:
> > On Tue, Oct 08, 2013 at 06:09:24PM +0200, Stephen Warren wrote:
> >> On 10/08/2013 05:17 AM, Sachin Kamat wrote:
> >>> Local variables used only in this file are made static.
> >>
> > 
> > Conceptually they are still exported. So I think it's counterintuitive to
> > declare them static. Unless you expect namespace problems, I would rather
> > leave it as is.
> 
> I forget exactly which symbols this patch changed, but presumably
> they're only exported via pointers rather than by symbol name, and isn't
> that exactly what static is for?

They are indeed exported using a pointer. depends on how you look at it I
guess, but I see static as 'local to this file only' which isn't really
true if you hand out pointers to others.

Cheers,

Peter.

[PATCH 03/10] clk: tegra: Staticize local variables in clk-pll.c

[Stephen Warren]

On 10/14/2013 02:15 AM, Peter De Schrijver wrote:
> On Thu, Oct 10, 2013 at 06:07:38PM +0200, Stephen Warren wrote:
>> On 10/10/2013 05:13 AM, Peter De Schrijver wrote:
>>> On Tue, Oct 08, 2013 at 06:09:24PM +0200, Stephen Warren wrote:
>>>> On 10/08/2013 05:17 AM, Sachin Kamat wrote:
>>>>> Local variables used only in this file are made static.
>>>>
>>>
>>> Conceptually they are still exported. So I think it's counterintuitive to
>>> declare them static. Unless you expect namespace problems, I would rather
>>> leave it as is.
>>
>> I forget exactly which symbols this patch changed, but presumably
>> they're only exported via pointers rather than by symbol name, and isn't
>> that exactly what static is for?
> 
> They are indeed exported using a pointer. depends on how you look at it I
> guess, but I see static as 'local to this file only' which isn't really
> true if you hand out pointers to others.

Yes, static specifically means "the symbol name is local to this file".
It says nothing about the data behind the symbol name.

[PATCH 03/10] clk: tegra: Staticize local variables in clk-pll.c

[Peter De Schrijver]

On Mon, Oct 14, 2013 at 06:35:58PM +0200, Stephen Warren wrote:
> On 10/14/2013 02:15 AM, Peter De Schrijver wrote:
> > On Thu, Oct 10, 2013 at 06:07:38PM +0200, Stephen Warren wrote:
> >> On 10/10/2013 05:13 AM, Peter De Schrijver wrote:
> >>> On Tue, Oct 08, 2013 at 06:09:24PM +0200, Stephen Warren wrote:
> >>>> On 10/08/2013 05:17 AM, Sachin Kamat wrote:
> >>>>> Local variables used only in this file are made static.
> >>>>
> >>>
> >>> Conceptually they are still exported. So I think it's counterintuitive to
> >>> declare them static. Unless you expect namespace problems, I would rather
> >>> leave it as is.
> >>
> >> I forget exactly which symbols this patch changed, but presumably
> >> they're only exported via pointers rather than by symbol name, and isn't
> >> that exactly what static is for?
> > 
> > They are indeed exported using a pointer. depends on how you look at it I
> > guess, but I see static as 'local to this file only' which isn't really
> > true if you hand out pointers to others.
> 
> Yes, static specifically means "the symbol name is local to this file".
> It says nothing about the data behind the symbol name.

I would still prefer the symbol visibility to have some relation with how
the data is used.

[PATCH 03/10] clk: tegra: Staticize local variables in clk-pll.c

[Stephen Warren]

On 10/15/2013 02:29 AM, Peter De Schrijver wrote:
> On Mon, Oct 14, 2013 at 06:35:58PM +0200, Stephen Warren wrote:
>> On 10/14/2013 02:15 AM, Peter De Schrijver wrote:
>>> On Thu, Oct 10, 2013 at 06:07:38PM +0200, Stephen Warren wrote:
>>>> On 10/10/2013 05:13 AM, Peter De Schrijver wrote:
>>>>> On Tue, Oct 08, 2013 at 06:09:24PM +0200, Stephen Warren wrote:
>>>>>> On 10/08/2013 05:17 AM, Sachin Kamat wrote:
>>>>>>> Local variables used only in this file are made static.
>>>>>>
>>>>>
>>>>> Conceptually they are still exported. So I think it's counterintuitive to
>>>>> declare them static. Unless you expect namespace problems, I would rather
>>>>> leave it as is.
>>>>
>>>> I forget exactly which symbols this patch changed, but presumably
>>>> they're only exported via pointers rather than by symbol name, and isn't
>>>> that exactly what static is for?
>>>
>>> They are indeed exported using a pointer. depends on how you look at it I
>>> guess, but I see static as 'local to this file only' which isn't really
>>> true if you hand out pointers to others.
>>
>> Yes, static specifically means "the symbol name is local to this file".
>> It says nothing about the data behind the symbol name.
> 
> I would still prefer the symbol visibility to have some relation with how
> the data is used.

No, if the *symbol* is not used, it should be static. There's absolutely
zero benefit from having a visible symbol if it isn't used.

[PATCH 01/10] clk: bcm2835: Remove duplicate inclusion of clk-provider.h

[Sachin Kamat]

Mike,

On 13 September 2013 14:53, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> clk-provider.h was included twice.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> ---
>  drivers/clk/clk-bcm2835.c |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/clk/clk-bcm2835.c b/drivers/clk/clk-bcm2835.c
> index 5fb4ff5..676077d 100644
> --- a/drivers/clk/clk-bcm2835.c
> +++ b/drivers/clk/clk-bcm2835.c
> @@ -20,7 +20,6 @@
>  #include <linux/clk-provider.h>
>  #include <linux/clkdev.h>
>  #include <linux/clk/bcm2835.h>
> -#include <linux/clk-provider.h>
>  #include <linux/of.h>
>
>  static const struct of_device_id clk_match[] __initconst = {
> --
> 1.7.9.5
>

This series is pending since a long time. Can you please look into it?


-- 
With warm regards,
Sachin

[PATCH 03/10] clk: tegra: Staticize local variables in clk-pll.c

[Mike Turquette]

Quoting Sachin Kamat (2013-10-08 04:17:41)
> Local variables used only in this file are made static.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Stephen Warren <swarren@nvidia.com>

I updated this patch to staticize tegra_clk_pllxc_ops after taking
Peter's Tegra pull request. Refreshed patch has been applied to clk-next
and a copy is found below. Let me know if you have any comments.

Regards,
Mike



From: Sachin Kamat <sachin.kamat@linaro.org>
Date: Tue, 8 Oct 2013 16:47:41 +0530
Subject: [PATCH] clk: tegra: Staticize local variables in clk-pll.c

Local variables used only in this file are made static.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Mike Turquette <mturquette@linaro.org>
[mturquette at linaro.org: staticize struct clk_ops tegra_clk_pllxc_ops]
---
 drivers/clk/tegra/clk-pll.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/clk/tegra/clk-pll.c b/drivers/clk/tegra/clk-pll.c
index 2dd4322..0d20241 100644
--- a/drivers/clk/tegra/clk-pll.c
+++ b/drivers/clk/tegra/clk-pll.c
@@ -1433,7 +1433,7 @@ struct clk *tegra_clk_register_plle(const char *name, const char *parent_name,
 }
 
 #if defined(CONFIG_ARCH_TEGRA_114_SOC) || defined(CONFIG_ARCH_TEGRA_124_SOC)
-const struct clk_ops tegra_clk_pllxc_ops = {
+static const struct clk_ops tegra_clk_pllxc_ops = {
 	.is_enabled = clk_pll_is_enabled,
 	.enable = clk_pll_iddq_enable,
 	.disable = clk_pll_iddq_disable,
@@ -1442,7 +1442,7 @@ const struct clk_ops tegra_clk_pllxc_ops = {
 	.set_rate = clk_pllxc_set_rate,
 };
 
-const struct clk_ops tegra_clk_pllm_ops = {
+static const struct clk_ops tegra_clk_pllm_ops = {
 	.is_enabled = clk_pll_is_enabled,
 	.enable = clk_pll_iddq_enable,
 	.disable = clk_pll_iddq_disable,
@@ -1451,7 +1451,7 @@ const struct clk_ops tegra_clk_pllm_ops = {
 	.set_rate = clk_pllm_set_rate,
 };
 
-const struct clk_ops tegra_clk_pllc_ops = {
+static const struct clk_ops tegra_clk_pllc_ops = {
 	.is_enabled = clk_pll_is_enabled,
 	.enable = clk_pllc_enable,
 	.disable = clk_pllc_disable,
@@ -1460,7 +1460,7 @@ const struct clk_ops tegra_clk_pllc_ops = {
 	.set_rate = clk_pllc_set_rate,
 };
 
-const struct clk_ops tegra_clk_pllre_ops = {
+static const struct clk_ops tegra_clk_pllre_ops = {
 	.is_enabled = clk_pll_is_enabled,
 	.enable = clk_pll_iddq_enable,
 	.disable = clk_pll_iddq_disable,
@@ -1469,7 +1469,7 @@ const struct clk_ops tegra_clk_pllre_ops = {
 	.set_rate = clk_pllre_set_rate,
 };
 
-const struct clk_ops tegra_clk_plle_tegra114_ops = {
+static const struct clk_ops tegra_clk_plle_tegra114_ops = {
 	.is_enabled =  clk_pll_is_enabled,
 	.enable = clk_plle_tegra114_enable,
 	.disable = clk_plle_tegra114_disable,
@@ -1731,7 +1731,7 @@ struct clk *tegra_clk_register_plle_tegra114(const char *name,
 #endif
 
 #ifdef CONFIG_ARCH_TEGRA_124_SOC
-const struct clk_ops tegra_clk_pllss_ops = {
+static const struct clk_ops tegra_clk_pllss_ops = {
 	.is_enabled = clk_pll_is_enabled,
 	.enable = clk_pll_iddq_enable,
 	.disable = clk_pll_iddq_disable,
-- 
1.8.3.2