* [PATCH] arm: mvebu: use the main timer as clock source from DT
@ 2013-09-18 15:53 Jean Pihet
2013-09-18 16:18 ` Jason Cooper
2013-09-18 16:45 ` Thomas Petazzoni
0 siblings, 2 replies; 9+ messages in thread
From: Jean Pihet @ 2013-09-18 15:53 UTC (permalink / raw)
To: linux-arm-kernel
This commit:
573145f08c2b92c45498468afbbba909f6ce6135
clocksource: armada-370-xp: Use CLOCKSOURCE_OF_DECLARE
replaced a call to the driver's timer initialization by a call to
clocksource_of_init(). However, it failed to select CONFIG_CLKSRC_OF.
Fix this by selecting CONFIG_CLKSRC_OF for Armada370/XP machines.
Without this change the kernel is stuck at: 'Calibrating delay loop...'.
Signed-off-by: Jean Pihet <jean.pihet@linaro.org>
Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
---
arch/arm/mach-mvebu/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig
index 9eb63d7..25e6c00 100644
--- a/arch/arm/mach-mvebu/Kconfig
+++ b/arch/arm/mach-mvebu/Kconfig
@@ -26,6 +26,7 @@ config MACH_ARMADA_370_XP
select HAVE_SMP
select CACHE_L2X0
select CPU_PJ4B
+ select CLKSRC_OF
config MACH_ARMADA_370
bool "Marvell Armada 370 boards"
--
1.7.11.7
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] arm: mvebu: use the main timer as clock source from DT
2013-09-18 15:53 [PATCH] arm: mvebu: use the main timer as clock source from DT Jean Pihet
@ 2013-09-18 16:18 ` Jason Cooper
2013-09-18 16:45 ` Thomas Petazzoni
1 sibling, 0 replies; 9+ messages in thread
From: Jason Cooper @ 2013-09-18 16:18 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 18, 2013 at 05:53:44PM +0200, Jean Pihet wrote:
> This commit:
> 573145f08c2b92c45498468afbbba909f6ce6135
> clocksource: armada-370-xp: Use CLOCKSOURCE_OF_DECLARE
>
> replaced a call to the driver's timer initialization by a call to
> clocksource_of_init(). However, it failed to select CONFIG_CLKSRC_OF.
>
> Fix this by selecting CONFIG_CLKSRC_OF for Armada370/XP machines.
> Without this change the kernel is stuck at: 'Calibrating delay loop...'.
>
> Signed-off-by: Jean Pihet <jean.pihet@linaro.org>
> Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> ---
> arch/arm/mach-mvebu/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Applied to mvebu/fixes
thx,
Jason.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] arm: mvebu: use the main timer as clock source from DT
2013-09-18 15:53 [PATCH] arm: mvebu: use the main timer as clock source from DT Jean Pihet
2013-09-18 16:18 ` Jason Cooper
@ 2013-09-18 16:45 ` Thomas Petazzoni
2013-09-18 16:54 ` Jason Cooper
1 sibling, 1 reply; 9+ messages in thread
From: Thomas Petazzoni @ 2013-09-18 16:45 UTC (permalink / raw)
To: linux-arm-kernel
Dear Jean Pihet,
On Wed, 18 Sep 2013 17:53:44 +0200, Jean Pihet wrote:
> This commit:
> 573145f08c2b92c45498468afbbba909f6ce6135
> clocksource: armada-370-xp: Use CLOCKSOURCE_OF_DECLARE
>
> replaced a call to the driver's timer initialization by a call to
> clocksource_of_init(). However, it failed to select CONFIG_CLKSRC_OF.
>
> Fix this by selecting CONFIG_CLKSRC_OF for Armada370/XP machines.
> Without this change the kernel is stuck at: 'Calibrating delay
> loop...'.
>
> Signed-off-by: Jean Pihet <jean.pihet@linaro.org>
> Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> ---
> arch/arm/mach-mvebu/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig
> index 9eb63d7..25e6c00 100644
> --- a/arch/arm/mach-mvebu/Kconfig
> +++ b/arch/arm/mach-mvebu/Kconfig
> @@ -26,6 +26,7 @@ config MACH_ARMADA_370_XP
> select HAVE_SMP
> select CACHE_L2X0
> select CPU_PJ4B
> + select CLKSRC_OF
I disagree. This should go to drivers/clocksource/Kconfig, because it's
the clocksource driver that uses CLOCKSOURCE_OF_DECLARE. See what is
already done in drivers/clocksource/Kconfig for other drivers.
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] arm: mvebu: use the main timer as clock source from DT
2013-09-18 16:45 ` Thomas Petazzoni
@ 2013-09-18 16:54 ` Jason Cooper
2013-09-18 18:52 ` Jean Pihet
0 siblings, 1 reply; 9+ messages in thread
From: Jason Cooper @ 2013-09-18 16:54 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 18, 2013 at 06:45:09PM +0200, Thomas Petazzoni wrote:
> Dear Jean Pihet,
>
> On Wed, 18 Sep 2013 17:53:44 +0200, Jean Pihet wrote:
> > This commit:
> > 573145f08c2b92c45498468afbbba909f6ce6135
> > clocksource: armada-370-xp: Use CLOCKSOURCE_OF_DECLARE
> >
> > replaced a call to the driver's timer initialization by a call to
> > clocksource_of_init(). However, it failed to select CONFIG_CLKSRC_OF.
> >
> > Fix this by selecting CONFIG_CLKSRC_OF for Armada370/XP machines.
> > Without this change the kernel is stuck at: 'Calibrating delay
> > loop...'.
> >
> > Signed-off-by: Jean Pihet <jean.pihet@linaro.org>
> > Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> > ---
> > arch/arm/mach-mvebu/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig
> > index 9eb63d7..25e6c00 100644
> > --- a/arch/arm/mach-mvebu/Kconfig
> > +++ b/arch/arm/mach-mvebu/Kconfig
> > @@ -26,6 +26,7 @@ config MACH_ARMADA_370_XP
> > select HAVE_SMP
> > select CACHE_L2X0
> > select CPU_PJ4B
> > + select CLKSRC_OF
>
> I disagree. This should go to drivers/clocksource/Kconfig, because it's
> the clocksource driver that uses CLOCKSOURCE_OF_DECLARE. See what is
> already done in drivers/clocksource/Kconfig for other drivers.
Ack. I missed the 'select ARMADA_370_XP_TIMER' for this block since it
was outside the context.
Jean, please fix this up and resubmit to Daniel Lezcano.
I'll drop this version from my tree.
thx,
Jason.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] arm: mvebu: use the main timer as clock source from DT
2013-09-18 16:54 ` Jason Cooper
@ 2013-09-18 18:52 ` Jean Pihet
0 siblings, 0 replies; 9+ messages in thread
From: Jean Pihet @ 2013-09-18 18:52 UTC (permalink / raw)
To: linux-arm-kernel
Hi Jason, Thomas,
On 18 September 2013 18:54, Jason Cooper <jason@lakedaemon.net> wrote:
> On Wed, Sep 18, 2013 at 06:45:09PM +0200, Thomas Petazzoni wrote:
>> Dear Jean Pihet,
>>
>> On Wed, 18 Sep 2013 17:53:44 +0200, Jean Pihet wrote:
>> > This commit:
>> > 573145f08c2b92c45498468afbbba909f6ce6135
>> > clocksource: armada-370-xp: Use CLOCKSOURCE_OF_DECLARE
>> >
>> > replaced a call to the driver's timer initialization by a call to
>> > clocksource_of_init(). However, it failed to select CONFIG_CLKSRC_OF.
>> >
>> > Fix this by selecting CONFIG_CLKSRC_OF for Armada370/XP machines.
>> > Without this change the kernel is stuck at: 'Calibrating delay
>> > loop...'.
>> >
>> > Signed-off-by: Jean Pihet <jean.pihet@linaro.org>
>> > Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
>> > ---
>> > arch/arm/mach-mvebu/Kconfig | 1 +
>> > 1 file changed, 1 insertion(+)
>> >
>> > diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig
>> > index 9eb63d7..25e6c00 100644
>> > --- a/arch/arm/mach-mvebu/Kconfig
>> > +++ b/arch/arm/mach-mvebu/Kconfig
>> > @@ -26,6 +26,7 @@ config MACH_ARMADA_370_XP
>> > select HAVE_SMP
>> > select CACHE_L2X0
>> > select CPU_PJ4B
>> > + select CLKSRC_OF
>>
>> I disagree. This should go to drivers/clocksource/Kconfig, because it's
>> the clocksource driver that uses CLOCKSOURCE_OF_DECLARE. See what is
>> already done in drivers/clocksource/Kconfig for other drivers.
>
> Ack. I missed the 'select ARMADA_370_XP_TIMER' for this block since it
> was outside the context.
I agree. I just did like the other platforms in arch/arm are doing
which is obviously wrong.
> Jean, please fix this up and resubmit to Daniel Lezcano.
Just re-submitted the new version.
>
> I'll drop this version from my tree.
Ok, thx. Sorry for the extra handling.
>
> thx,
>
> Jason.
Thx,
Jean
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] arm: mvebu: use the main timer as clock source from DT
@ 2013-09-18 18:49 Jean Pihet
2013-09-18 18:56 ` Jason Cooper
0 siblings, 1 reply; 9+ messages in thread
From: Jean Pihet @ 2013-09-18 18:49 UTC (permalink / raw)
To: linux-arm-kernel
This commit:
573145f08c2b92c45498468afbbba909f6ce6135
clocksource: armada-370-xp: Use CLOCKSOURCE_OF_DECLARE
replaced a call to the driver's timer initialization by a call to
clocksource_of_init(). However, it failed to select CONFIG_CLKSRC_OF.
Fix this by selecting CONFIG_CLKSRC_OF for Armada370/XP machines.
Without this change the kernel is stuck at: 'Calibrating delay loop...'.
Signed-off-by: Jean Pihet <jean.pihet@linaro.org>
Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
---
drivers/clocksource/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 41c6946..971d796 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -26,6 +26,7 @@ config DW_APB_TIMER_OF
config ARMADA_370_XP_TIMER
bool
+ select CLKSRC_OF
config ORION_TIMER
select CLKSRC_OF
--
1.7.11.7
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] arm: mvebu: use the main timer as clock source from DT
2013-09-18 18:49 Jean Pihet
@ 2013-09-18 18:56 ` Jason Cooper
2013-09-25 10:39 ` Ezequiel Garcia
0 siblings, 1 reply; 9+ messages in thread
From: Jason Cooper @ 2013-09-18 18:56 UTC (permalink / raw)
To: linux-arm-kernel
Adding clocksource maintainers to the Cc: ...
On Wed, Sep 18, 2013 at 08:49:28PM +0200, Jean Pihet wrote:
> This commit:
> 573145f08c2b92c45498468afbbba909f6ce6135
> clocksource: armada-370-xp: Use CLOCKSOURCE_OF_DECLARE
>
> replaced a call to the driver's timer initialization by a call to
> clocksource_of_init(). However, it failed to select CONFIG_CLKSRC_OF.
>
> Fix this by selecting CONFIG_CLKSRC_OF for Armada370/XP machines.
> Without this change the kernel is stuck at: 'Calibrating delay loop...'.
>
> Signed-off-by: Jean Pihet <jean.pihet@linaro.org>
> Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> ---
> drivers/clocksource/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Jason Cooper <jason@lakedaemon.net>
Daniel, John, Thomas,
Can you queue this up for v3.12-rc2? It fixes a boot breakage.
thx,
Jason.
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 41c6946..971d796 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -26,6 +26,7 @@ config DW_APB_TIMER_OF
>
> config ARMADA_370_XP_TIMER
> bool
> + select CLKSRC_OF
>
> config ORION_TIMER
> select CLKSRC_OF
> --
> 1.7.11.7
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] arm: mvebu: use the main timer as clock source from DT
2013-09-18 18:56 ` Jason Cooper
@ 2013-09-25 10:39 ` Ezequiel Garcia
2013-09-25 23:06 ` Daniel Lezcano
0 siblings, 1 reply; 9+ messages in thread
From: Ezequiel Garcia @ 2013-09-25 10:39 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 18, 2013 at 02:56:11PM -0400, Jason Cooper wrote:
> Adding clocksource maintainers to the Cc: ...
>
> On Wed, Sep 18, 2013 at 08:49:28PM +0200, Jean Pihet wrote:
> > This commit:
> > 573145f08c2b92c45498468afbbba909f6ce6135
> > clocksource: armada-370-xp: Use CLOCKSOURCE_OF_DECLARE
> >
> > replaced a call to the driver's timer initialization by a call to
> > clocksource_of_init(). However, it failed to select CONFIG_CLKSRC_OF.
> >
> > Fix this by selecting CONFIG_CLKSRC_OF for Armada370/XP machines.
> > Without this change the kernel is stuck at: 'Calibrating delay loop...'.
> >
> > Signed-off-by: Jean Pihet <jean.pihet@linaro.org>
> > Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> > ---
> > drivers/clocksource/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
>
> Acked-by: Jason Cooper <jason@lakedaemon.net>
>
> Daniel, John, Thomas,
>
> Can you queue this up for v3.12-rc2? It fixes a boot breakage.
>
Is this already merged somewhere? Is there any chance we can push
it through *any* tree so it makes -rc3?
Thanks,
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] arm: mvebu: use the main timer as clock source from DT
2013-09-25 10:39 ` Ezequiel Garcia
@ 2013-09-25 23:06 ` Daniel Lezcano
0 siblings, 0 replies; 9+ messages in thread
From: Daniel Lezcano @ 2013-09-25 23:06 UTC (permalink / raw)
To: linux-arm-kernel
On 09/25/2013 12:39 PM, Ezequiel Garcia wrote:
> On Wed, Sep 18, 2013 at 02:56:11PM -0400, Jason Cooper wrote:
>> Adding clocksource maintainers to the Cc: ...
>>
>> On Wed, Sep 18, 2013 at 08:49:28PM +0200, Jean Pihet wrote:
>>> This commit:
>>> 573145f08c2b92c45498468afbbba909f6ce6135
>>> clocksource: armada-370-xp: Use CLOCKSOURCE_OF_DECLARE
>>>
>>> replaced a call to the driver's timer initialization by a call to
>>> clocksource_of_init(). However, it failed to select CONFIG_CLKSRC_OF.
>>>
>>> Fix this by selecting CONFIG_CLKSRC_OF for Armada370/XP machines.
>>> Without this change the kernel is stuck at: 'Calibrating delay loop...'.
>>>
>>> Signed-off-by: Jean Pihet <jean.pihet@linaro.org>
>>> Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
>>> ---
>>> drivers/clocksource/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>
>> Acked-by: Jason Cooper <jason@lakedaemon.net>
>>
>> Daniel, John, Thomas,
>>
>> Can you queue this up for v3.12-rc2? It fixes a boot breakage.
>>
>
> Is this already merged somewhere? Is there any chance we can push
> it through *any* tree so it makes -rc3?
Yes, I will take it in my tree.
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-09-25 23:06 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-18 15:53 [PATCH] arm: mvebu: use the main timer as clock source from DT Jean Pihet
2013-09-18 16:18 ` Jason Cooper
2013-09-18 16:45 ` Thomas Petazzoni
2013-09-18 16:54 ` Jason Cooper
2013-09-18 18:52 ` Jean Pihet
-- strict thread matches above, loose matches on Subject: below --
2013-09-18 18:49 Jean Pihet
2013-09-18 18:56 ` Jason Cooper
2013-09-25 10:39 ` Ezequiel Garcia
2013-09-25 23:06 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).