From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] clk: si570: Add a driver for SI570 oscillators
Date: Wed, 18 Sep 2013 16:02:41 -0700 [thread overview]
Message-ID: <1379545361.1787.87.camel@joe-AO722> (raw)
In-Reply-To: <1379544219-23579-1-git-send-email-soren.brinkmann@xilinx.com>
On Wed, 2013-09-18 at 15:43 -0700, Soren Brinkmann wrote:
> Add a driver for SILabs 570, 571, 598, 599 programmable oscillators.
> The devices generate low-jitter clock signals and are reprogrammable via
> an I2C interface.
[]
> v2:
[]
> - use 10000 as MIN and MAX value in usleep_range
[]
> diff --git a/drivers/clk/clk-si570.c b/drivers/clk/clk-si570.c
[]
> +static int si570_set_frequency(struct clk_si570 *data, unsigned long frequency)
> +{
[]
> + /* Applying a new frequency can take up to 10ms */
> + usleep_range(10000, 10000);
Generally it's nicer to have an actual range for usleep_range.
Is there a bit you could periodically poll to see
if the new frequency has been set or is stable so
that a 10ms delay isn't always used?
next prev parent reply other threads:[~2013-09-18 23:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 22:43 [PATCH v2] clk: si570: Add a driver for SI570 oscillators Soren Brinkmann
2013-09-18 22:43 ` Soren Brinkmann
2013-09-18 22:47 ` Sören Brinkmann
2013-09-18 23:02 ` Joe Perches [this message]
2013-09-18 23:09 ` Sören Brinkmann
2013-09-18 23:18 ` Joe Perches
2013-09-18 23:32 ` Sören Brinkmann
2013-09-19 0:23 ` Guenter Roeck
2013-09-19 14:48 ` Sören Brinkmann
2013-09-19 13:17 ` Guenter Roeck
2013-09-19 16:01 ` Sören Brinkmann
2013-09-19 16:44 ` Guenter Roeck
2013-09-19 20:59 ` Sören Brinkmann
2013-09-19 21:11 ` Guenter Roeck
2013-09-19 18:05 ` Mike Turquette
2013-09-19 18:40 ` Sören Brinkmann
2013-09-19 21:15 ` Guenter Roeck
2013-09-19 21:57 ` Sören Brinkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379545361.1787.87.camel@joe-AO722 \
--to=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox