linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: ux500: cpuidle: fix section mismatch
@ 2013-09-27 17:16 Daniel Lezcano
  2013-09-29 23:12 ` Linus Walleij
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Lezcano @ 2013-09-27 17:16 UTC (permalink / raw)
  To: linux-arm-kernel

The dbx500_cpuidle_probe is tagged as an __init section but the variable
dbx500_cpuidle_plat_driver is not.

The dbx500_cpuidle_probe could not be declared as __init because of macro
module_platform_driver builds the exit function, tags as __exit and this one
refers to the dbx500_cpuidle_plat_driver which is an __initdata.

That leads to a section mismatch.

Fix it by removing the __init tag for the probe function.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/cpuidle/cpuidle-ux500.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpuidle/cpuidle-ux500.c b/drivers/cpuidle/cpuidle-ux500.c
index e056465..5e35804 100644
--- a/drivers/cpuidle/cpuidle-ux500.c
+++ b/drivers/cpuidle/cpuidle-ux500.c
@@ -111,7 +111,7 @@ static struct cpuidle_driver ux500_idle_driver = {
 	.state_count = 2,
 };
 
-static int __init dbx500_cpuidle_probe(struct platform_device *pdev)
+static int dbx500_cpuidle_probe(struct platform_device *pdev)
 {
 	/* Configure wake up reasons */
 	prcmu_enable_wakeups(PRCMU_WAKEUP(ARM) | PRCMU_WAKEUP(RTC) |
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] ARM: ux500: cpuidle: fix section mismatch
  2013-09-27 17:16 [PATCH] ARM: ux500: cpuidle: fix section mismatch Daniel Lezcano
@ 2013-09-29 23:12 ` Linus Walleij
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2013-09-29 23:12 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Sep 27, 2013 at 7:16 PM, Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:

> The dbx500_cpuidle_probe is tagged as an __init section but the variable
> dbx500_cpuidle_plat_driver is not.
>
> The dbx500_cpuidle_probe could not be declared as __init because of macro
> module_platform_driver builds the exit function, tags as __exit and this one
> refers to the dbx500_cpuidle_plat_driver which is an __initdata.
>
> That leads to a section mismatch.
>
> Fix it by removing the __init tag for the probe function.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Sorry if I caused this and thanks for fixing it up!

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-09-29 23:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-27 17:16 [PATCH] ARM: ux500: cpuidle: fix section mismatch Daniel Lezcano
2013-09-29 23:12 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).