[PATCH 1/2] Documentation: Add device tree bindings for i.MX TVE

[PATCH 1/2] Documentation: Add device tree bindings for i.MX TVE

[Philipp Zabel]

This patch adds device tree binding documentation for i.MX Television Encoder
devices contained in i.MX51 and i.MX53 SoCs.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 .../devicetree/bindings/video/fsl,imx-tve.txt      | 23 ++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/video/fsl,imx-tve.txt

diff --git a/Documentation/devicetree/bindings/video/fsl,imx-tve.txt b/Documentation/devicetree/bindings/video/fsl,imx-tve.txt
new file mode 100644
index 0000000..77f92d7
--- /dev/null
+++ b/Documentation/devicetree/bindings/video/fsl,imx-tve.txt
@@ -0,0 +1,23 @@
+Freescale i.MX Television Encoder (TVE, TVEv2)
+
+The TVE encoders are contained in i.MX51 and i.MX53 SoCs and can drive analog
+output connectors such as VGA, Composite, or S-Video.
+
+Required properties:
+- compatible : "fsl,<soc>-tve", soc should be imx51 or imx53
+- reg : Should contain 1 register ranges(address and length)
+- interrupts : One interrupt of the fb dev
+- clocks, clock-names : Phandles to clocks called "tve" and "di_sel"
+  as documented in Documentation/devicetree/bindings/clock/clock-bindings.txt.
+  di_sel is a display interface input clock multiplexer, which can
+  be parented to the tve_di output clock provided by this device.
+
+Example:
+
+	tve: tve at 63ff0000 {
+		compatible = "fsl,imx53-tve";
+		reg = <0x63ff0000 0x1000>;
+		interrupts = <92>;
+		clocks = <&clks 69>, <&clks 116>;
+		clock-names = "tve", "di_sel";
+	};
-- 
1.8.4.rc3

[PATCH 2/2] ARM i.MX53: dts: Add TVE to i.MX53-QSB device tree

[Philipp Zabel]

This patch enables the TVE which is driving the VGA connector on i.MX53-QSB.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 arch/arm/boot/dts/imx53-qsb.dts | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx53-qsb.dts b/arch/arm/boot/dts/imx53-qsb.dts
index cf1aef7..3bbedf7 100644
--- a/arch/arm/boot/dts/imx53-qsb.dts
+++ b/arch/arm/boot/dts/imx53-qsb.dts
@@ -173,6 +173,15 @@ memgpu: /memreserve/ 0xb0000000 0x04000000;
 		};
 	};
 
+	tve {
+		pinctrl_vga_sync_1: vgasync-grp1 {
+			fsl,pins = <
+				/* VGA_HSYNC, VSYNC with max drive strength */
+				MX53_PAD_EIM_OE__IPU_DI1_PIN7 0xe6
+				MX53_PAD_EIM_RW__IPU_DI1_PIN8 0xe6
+			>;
+		};
+	};
 };
 
 &uart1 {
@@ -280,8 +289,8 @@ memgpu: /memreserve/ 0xb0000000 0x04000000;
 			};
 
 			ldo8_reg: ldo8 {
-				regulator-min-microvolt = <1200000>;
-				regulator-max-microvolt = <3600000>;
+				regulator-min-microvolt = <2750000>;
+				regulator-max-microvolt = <2750000>;
 				regulator-always-on;
 			};
 
@@ -318,6 +327,13 @@ memgpu: /memreserve/ 0xb0000000 0x04000000;
 	status = "okay";
 };
 
+&tve {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_vga_sync_1>;
+	dac-supply = <&ldo7_reg>;
+	status = "okay";
+};
+
 &usbh1 {
 	vbus-supply = <&reg_usb_vbus>;
 	phy_type = "utmi";
-- 
1.8.4.rc3

[PATCH 2/2] ARM i.MX53: dts: Add TVE to i.MX53-QSB device tree

[Shawn Guo]

On Thu, Sep 26, 2013 at 12:46:14PM +0200, Philipp Zabel wrote:
> This patch enables the TVE which is driving the VGA connector on i.MX53-QSB.
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
>  arch/arm/boot/dts/imx53-qsb.dts | 20 ++++++++++++++++++--
>  1 file changed, 18 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx53-qsb.dts b/arch/arm/boot/dts/imx53-qsb.dts
> index cf1aef7..3bbedf7 100644
> --- a/arch/arm/boot/dts/imx53-qsb.dts
> +++ b/arch/arm/boot/dts/imx53-qsb.dts
> @@ -173,6 +173,15 @@ memgpu: /memreserve/ 0xb0000000 0x04000000;
>  		};
>  	};
>  
> +	tve {
> +		pinctrl_vga_sync_1: vgasync-grp1 {
> +			fsl,pins = <
> +				/* VGA_HSYNC, VSYNC with max drive strength */
> +				MX53_PAD_EIM_OE__IPU_DI1_PIN7 0xe6
> +				MX53_PAD_EIM_RW__IPU_DI1_PIN8 0xe6
> +			>;
> +		};
> +	};
>  };
>  
>  &uart1 {
> @@ -280,8 +289,8 @@ memgpu: /memreserve/ 0xb0000000 0x04000000;
>  			};
>  
>  			ldo8_reg: ldo8 {
> -				regulator-min-microvolt = <1200000>;
> -				regulator-max-microvolt = <3600000>;
> +				regulator-min-microvolt = <2750000>;
> +				regulator-max-microvolt = <2750000>;

Why this change?

Shawn

>  				regulator-always-on;
>  			};
>  
> @@ -318,6 +327,13 @@ memgpu: /memreserve/ 0xb0000000 0x04000000;
>  	status = "okay";
>  };
>  
> +&tve {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_vga_sync_1>;
> +	dac-supply = <&ldo7_reg>;
> +	status = "okay";
> +};
> +
>  &usbh1 {
>  	vbus-supply = <&reg_usb_vbus>;
>  	phy_type = "utmi";
> -- 
> 1.8.4.rc3
> 

[PATCH 2/2] ARM i.MX53: dts: Add TVE to i.MX53-QSB device tree

[Philipp Zabel]

Am Freitag, den 27.09.2013, 09:16 +0800 schrieb Shawn Guo:
> On Thu, Sep 26, 2013 at 12:46:14PM +0200, Philipp Zabel wrote:
> > This patch enables the TVE which is driving the VGA connector on i.MX53-QSB.
> > 
> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > ---
> >  arch/arm/boot/dts/imx53-qsb.dts | 20 ++++++++++++++++++--
> >  1 file changed, 18 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/imx53-qsb.dts b/arch/arm/boot/dts/imx53-qsb.dts
> > index cf1aef7..3bbedf7 100644
> > --- a/arch/arm/boot/dts/imx53-qsb.dts
> > +++ b/arch/arm/boot/dts/imx53-qsb.dts
> > @@ -173,6 +173,15 @@ memgpu: /memreserve/ 0xb0000000 0x04000000;
> >  		};
> >  	};
> >  
> > +	tve {
> > +		pinctrl_vga_sync_1: vgasync-grp1 {
> > +			fsl,pins = <
> > +				/* VGA_HSYNC, VSYNC with max drive strength */
> > +				MX53_PAD_EIM_OE__IPU_DI1_PIN7 0xe6
> > +				MX53_PAD_EIM_RW__IPU_DI1_PIN8 0xe6
> > +			>;
> > +		};
> > +	};
> >  };
> >  
> >  &uart1 {
> > @@ -280,8 +289,8 @@ memgpu: /memreserve/ 0xb0000000 0x04000000;
> >  			};
> >  
> >  			ldo8_reg: ldo8 {
> > -				regulator-min-microvolt = <1200000>;
> > -				regulator-max-microvolt = <3600000>;
> > +				regulator-min-microvolt = <2750000>;
> > +				regulator-max-microvolt = <2750000>;
> 
> Why this change?

According to the reference manual, the TVDAC supply should be 2.75 V. If
there are no ill effects if this ldo is actually set to 3.6 V, this
change could be dropped.

regards
Philipp

[PATCH 2/2] ARM i.MX53: dts: Add TVE to i.MX53-QSB device tree

[Shawn Guo]

On Mon, Sep 30, 2013 at 04:40:08PM +0200, Philipp Zabel wrote:
> > > @@ -280,8 +289,8 @@ memgpu: /memreserve/ 0xb0000000 0x04000000;
> > >  			};
> > >  
> > >  			ldo8_reg: ldo8 {
> > > -				regulator-min-microvolt = <1200000>;
> > > -				regulator-max-microvolt = <3600000>;
> > > +				regulator-min-microvolt = <2750000>;
> > > +				regulator-max-microvolt = <2750000>;
> > 
> > Why this change?
> 
> According to the reference manual, the TVDAC supply should be 2.75 V. If
> there are no ill effects if this ldo is actually set to 3.6 V, this
> change could be dropped.

So you either add a comment in commit log for the change or drop the
change.

Shawn

[PATCH 2/2] ARM i.MX53: dts: Add TVE to i.MX53-QSB device tree

[Fabio Estevam]

Hi Philipp,

On Fri, Oct 4, 2013 at 10:58 PM, Shawn Guo <shawn.guo@linaro.org> wrote:
> On Mon, Sep 30, 2013 at 04:40:08PM +0200, Philipp Zabel wrote:
>> > > @@ -280,8 +289,8 @@ memgpu: /memreserve/ 0xb0000000 0x04000000;
>> > >                   };
>> > >
>> > >                   ldo8_reg: ldo8 {
>> > > -                         regulator-min-microvolt = <1200000>;
>> > > -                         regulator-max-microvolt = <3600000>;
>> > > +                         regulator-min-microvolt = <2750000>;
>> > > +                         regulator-max-microvolt = <2750000>;
>> >
>> > Why this change?
>>
>> According to the reference manual, the TVDAC supply should be 2.75 V. If
>> there are no ill effects if this ldo is actually set to 3.6 V, this
>> change could be dropped.
>
> So you either add a comment in commit log for the change or drop the
> change.

Do you plan to resubmit this patch?

Regards,

Fabio Estevam

[PATCH 1/2] Documentation: Add device tree bindings for i.MX TVE

[Shawn Guo]

On Thu, Sep 26, 2013 at 12:46:13PM +0200, Philipp Zabel wrote:
> This patch adds device tree binding documentation for i.MX Television Encoder
> devices contained in i.MX51 and i.MX53 SoCs.
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
>  .../devicetree/bindings/video/fsl,imx-tve.txt      | 23 ++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/video/fsl,imx-tve.txt

Shouldn't this be put into
Documentation/devicetree/bindings/staging/imx-drm/?

Shawn

> 
> diff --git a/Documentation/devicetree/bindings/video/fsl,imx-tve.txt b/Documentation/devicetree/bindings/video/fsl,imx-tve.txt
> new file mode 100644
> index 0000000..77f92d7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/video/fsl,imx-tve.txt
> @@ -0,0 +1,23 @@
> +Freescale i.MX Television Encoder (TVE, TVEv2)
> +
> +The TVE encoders are contained in i.MX51 and i.MX53 SoCs and can drive analog
> +output connectors such as VGA, Composite, or S-Video.
> +
> +Required properties:
> +- compatible : "fsl,<soc>-tve", soc should be imx51 or imx53
> +- reg : Should contain 1 register ranges(address and length)
> +- interrupts : One interrupt of the fb dev
> +- clocks, clock-names : Phandles to clocks called "tve" and "di_sel"
> +  as documented in Documentation/devicetree/bindings/clock/clock-bindings.txt.
> +  di_sel is a display interface input clock multiplexer, which can
> +  be parented to the tve_di output clock provided by this device.
> +
> +Example:
> +
> +	tve: tve at 63ff0000 {
> +		compatible = "fsl,imx53-tve";
> +		reg = <0x63ff0000 0x1000>;
> +		interrupts = <92>;
> +		clocks = <&clks 69>, <&clks 116>;
> +		clock-names = "tve", "di_sel";
> +	};
> -- 
> 1.8.4.rc3
> 

[PATCH 0/2] Add TVE to i.MX53-QSB device tree

[Philipp Zabel]

Hi,

these two patches add the necessary TVE device tree nodes to the
i.MX53 dtsi and to the i.MX53-QSB dts, including pin configuration
for HSYNC and VSYNC pins.

regards
Philipp

---
 arch/arm/boot/dts/imx53-qsb.dts |   25 +++++++++++++++++++++++--
 arch/arm/boot/dts/imx53.dtsi    |   10 ++++++++++
 2 files changed, 33 insertions(+), 2 deletions(-)

[PATCH 2/2] ARM i.MX53: dts: Add TVE to i.MX53-QSB device tree

[Philipp Zabel]

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 arch/arm/boot/dts/imx53-qsb.dts | 25 +++++++++++++++++++++++--
 1 file changed, 23 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx53-qsb.dts b/arch/arm/boot/dts/imx53-qsb.dts
index 8f0e9ae..9141d19 100644
--- a/arch/arm/boot/dts/imx53-qsb.dts
+++ b/arch/arm/boot/dts/imx53-qsb.dts
@@ -129,6 +129,15 @@
 		};
 	};
 
+	tve {
+		pinctrl_vga_sync_1: vgasync-grp1 {
+			fsl,pins = <
+				/* VGA_HSYNC, VSYNC with max drive strength */
+				614 0xe6	/* MX53_PAD_EIM_OE__IPU_DI1_PIN7 */
+				619 0xe6	/* MX53_PAD_EIM_RW__IPU_DI1_PIN8 */
+			>;
+		};
+	};
 };
 
 &uart1 {
@@ -235,8 +244,8 @@
 			};
 
 			ldo8_reg: ldo8 {
-				regulator-min-microvolt = <1200000>;
-				regulator-max-microvolt = <3600000>;
+				regulator-min-microvolt = <2750000>;
+				regulator-max-microvolt = <2750000>;
 				regulator-always-on;
 			};
 
@@ -268,3 +277,15 @@
 	phy-reset-gpios = <&gpio7 6 0>;
 	status = "okay";
 };
+
+&tve {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_vga_sync_1>;
+	ddc = <&i2c2>;
+	fsl,tve-mode = "vga";
+	status = "okay";
+	dac-supply = <&ldo7_reg>;
+
+	fsl,hsync-pin = <7>; /* IPU DI1 PIN7 via EIM_OE */
+	fsl,vsync-pin = <8>; /* IPU DI1 PIN8 via EIM_RW */
+};
-- 
1.8.2.rc2