* [PATCH] video: mxsfb: Add missing break
@ 2013-09-26 11:13 Marek Vasut
2013-09-26 12:34 ` Tomi Valkeinen
0 siblings, 1 reply; 7+ messages in thread
From: Marek Vasut @ 2013-09-26 11:13 UTC (permalink / raw)
To: linux-arm-kernel
Add missing break into the restore function.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <fabio.estevam@freescale.com>
Cc: Shawn Guo <shawn.guo@linaro.org>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
drivers/video/mxsfb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
index d250ed0..27197a8 100644
--- a/drivers/video/mxsfb.c
+++ b/drivers/video/mxsfb.c
@@ -620,6 +620,7 @@ static int mxsfb_restore_mode(struct mxsfb_info *host)
break;
case 3:
bits_per_pixel = 32;
+ break;
case 1:
default:
return -EINVAL;
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] video: mxsfb: Add missing break
2013-09-26 11:13 Marek Vasut
@ 2013-09-26 12:34 ` Tomi Valkeinen
2013-09-26 13:04 ` Marek Vasut
0 siblings, 1 reply; 7+ messages in thread
From: Tomi Valkeinen @ 2013-09-26 12:34 UTC (permalink / raw)
To: linux-arm-kernel
On 26/09/13 14:13, Marek Vasut wrote:
> Add missing break into the restore function.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
> drivers/video/mxsfb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
> index d250ed0..27197a8 100644
> --- a/drivers/video/mxsfb.c
> +++ b/drivers/video/mxsfb.c
> @@ -620,6 +620,7 @@ static int mxsfb_restore_mode(struct mxsfb_info *host)
> break;
> case 3:
> bits_per_pixel = 32;
> + break;
> case 1:
> default:
> return -EINVAL;
>
Thanks, queued for 3.12 fixes.
Tomi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130926/d3beecaa/attachment-0001.sig>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] video: mxsfb: Add missing break
2013-09-26 12:34 ` Tomi Valkeinen
@ 2013-09-26 13:04 ` Marek Vasut
2013-09-27 3:59 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 1 reply; 7+ messages in thread
From: Marek Vasut @ 2013-09-26 13:04 UTC (permalink / raw)
To: linux-arm-kernel
Hi Tomi,
> On 26/09/13 14:13, Marek Vasut wrote:
> > Add missing break into the restore function.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> > Cc: Shawn Guo <shawn.guo@linaro.org>
> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > ---
> >
> > drivers/video/mxsfb.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
> > index d250ed0..27197a8 100644
> > --- a/drivers/video/mxsfb.c
> > +++ b/drivers/video/mxsfb.c
> > @@ -620,6 +620,7 @@ static int mxsfb_restore_mode(struct mxsfb_info
> > *host)
> >
> > break;
> >
> > case 3:
> > bits_per_pixel = 32;
> >
> > + break;
> >
> > case 1:
> >
> > default:
> > return -EINVAL;
>
> Thanks, queued for 3.12 fixes.
Can you please also queue this for stable 3.10? It's broken there too.
Thanks!
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] video: mxsfb: Add missing break
2013-09-26 13:04 ` Marek Vasut
@ 2013-09-27 3:59 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 0 replies; 7+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2013-09-27 3:59 UTC (permalink / raw)
To: linux-arm-kernel
On 15:04 Thu 26 Sep , Marek Vasut wrote:
> Hi Tomi,
>
> > On 26/09/13 14:13, Marek Vasut wrote:
> > > Add missing break into the restore function.
> > >
> > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> > > Cc: Shawn Guo <shawn.guo@linaro.org>
> > > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > > ---
> > >
> > > drivers/video/mxsfb.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
> > > index d250ed0..27197a8 100644
> > > --- a/drivers/video/mxsfb.c
> > > +++ b/drivers/video/mxsfb.c
> > > @@ -620,6 +620,7 @@ static int mxsfb_restore_mode(struct mxsfb_info
> > > *host)
> > >
> > > break;
> > >
> > > case 3:
> > > bits_per_pixel = 32;
> > >
> > > + break;
> > >
> > > case 1:
> > >
> > > default:
> > > return -EINVAL;
> >
> > Thanks, queued for 3.12 fixes.
>
> Can you please also queue this for stable 3.10? It's broken there too.
this you have to do it by yourself by cc stable
Greg will take it not us
Best Regards,
J.
>
> Thanks!
>
> Best regards,
> Marek Vasut
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] video: mxsfb: Add missing break
@ 2013-10-01 4:22 Marek Vasut
2013-10-03 16:15 ` Luis Henriques
0 siblings, 1 reply; 7+ messages in thread
From: Marek Vasut @ 2013-10-01 4:22 UTC (permalink / raw)
To: linux-arm-kernel
Add missing break into the restore function.
Upstream commit: 6d0bb818041a02be682abadb3ba35ff608f7d60a
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <fabio.estevam@freescale.com>
Cc: Shawn Guo <shawn.guo@linaro.org>
Cc: stable at vger.kernel.org
---
drivers/video/mxsfb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
index 21223d4..75c5b4e 100644
--- a/drivers/video/mxsfb.c
+++ b/drivers/video/mxsfb.c
@@ -647,6 +647,7 @@ static int mxsfb_restore_mode(struct mxsfb_info *host)
break;
case 3:
bits_per_pixel = 32;
+ break;
case 1:
default:
return -EINVAL;
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] video: mxsfb: Add missing break
2013-10-01 4:22 [PATCH] video: mxsfb: Add missing break Marek Vasut
@ 2013-10-03 16:15 ` Luis Henriques
2013-10-03 16:26 ` Marek Vasut
0 siblings, 1 reply; 7+ messages in thread
From: Luis Henriques @ 2013-10-03 16:15 UTC (permalink / raw)
To: linux-arm-kernel
Marek Vasut <marex@denx.de> writes:
> Add missing break into the restore function.
>
> Upstream commit: 6d0bb818041a02be682abadb3ba35ff608f7d60a
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> Cc: stable at vger.kernel.org
>
> ---
> drivers/video/mxsfb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
> index 21223d4..75c5b4e 100644
> --- a/drivers/video/mxsfb.c
> +++ b/drivers/video/mxsfb.c
> @@ -647,6 +647,7 @@ static int mxsfb_restore_mode(struct mxsfb_info *host)
> break;
> case 3:
> bits_per_pixel = 32;
> + break;
> case 1:
> default:
> return -EINVAL;
Thanks, I believe this fix is applicable to all the stable kernels.
I'm queuing it for the 3.5 kernel.
Cheers,
--
Luis
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] video: mxsfb: Add missing break
2013-10-03 16:15 ` Luis Henriques
@ 2013-10-03 16:26 ` Marek Vasut
0 siblings, 0 replies; 7+ messages in thread
From: Marek Vasut @ 2013-10-03 16:26 UTC (permalink / raw)
To: linux-arm-kernel
Dear Luis Henriques,
> Marek Vasut <marex@denx.de> writes:
> > Add missing break into the restore function.
> >
> > Upstream commit: 6d0bb818041a02be682abadb3ba35ff608f7d60a
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Fabio Estevam <fabio.estevam@freescale.com>
> > Cc: Shawn Guo <shawn.guo@linaro.org>
> > Cc: stable at vger.kernel.org
> >
> > ---
> >
> > drivers/video/mxsfb.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
> > index 21223d4..75c5b4e 100644
> > --- a/drivers/video/mxsfb.c
> > +++ b/drivers/video/mxsfb.c
> > @@ -647,6 +647,7 @@ static int mxsfb_restore_mode(struct mxsfb_info
> > *host)
> >
> > break;
> >
> > case 3:
> > bits_per_pixel = 32;
> >
> > + break;
> >
> > case 1:
> >
> > default:
> > return -EINVAL;
>
> Thanks, I believe this fix is applicable to all the stable kernels.
> I'm queuing it for the 3.5 kernel.
Thanks!
btw. it'd be nice if you could push the kernel.ubuntu.com admins to fix their
git server ( https://bugs.launchpad.net/ubuntu/+source/git/+bug/1228148 ) ;-)
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-10-03 16:26 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-01 4:22 [PATCH] video: mxsfb: Add missing break Marek Vasut
2013-10-03 16:15 ` Luis Henriques
2013-10-03 16:26 ` Marek Vasut
-- strict thread matches above, loose matches on Subject: below --
2013-09-26 11:13 Marek Vasut
2013-09-26 12:34 ` Tomi Valkeinen
2013-09-26 13:04 ` Marek Vasut
2013-09-27 3:59 ` Jean-Christophe PLAGNIOL-VILLARD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).