linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: dinguyen@altera.com (Dinh Nguyen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: socfpga: Fix incorrect sdmmc clock name
Date: Tue, 1 Oct 2013 14:28:56 -0500	[thread overview]
Message-ID: <1380655736.13502.6.camel@linux-builds1> (raw)
In-Reply-To: <1379434985-25294-1-git-send-email-dinguyen@altera.com>

Hi,

Just wondering if I can solicit any comments for this patch? It's small,
so I'm not sure if I need at least a good Ack-by and put it in my tree
for a pull request, or ask to be applied to the arm-soc or Mike's clock
tree?

Thanks,
Dinh

On Tue, 2013-09-17 at 11:23 -0500, Dinh Nguyen wrote:
> From: Dinh Nguyen <dinguyen@altera.com>
> 
> The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk". Because of this,
> the SD driver was getting the incorrect clock value. This prevented the
> SD driver from initializing correctly.
> 
> Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> Cc: Mike Turquette <mturquette@linaro.org>
> CC: Arnd Bergmann <arnd@arndb.de>
> CC: Olof Johansson <olof@lixom.net>
> Cc: Pavel Machek <pavel@denx.de>
> Cc: linux-arm-kernel at lists.infradead.org
> ---
>  drivers/clk/socfpga/clk.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/socfpga/clk.c b/drivers/clk/socfpga/clk.c
> index 5bb848c..81dd31a 100644
> --- a/drivers/clk/socfpga/clk.c
> +++ b/drivers/clk/socfpga/clk.c
> @@ -49,7 +49,7 @@
>  #define SOCFPGA_L4_SP_CLK		"l4_sp_clk"
>  #define SOCFPGA_NAND_CLK		"nand_clk"
>  #define SOCFPGA_NAND_X_CLK		"nand_x_clk"
> -#define SOCFPGA_MMC_CLK			"mmc_clk"
> +#define SOCFPGA_MMC_CLK			"sdmmc_clk"
>  #define SOCFPGA_DB_CLK			"gpio_db_clk"
>  
>  #define div_mask(width)	((1 << (width)) - 1)

  parent reply	other threads:[~2013-10-01 19:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-17 16:23 [PATCH] arm: socfpga: Fix incorrect sdmmc clock name dinguyen at altera.com
2013-09-17 21:51 ` Pavel Machek
2013-10-01 19:28 ` Dinh Nguyen [this message]
2013-10-07 23:27   ` Mike Turquette
  -- strict thread matches above, loose matches on Subject: below --
2013-08-12 15:42 dinguyen at altera.com
2013-08-14  5:48 ` Olof Johansson
2013-08-14 14:57   ` Dinh Nguyen
2013-10-07 20:12     ` Mike Turquette
2013-10-07 20:37       ` Dinh Nguyen
2013-10-07 23:28         ` Mike Turquette
2013-10-07 23:43           ` Olof Johansson
2013-10-08  1:39             ` Mike Turquette
2013-10-08  2:40               ` Dinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1380655736.13502.6.camel@linux-builds1 \
    --to=dinguyen@altera.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).