* [PATCH] arm: socfpga: Fix incorrect sdmmc clock name
@ 2013-09-17 16:23 dinguyen at altera.com
2013-09-17 21:51 ` Pavel Machek
2013-10-01 19:28 ` Dinh Nguyen
0 siblings, 2 replies; 13+ messages in thread
From: dinguyen at altera.com @ 2013-09-17 16:23 UTC (permalink / raw)
To: linux-arm-kernel
From: Dinh Nguyen <dinguyen@altera.com>
The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk". Because of this,
the SD driver was getting the incorrect clock value. This prevented the
SD driver from initializing correctly.
Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
Cc: Mike Turquette <mturquette@linaro.org>
CC: Arnd Bergmann <arnd@arndb.de>
CC: Olof Johansson <olof@lixom.net>
Cc: Pavel Machek <pavel@denx.de>
Cc: linux-arm-kernel at lists.infradead.org
---
drivers/clk/socfpga/clk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/socfpga/clk.c b/drivers/clk/socfpga/clk.c
index 5bb848c..81dd31a 100644
--- a/drivers/clk/socfpga/clk.c
+++ b/drivers/clk/socfpga/clk.c
@@ -49,7 +49,7 @@
#define SOCFPGA_L4_SP_CLK "l4_sp_clk"
#define SOCFPGA_NAND_CLK "nand_clk"
#define SOCFPGA_NAND_X_CLK "nand_x_clk"
-#define SOCFPGA_MMC_CLK "mmc_clk"
+#define SOCFPGA_MMC_CLK "sdmmc_clk"
#define SOCFPGA_DB_CLK "gpio_db_clk"
#define div_mask(width) ((1 << (width)) - 1)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH] arm: socfpga: Fix incorrect sdmmc clock name
2013-09-17 16:23 [PATCH] arm: socfpga: Fix incorrect sdmmc clock name dinguyen at altera.com
@ 2013-09-17 21:51 ` Pavel Machek
2013-10-01 19:28 ` Dinh Nguyen
1 sibling, 0 replies; 13+ messages in thread
From: Pavel Machek @ 2013-09-17 21:51 UTC (permalink / raw)
To: linux-arm-kernel
On Tue 2013-09-17 11:23:05, dinguyen at altera.com wrote:
> From: Dinh Nguyen <dinguyen@altera.com>
>
> The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk". Because of this,
> the SD driver was getting the incorrect clock value. This prevented the
> SD driver from initializing correctly.
>
> Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> Cc: Mike Turquette <mturquette@linaro.org>
> CC: Arnd Bergmann <arnd@arndb.de>
> CC: Olof Johansson <olof@lixom.net>
Reviewed-by: Pavel Machek <pavel@denx.de>
Thanks!
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] arm: socfpga: Fix incorrect sdmmc clock name
2013-09-17 16:23 [PATCH] arm: socfpga: Fix incorrect sdmmc clock name dinguyen at altera.com
2013-09-17 21:51 ` Pavel Machek
@ 2013-10-01 19:28 ` Dinh Nguyen
2013-10-07 23:27 ` Mike Turquette
1 sibling, 1 reply; 13+ messages in thread
From: Dinh Nguyen @ 2013-10-01 19:28 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
Just wondering if I can solicit any comments for this patch? It's small,
so I'm not sure if I need at least a good Ack-by and put it in my tree
for a pull request, or ask to be applied to the arm-soc or Mike's clock
tree?
Thanks,
Dinh
On Tue, 2013-09-17 at 11:23 -0500, Dinh Nguyen wrote:
> From: Dinh Nguyen <dinguyen@altera.com>
>
> The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk". Because of this,
> the SD driver was getting the incorrect clock value. This prevented the
> SD driver from initializing correctly.
>
> Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> Cc: Mike Turquette <mturquette@linaro.org>
> CC: Arnd Bergmann <arnd@arndb.de>
> CC: Olof Johansson <olof@lixom.net>
> Cc: Pavel Machek <pavel@denx.de>
> Cc: linux-arm-kernel at lists.infradead.org
> ---
> drivers/clk/socfpga/clk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/socfpga/clk.c b/drivers/clk/socfpga/clk.c
> index 5bb848c..81dd31a 100644
> --- a/drivers/clk/socfpga/clk.c
> +++ b/drivers/clk/socfpga/clk.c
> @@ -49,7 +49,7 @@
> #define SOCFPGA_L4_SP_CLK "l4_sp_clk"
> #define SOCFPGA_NAND_CLK "nand_clk"
> #define SOCFPGA_NAND_X_CLK "nand_x_clk"
> -#define SOCFPGA_MMC_CLK "mmc_clk"
> +#define SOCFPGA_MMC_CLK "sdmmc_clk"
> #define SOCFPGA_DB_CLK "gpio_db_clk"
>
> #define div_mask(width) ((1 << (width)) - 1)
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] arm: socfpga: Fix incorrect sdmmc clock name
2013-10-01 19:28 ` Dinh Nguyen
@ 2013-10-07 23:27 ` Mike Turquette
0 siblings, 0 replies; 13+ messages in thread
From: Mike Turquette @ 2013-10-07 23:27 UTC (permalink / raw)
To: linux-arm-kernel
Quoting Dinh Nguyen (2013-10-01 12:28:56)
> Hi,
>
> Just wondering if I can solicit any comments for this patch? It's small,
> so I'm not sure if I need at least a good Ack-by and put it in my tree
> for a pull request, or ask to be applied to the arm-soc or Mike's clock
> tree?
I've taken this into clk-fixes for 3.12.
Regards,
Mike
>
> Thanks,
> Dinh
>
> On Tue, 2013-09-17 at 11:23 -0500, Dinh Nguyen wrote:
> > From: Dinh Nguyen <dinguyen@altera.com>
> >
> > The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk". Because of this,
> > the SD driver was getting the incorrect clock value. This prevented the
> > SD driver from initializing correctly.
> >
> > Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> > Cc: Mike Turquette <mturquette@linaro.org>
> > CC: Arnd Bergmann <arnd@arndb.de>
> > CC: Olof Johansson <olof@lixom.net>
> > Cc: Pavel Machek <pavel@denx.de>
> > Cc: linux-arm-kernel at lists.infradead.org
> > ---
> > drivers/clk/socfpga/clk.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/clk/socfpga/clk.c b/drivers/clk/socfpga/clk.c
> > index 5bb848c..81dd31a 100644
> > --- a/drivers/clk/socfpga/clk.c
> > +++ b/drivers/clk/socfpga/clk.c
> > @@ -49,7 +49,7 @@
> > #define SOCFPGA_L4_SP_CLK "l4_sp_clk"
> > #define SOCFPGA_NAND_CLK "nand_clk"
> > #define SOCFPGA_NAND_X_CLK "nand_x_clk"
> > -#define SOCFPGA_MMC_CLK "mmc_clk"
> > +#define SOCFPGA_MMC_CLK "sdmmc_clk"
> > #define SOCFPGA_DB_CLK "gpio_db_clk"
> >
> > #define div_mask(width) ((1 << (width)) - 1)
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] arm: socfpga: Fix incorrect sdmmc clock name
@ 2013-08-12 15:42 dinguyen at altera.com
2013-08-14 5:48 ` Olof Johansson
0 siblings, 1 reply; 13+ messages in thread
From: dinguyen at altera.com @ 2013-08-12 15:42 UTC (permalink / raw)
To: linux-arm-kernel
From: Dinh Nguyen <dinguyen@altera.com>
The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk".
Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
Cc: Mike Turquette <mturquette@linaro.org>
CC: Arnd Bergmann <arnd@arndb.de>
CC: Olof Johansson <olof@lixom.net>
Cc: Pavel Machek <pavel@denx.de>
Cc: linux-arm-kernel at lists.infradead.org
---
drivers/clk/socfpga/clk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/socfpga/clk.c b/drivers/clk/socfpga/clk.c
index 5bb848c..81dd31a 100644
--- a/drivers/clk/socfpga/clk.c
+++ b/drivers/clk/socfpga/clk.c
@@ -49,7 +49,7 @@
#define SOCFPGA_L4_SP_CLK "l4_sp_clk"
#define SOCFPGA_NAND_CLK "nand_clk"
#define SOCFPGA_NAND_X_CLK "nand_x_clk"
-#define SOCFPGA_MMC_CLK "mmc_clk"
+#define SOCFPGA_MMC_CLK "sdmmc_clk"
#define SOCFPGA_DB_CLK "gpio_db_clk"
#define div_mask(width) ((1 << (width)) - 1)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH] arm: socfpga: Fix incorrect sdmmc clock name
2013-08-12 15:42 dinguyen at altera.com
@ 2013-08-14 5:48 ` Olof Johansson
2013-08-14 14:57 ` Dinh Nguyen
0 siblings, 1 reply; 13+ messages in thread
From: Olof Johansson @ 2013-08-14 5:48 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Aug 12, 2013 at 10:42:14AM -0500, dinguyen at altera.com wrote:
> From: Dinh Nguyen <dinguyen@altera.com>
>
> The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk".
>
> Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> Cc: Mike Turquette <mturquette@linaro.org>
> CC: Arnd Bergmann <arnd@arndb.de>
> CC: Olof Johansson <olof@lixom.net>
> Cc: Pavel Machek <pavel@denx.de>
> Cc: linux-arm-kernel at lists.infradead.org
Hi Dinh,
Do you want this applied in fixes for 3.11? If so, can you give me a oneliner
on what the impact here is? mmc doesn't come up at all, or something more
subtle?
-Olof
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] arm: socfpga: Fix incorrect sdmmc clock name
2013-08-14 5:48 ` Olof Johansson
@ 2013-08-14 14:57 ` Dinh Nguyen
2013-10-07 20:12 ` Mike Turquette
0 siblings, 1 reply; 13+ messages in thread
From: Dinh Nguyen @ 2013-08-14 14:57 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 2013-08-13 at 22:48 -0700, Olof Johansson wrote:
> On Mon, Aug 12, 2013 at 10:42:14AM -0500, dinguyen at altera.com wrote:
> > From: Dinh Nguyen <dinguyen@altera.com>
> >
> > The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk".
> >
> > Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> > Cc: Mike Turquette <mturquette@linaro.org>
> > CC: Arnd Bergmann <arnd@arndb.de>
> > CC: Olof Johansson <olof@lixom.net>
> > Cc: Pavel Machek <pavel@denx.de>
> > Cc: linux-arm-kernel at lists.infradead.org
>
> Hi Dinh,
>
> Do you want this applied in fixes for 3.11? If so, can you give me a oneliner
> on what the impact here is? mmc doesn't come up at all, or something more
> subtle?
Hi Olof,
No, this is go into 3.12 as I am still working on the bindings for
SD/MMC.
The oneliner: "The SD/MMC driver was intermittently not coming up
because it was not able to get the correct clock."
Thanks,
Dinh
>
>
> -Olof
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] arm: socfpga: Fix incorrect sdmmc clock name
2013-08-14 14:57 ` Dinh Nguyen
@ 2013-10-07 20:12 ` Mike Turquette
2013-10-07 20:37 ` Dinh Nguyen
0 siblings, 1 reply; 13+ messages in thread
From: Mike Turquette @ 2013-10-07 20:12 UTC (permalink / raw)
To: linux-arm-kernel
Quoting Dinh Nguyen (2013-08-14 07:57:54)
> On Tue, 2013-08-13 at 22:48 -0700, Olof Johansson wrote:
> > On Mon, Aug 12, 2013 at 10:42:14AM -0500, dinguyen at altera.com wrote:
> > > From: Dinh Nguyen <dinguyen@altera.com>
> > >
> > > The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk".
> > >
> > > Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> > > Cc: Mike Turquette <mturquette@linaro.org>
> > > CC: Arnd Bergmann <arnd@arndb.de>
> > > CC: Olof Johansson <olof@lixom.net>
> > > Cc: Pavel Machek <pavel@denx.de>
> > > Cc: linux-arm-kernel at lists.infradead.org
> >
> > Hi Dinh,
> >
> > Do you want this applied in fixes for 3.11? If so, can you give me a oneliner
> > on what the impact here is? mmc doesn't come up at all, or something more
> > subtle?
>
> Hi Olof,
>
> No, this is go into 3.12 as I am still working on the bindings for
> SD/MMC.
>
> The oneliner: "The SD/MMC driver was intermittently not coming up
> because it was not able to get the correct clock."
Olof, did you take this? If not I'll put it into my next batch of fixes
for 3.12.
Regards,
Mike
>
> Thanks,
> Dinh
> >
> >
> > -Olof
> >
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] arm: socfpga: Fix incorrect sdmmc clock name
2013-10-07 20:12 ` Mike Turquette
@ 2013-10-07 20:37 ` Dinh Nguyen
2013-10-07 23:28 ` Mike Turquette
0 siblings, 1 reply; 13+ messages in thread
From: Dinh Nguyen @ 2013-10-07 20:37 UTC (permalink / raw)
To: linux-arm-kernel
Hi Mike,
On Mon, 2013-10-07 at 13:12 -0700, Mike Turquette wrote:
> Quoting Dinh Nguyen (2013-08-14 07:57:54)
> > On Tue, 2013-08-13 at 22:48 -0700, Olof Johansson wrote:
> > > On Mon, Aug 12, 2013 at 10:42:14AM -0500, dinguyen at altera.com wrote:
> > > > From: Dinh Nguyen <dinguyen@altera.com>
> > > >
> > > > The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk".
> > > >
> > > > Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> > > > Cc: Mike Turquette <mturquette@linaro.org>
> > > > CC: Arnd Bergmann <arnd@arndb.de>
> > > > CC: Olof Johansson <olof@lixom.net>
> > > > Cc: Pavel Machek <pavel@denx.de>
> > > > Cc: linux-arm-kernel at lists.infradead.org
> > >
> > > Hi Dinh,
> > >
> > > Do you want this applied in fixes for 3.11? If so, can you give me a oneliner
> > > on what the impact here is? mmc doesn't come up at all, or something more
> > > subtle?
> >
> > Hi Olof,
> >
> > No, this is go into 3.12 as I am still working on the bindings for
> > SD/MMC.
> >
> > The oneliner: "The SD/MMC driver was intermittently not coming up
> > because it was not able to get the correct clock."
>
> Olof, did you take this? If not I'll put it into my next batch of fixes
> for 3.12.
No, Olof did not get a chance to pick this up for 3.12. I resent the
patch with the updated commit message for 3.13:
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-September/198824.html
Thanks,
Dinh
>
> Regards,
> Mike
>
> >
> > Thanks,
> > Dinh
> > >
> > >
> > > -Olof
> > >
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] arm: socfpga: Fix incorrect sdmmc clock name
2013-10-07 20:37 ` Dinh Nguyen
@ 2013-10-07 23:28 ` Mike Turquette
2013-10-07 23:43 ` Olof Johansson
0 siblings, 1 reply; 13+ messages in thread
From: Mike Turquette @ 2013-10-07 23:28 UTC (permalink / raw)
To: linux-arm-kernel
Quoting Dinh Nguyen (2013-10-07 13:37:29)
> Hi Mike,
>
> On Mon, 2013-10-07 at 13:12 -0700, Mike Turquette wrote:
> > Quoting Dinh Nguyen (2013-08-14 07:57:54)
> > > On Tue, 2013-08-13 at 22:48 -0700, Olof Johansson wrote:
> > > > On Mon, Aug 12, 2013 at 10:42:14AM -0500, dinguyen at altera.com wrote:
> > > > > From: Dinh Nguyen <dinguyen@altera.com>
> > > > >
> > > > > The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk".
> > > > >
> > > > > Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> > > > > Cc: Mike Turquette <mturquette@linaro.org>
> > > > > CC: Arnd Bergmann <arnd@arndb.de>
> > > > > CC: Olof Johansson <olof@lixom.net>
> > > > > Cc: Pavel Machek <pavel@denx.de>
> > > > > Cc: linux-arm-kernel at lists.infradead.org
> > > >
> > > > Hi Dinh,
> > > >
> > > > Do you want this applied in fixes for 3.11? If so, can you give me a oneliner
> > > > on what the impact here is? mmc doesn't come up at all, or something more
> > > > subtle?
> > >
> > > Hi Olof,
> > >
> > > No, this is go into 3.12 as I am still working on the bindings for
> > > SD/MMC.
> > >
> > > The oneliner: "The SD/MMC driver was intermittently not coming up
> > > because it was not able to get the correct clock."
> >
> > Olof, did you take this? If not I'll put it into my next batch of fixes
> > for 3.12.
>
> No, Olof did not get a chance to pick this up for 3.12. I resent the
> patch with the updated commit message for 3.13:
>
> http://lists.infradead.org/pipermail/linux-arm-kernel/2013-September/198824.html
Thanks for the link. I've taken that version into clk-fixes for 3.12.
Regards,
Mike
>
> Thanks,
> Dinh
> >
> > Regards,
> > Mike
> >
> > >
> > > Thanks,
> > > Dinh
> > > >
> > > >
> > > > -Olof
> > > >
> >
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] arm: socfpga: Fix incorrect sdmmc clock name
2013-10-07 23:28 ` Mike Turquette
@ 2013-10-07 23:43 ` Olof Johansson
2013-10-08 1:39 ` Mike Turquette
0 siblings, 1 reply; 13+ messages in thread
From: Olof Johansson @ 2013-10-07 23:43 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Oct 7, 2013 at 4:28 PM, Mike Turquette <mturquette@linaro.org> wrote:
> Quoting Dinh Nguyen (2013-10-07 13:37:29)
>> Hi Mike,
>>
>> On Mon, 2013-10-07 at 13:12 -0700, Mike Turquette wrote:
>> > Quoting Dinh Nguyen (2013-08-14 07:57:54)
>> > > On Tue, 2013-08-13 at 22:48 -0700, Olof Johansson wrote:
>> > > > On Mon, Aug 12, 2013 at 10:42:14AM -0500, dinguyen at altera.com wrote:
>> > > > > From: Dinh Nguyen <dinguyen@altera.com>
>> > > > >
>> > > > > The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk".
>> > > > >
>> > > > > Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
>> > > > > Cc: Mike Turquette <mturquette@linaro.org>
>> > > > > CC: Arnd Bergmann <arnd@arndb.de>
>> > > > > CC: Olof Johansson <olof@lixom.net>
>> > > > > Cc: Pavel Machek <pavel@denx.de>
>> > > > > Cc: linux-arm-kernel at lists.infradead.org
>> > > >
>> > > > Hi Dinh,
>> > > >
>> > > > Do you want this applied in fixes for 3.11? If so, can you give me a oneliner
>> > > > on what the impact here is? mmc doesn't come up at all, or something more
>> > > > subtle?
>> > >
>> > > Hi Olof,
>> > >
>> > > No, this is go into 3.12 as I am still working on the bindings for
>> > > SD/MMC.
>> > >
>> > > The oneliner: "The SD/MMC driver was intermittently not coming up
>> > > because it was not able to get the correct clock."
>> >
>> > Olof, did you take this? If not I'll put it into my next batch of fixes
>> > for 3.12.
>>
>> No, Olof did not get a chance to pick this up for 3.12. I resent the
>> patch with the updated commit message for 3.13:
>>
>> http://lists.infradead.org/pipermail/linux-arm-kernel/2013-September/198824.html
>
> Thanks for the link. I've taken that version into clk-fixes for 3.12.
Thanks Mike, and sorry for dropping the ball Dinh. Next time feel free
to remind me if it happens. A week is the normal grace period. :)
-Olof
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] arm: socfpga: Fix incorrect sdmmc clock name
2013-10-07 23:43 ` Olof Johansson
@ 2013-10-08 1:39 ` Mike Turquette
2013-10-08 2:40 ` Dinh Nguyen
0 siblings, 1 reply; 13+ messages in thread
From: Mike Turquette @ 2013-10-08 1:39 UTC (permalink / raw)
To: linux-arm-kernel
Quoting Olof Johansson (2013-10-07 16:43:14)
> On Mon, Oct 7, 2013 at 4:28 PM, Mike Turquette <mturquette@linaro.org> wrote:
> > Quoting Dinh Nguyen (2013-10-07 13:37:29)
> >> Hi Mike,
> >>
> >> On Mon, 2013-10-07 at 13:12 -0700, Mike Turquette wrote:
> >> > Quoting Dinh Nguyen (2013-08-14 07:57:54)
> >> > > On Tue, 2013-08-13 at 22:48 -0700, Olof Johansson wrote:
> >> > > > On Mon, Aug 12, 2013 at 10:42:14AM -0500, dinguyen at altera.com wrote:
> >> > > > > From: Dinh Nguyen <dinguyen@altera.com>
> >> > > > >
> >> > > > > The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk".
> >> > > > >
> >> > > > > Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
> >> > > > > Cc: Mike Turquette <mturquette@linaro.org>
> >> > > > > CC: Arnd Bergmann <arnd@arndb.de>
> >> > > > > CC: Olof Johansson <olof@lixom.net>
> >> > > > > Cc: Pavel Machek <pavel@denx.de>
> >> > > > > Cc: linux-arm-kernel at lists.infradead.org
> >> > > >
> >> > > > Hi Dinh,
> >> > > >
> >> > > > Do you want this applied in fixes for 3.11? If so, can you give me a oneliner
> >> > > > on what the impact here is? mmc doesn't come up at all, or something more
> >> > > > subtle?
> >> > >
> >> > > Hi Olof,
> >> > >
> >> > > No, this is go into 3.12 as I am still working on the bindings for
> >> > > SD/MMC.
> >> > >
> >> > > The oneliner: "The SD/MMC driver was intermittently not coming up
> >> > > because it was not able to get the correct clock."
> >> >
> >> > Olof, did you take this? If not I'll put it into my next batch of fixes
> >> > for 3.12.
> >>
> >> No, Olof did not get a chance to pick this up for 3.12. I resent the
> >> patch with the updated commit message for 3.13:
> >>
> >> http://lists.infradead.org/pipermail/linux-arm-kernel/2013-September/198824.html
> >
> > Thanks for the link. I've taken that version into clk-fixes for 3.12.
>
>
> Thanks Mike, and sorry for dropping the ball Dinh. Next time feel free
> to remind me if it happens. A week is the normal grace period. :)
No problem ;-)
Dinh,
I changed your $SUBJECT line to:
"clk: socfpga: Fix incorrect sdmmc clock name"
Just a simple s/arm/clk/
Regards,
Mike
>
>
> -Olof
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH] arm: socfpga: Fix incorrect sdmmc clock name
2013-10-08 1:39 ` Mike Turquette
@ 2013-10-08 2:40 ` Dinh Nguyen
0 siblings, 0 replies; 13+ messages in thread
From: Dinh Nguyen @ 2013-10-08 2:40 UTC (permalink / raw)
To: linux-arm-kernel
On 10/7/13 8:39 PM, Mike Turquette wrote:
> Quoting Olof Johansson (2013-10-07 16:43:14)
>> On Mon, Oct 7, 2013 at 4:28 PM, Mike Turquette <mturquette@linaro.org> wrote:
>>> Quoting Dinh Nguyen (2013-10-07 13:37:29)
>>>> Hi Mike,
>>>>
>>>> On Mon, 2013-10-07 at 13:12 -0700, Mike Turquette wrote:
>>>>> Quoting Dinh Nguyen (2013-08-14 07:57:54)
>>>>>> On Tue, 2013-08-13 at 22:48 -0700, Olof Johansson wrote:
>>>>>>> On Mon, Aug 12, 2013 at 10:42:14AM -0500, dinguyen at altera.com wrote:
>>>>>>>> From: Dinh Nguyen <dinguyen@altera.com>
>>>>>>>>
>>>>>>>> The SD/MMC clock is named "sdmmc_clk", and NOT "mmc_clk".
>>>>>>>>
>>>>>>>> Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
>>>>>>>> Cc: Mike Turquette <mturquette@linaro.org>
>>>>>>>> CC: Arnd Bergmann <arnd@arndb.de>
>>>>>>>> CC: Olof Johansson <olof@lixom.net>
>>>>>>>> Cc: Pavel Machek <pavel@denx.de>
>>>>>>>> Cc: linux-arm-kernel at lists.infradead.org
>>>>>>> Hi Dinh,
>>>>>>>
>>>>>>> Do you want this applied in fixes for 3.11? If so, can you give me a oneliner
>>>>>>> on what the impact here is? mmc doesn't come up at all, or something more
>>>>>>> subtle?
>>>>>> Hi Olof,
>>>>>>
>>>>>> No, this is go into 3.12 as I am still working on the bindings for
>>>>>> SD/MMC.
>>>>>>
>>>>>> The oneliner: "The SD/MMC driver was intermittently not coming up
>>>>>> because it was not able to get the correct clock."
>>>>> Olof, did you take this? If not I'll put it into my next batch of fixes
>>>>> for 3.12.
>>>> No, Olof did not get a chance to pick this up for 3.12. I resent the
>>>> patch with the updated commit message for 3.13:
>>>>
>>>> http://lists.infradead.org/pipermail/linux-arm-kernel/2013-September/198824.html
>>> Thanks for the link. I've taken that version into clk-fixes for 3.12.
>>
>> Thanks Mike, and sorry for dropping the ball Dinh. Next time feel free
>> to remind me if it happens. A week is the normal grace period. :)
No problem Olof! The patches to enable SDMMC is still floating out there
so there wasn't a huge
hurry for 3.12.
Any chance you might take a look? I'll ping Chris Ball again tomorrow.
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-September/198824.html
Thanks...
> No problem ;-)
>
> Dinh,
>
> I changed your $SUBJECT line to:
>
> "clk: socfpga: Fix incorrect sdmmc clock name"
>
> Just a simple s/arm/clk/
Thanks Mike!
Dinh
>
> Regards,
> Mike
>
>>
>> -Olof
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2013-10-08 2:40 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-17 16:23 [PATCH] arm: socfpga: Fix incorrect sdmmc clock name dinguyen at altera.com
2013-09-17 21:51 ` Pavel Machek
2013-10-01 19:28 ` Dinh Nguyen
2013-10-07 23:27 ` Mike Turquette
-- strict thread matches above, loose matches on Subject: below --
2013-08-12 15:42 dinguyen at altera.com
2013-08-14 5:48 ` Olof Johansson
2013-08-14 14:57 ` Dinh Nguyen
2013-10-07 20:12 ` Mike Turquette
2013-10-07 20:37 ` Dinh Nguyen
2013-10-07 23:28 ` Mike Turquette
2013-10-07 23:43 ` Olof Johansson
2013-10-08 1:39 ` Mike Turquette
2013-10-08 2:40 ` Dinh Nguyen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).