* [PATCH] cpufreq: sa11x0: Fix build
@ 2013-10-06 10:45 Mark Brown
2013-10-07 2:54 ` Viresh Kumar
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2013-10-06 10:45 UTC (permalink / raw)
To: linux-arm-kernel
From: Mark Brown <broonie@linaro.org>
Commit 22c8b4f140 (cpufreq: sa11x0: Expose frequency table) added use of
struct cpufreq_frequency_table to mach-sa1100/generic.h but did not ensure
that the struct was declared, causing build failures on machines using that
header. Fix this.
Reported-by: Olof's autobuilder <build@lixom.net>
Signed-off-by: Mark Brown <broonie@linaro.org>
---
The relevant commit is in the cpufreq tree in -next.
arch/arm/mach-sa1100/generic.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-sa1100/generic.h b/arch/arm/mach-sa1100/generic.h
index f5214ce..eff1469 100644
--- a/arch/arm/mach-sa1100/generic.h
+++ b/arch/arm/mach-sa1100/generic.h
@@ -4,6 +4,7 @@
* Author: Nicolas Pitre
*/
#include <linux/reboot.h>
+#include <linux/cpufreq.h>
extern void sa1100_timer_init(void);
extern void __init sa1100_map_io(void);
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] cpufreq: sa11x0: Fix build
2013-10-06 10:45 [PATCH] cpufreq: sa11x0: Fix build Mark Brown
@ 2013-10-07 2:54 ` Viresh Kumar
2013-10-12 18:19 ` Olof Johansson
0 siblings, 1 reply; 4+ messages in thread
From: Viresh Kumar @ 2013-10-07 2:54 UTC (permalink / raw)
To: linux-arm-kernel
On 06/10/2013, Mark Brown <broonie@kernel.org> wrote:
> From: Mark Brown <broonie@linaro.org>
>
> Commit 22c8b4f140 (cpufreq: sa11x0: Expose frequency table) added use of
> struct cpufreq_frequency_table to mach-sa1100/generic.h but did not ensure
> that the struct was declared, causing build failures on machines using that
> header. Fix this.
>
> Reported-by: Olof's autobuilder <build@lixom.net>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
>
> The relevant commit is in the cpufreq tree in -next.
I have already sent relevant fix to Rafael for this, which
looks similar to this.. And I am waiting for Rafael to merge
it with offending commit...
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] cpufreq: sa11x0: Fix build
2013-10-07 2:54 ` Viresh Kumar
@ 2013-10-12 18:19 ` Olof Johansson
2013-10-13 0:39 ` Viresh Kumar
0 siblings, 1 reply; 4+ messages in thread
From: Olof Johansson @ 2013-10-12 18:19 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Oct 6, 2013 at 7:54 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 06/10/2013, Mark Brown <broonie@kernel.org> wrote:
>> From: Mark Brown <broonie@linaro.org>
>>
>> Commit 22c8b4f140 (cpufreq: sa11x0: Expose frequency table) added use of
>> struct cpufreq_frequency_table to mach-sa1100/generic.h but did not ensure
>> that the struct was declared, causing build failures on machines using that
>> header. Fix this.
>>
>> Reported-by: Olof's autobuilder <build@lixom.net>
>> Signed-off-by: Mark Brown <broonie@linaro.org>
>> ---
>>
>> The relevant commit is in the cpufreq tree in -next.
>
> I have already sent relevant fix to Rafael for this, which
> looks similar to this.. And I am waiting for Rafael to merge
> it with offending commit...
Things are still broken (or broken again). Can we please see this
patch show up in next soon?
-Olof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-13 0:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-06 10:45 [PATCH] cpufreq: sa11x0: Fix build Mark Brown
2013-10-07 2:54 ` Viresh Kumar
2013-10-12 18:19 ` Olof Johansson
2013-10-13 0:39 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).