linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: mach-omap1: Fix omap1510_fpga_init_irq() implicit declarations.
@ 2013-10-08 10:29 Majunath Goudar
  2013-10-08 18:05 ` Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: Majunath Goudar @ 2013-10-08 10:29 UTC (permalink / raw)
  To: linux-arm-kernel

This patch adds a omap1510_fpga_init_irq() inline dummy implementations
in arch/arm/mach-omap1/common.h. Without this patch,build system can
lead to issues. This was discovered during randconfig testing,in which
other than CONFIG_ARCH_OMAP15XX was enabled the leading to the following
error:

CC      arch/arm/mach-omap1/board-innovator.o
arch/arm/mach-omap1/board-innovator.c: In function ?innovator_init?:
arch/arm/mach-omap1/board-innovator.c:377:3: error: implicit declaration of
function ?omap1510_fpga_init_irq? [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[1]: *** [arch/arm/mach-omap1/board-innovator.o] Error 1
make: *** [arch/arm/mach-omap1] Error 2

Signed-off-by: Manjunath Goudar <csmanjuvijay@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Russell King <linux@arm.linux.org.uk>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-kernel at vger.kernel.org
Cc: linux-omap at vger.kernel.org
---
 arch/arm/mach-omap1/common.h |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/mach-omap1/common.h b/arch/arm/mach-omap1/common.h
index abec019..732f8ee 100644
--- a/arch/arm/mach-omap1/common.h
+++ b/arch/arm/mach-omap1/common.h
@@ -46,6 +46,9 @@ static inline void omap7xx_map_io(void)
 void omap1510_fpga_init_irq(void);
 void omap15xx_map_io(void);
 #else
+static inline void omap1510_fpga_init_irq(void)
+{
+}
 static inline void omap15xx_map_io(void)
 {
 }
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] ARM: mach-omap1: Fix omap1510_fpga_init_irq() implicit declarations.
  2013-10-08 10:29 [PATCH] ARM: mach-omap1: Fix omap1510_fpga_init_irq() implicit declarations Majunath Goudar
@ 2013-10-08 18:05 ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2013-10-08 18:05 UTC (permalink / raw)
  To: linux-arm-kernel

* Majunath Goudar <csmanjuvijay@gmail.com> [131008 03:37]:
> This patch adds a omap1510_fpga_init_irq() inline dummy implementations
> in arch/arm/mach-omap1/common.h. Without this patch,build system can
> lead to issues. This was discovered during randconfig testing,in which
> other than CONFIG_ARCH_OMAP15XX was enabled the leading to the following
> error:
> 
> CC      arch/arm/mach-omap1/board-innovator.o
> arch/arm/mach-omap1/board-innovator.c: In function ?innovator_init?:
> arch/arm/mach-omap1/board-innovator.c:377:3: error: implicit declaration of
> function ?omap1510_fpga_init_irq? [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
> make[1]: *** [arch/arm/mach-omap1/board-innovator.o] Error 1
> make: *** [arch/arm/mach-omap1] Error 2

Thanks, I'll apply this into omap-for-v3.13/fixes-not-urgent
as it's been there for quite a while.

Regards,

Tony
 
> Signed-off-by: Manjunath Goudar <csmanjuvijay@gmail.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-kernel at vger.kernel.org
> Cc: linux-omap at vger.kernel.org
> ---
>  arch/arm/mach-omap1/common.h |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/mach-omap1/common.h b/arch/arm/mach-omap1/common.h
> index abec019..732f8ee 100644
> --- a/arch/arm/mach-omap1/common.h
> +++ b/arch/arm/mach-omap1/common.h
> @@ -46,6 +46,9 @@ static inline void omap7xx_map_io(void)
>  void omap1510_fpga_init_irq(void);
>  void omap15xx_map_io(void);
>  #else
> +static inline void omap1510_fpga_init_irq(void)
> +{
> +}
>  static inline void omap15xx_map_io(void)
>  {
>  }
> -- 
> 1.7.9.5
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-10-08 18:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-08 10:29 [PATCH] ARM: mach-omap1: Fix omap1510_fpga_init_irq() implicit declarations Majunath Goudar
2013-10-08 18:05 ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).