From: josephl@nvidia.com (Joseph Lo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] ARM: tegra: make tegra_resume can work with current and later chips
Date: Wed, 9 Oct 2013 16:23:22 +0800 [thread overview]
Message-ID: <1381307002.2200.3.camel@jlo-ubuntu-64.nvidia.com> (raw)
In-Reply-To: <1381288295.10638.23.camel@jlo-ubuntu-64.nvidia.com>
On Wed, 2013-10-09 at 11:11 +0800, Joseph Lo wrote:
> On Wed, 2013-10-09 at 01:00 +0800, Stephen Warren wrote:
> > On 10/08/2013 02:23 AM, Joseph Lo wrote:
> > > diff --git a/arch/arm/mach-tegra/reset-handler.S b/arch/arm/mach-tegra/reset-handler.S
> >
> > > not_ca9:
> > > + mov32 r9, 0xc0f
> > > + cmp r8, r9
> > > + bleq tegra_init_l2_for_a15
> >
> > That's checking whether the CPU type is a Cortex-A15, isn't it? The only
> > CPUs that exist NVIDIA SoCs are Cortex-A9 and Cortex-A15, so I don't see
> > why we need to check whether the CPU is a Cortex-A15, given this label
> > is jumped to only when the CPU isn't a Cortex-A9.
>
> Good catch. Will fix.
>
Ah! I just realize the Cortex-A9 will go through here as well. So I
still need to code to make sure only Cortex-A15 execute the function.
next prev parent reply other threads:[~2013-10-09 8:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 8:23 [PATCH 0/4] ARM: tegra: add CPU hot-plug and idle support for Tegra124 Joseph Lo
2013-10-08 8:23 ` [PATCH 1/4] clk: tegra124: add wait_for_reset and disable_clock for tegra_cpu_car_ops Joseph Lo
2013-10-08 16:51 ` Stephen Warren
2013-10-09 2:59 ` Joseph Lo
2013-10-08 8:23 ` [PATCH 2/4] ARM: tegra: CPU hotplug support for Tegra124 Joseph Lo
2013-10-08 8:23 ` [PATCH 3/4] ARM: tegra: make tegra_resume can work with current and later chips Joseph Lo
2013-10-08 17:00 ` Stephen Warren
2013-10-09 3:11 ` Joseph Lo
2013-10-09 8:23 ` Joseph Lo [this message]
2013-10-09 16:04 ` Stephen Warren
2013-10-08 8:23 ` [PATCH 4/4] ARM: tegra: enable CPU idle for Tegra124 Joseph Lo
2013-10-08 9:01 ` [PATCH 0/4] ARM: tegra: add CPU hot-plug and idle support " Joseph Lo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381307002.2200.3.camel@jlo-ubuntu-64.nvidia.com \
--to=josephl@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).