* [PATCH] cpufreq: fix false return check from "regulator_set_voltage"
@ 2013-10-09 15:13 Manish Badarkhe
2013-10-12 3:21 ` Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Manish Badarkhe @ 2013-10-09 15:13 UTC (permalink / raw)
To: linux-arm-kernel
Currently, code checks false return value from "regulator_set_voltage"
to show failure message. Modify the code to check proper return
value from "regulator_set_voltage".
Signed-off-by: Manish Badarkhe <badarkhe.manish@gmail.com>
---
Based on master branch of linux-mainline.
:100644 100644 0fac344... 1537f32... M drivers/cpufreq/exynos-cpufreq.c
drivers/cpufreq/exynos-cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c
index 0fac344..1537f32 100644
--- a/drivers/cpufreq/exynos-cpufreq.c
+++ b/drivers/cpufreq/exynos-cpufreq.c
@@ -141,7 +141,7 @@ post_notify:
if ((freqs.new < freqs.old) ||
((freqs.new > freqs.old) && safe_arm_volt)) {
/* down the voltage after frequency change */
- regulator_set_voltage(arm_regulator, arm_volt,
+ ret = regulator_set_voltage(arm_regulator, arm_volt,
arm_volt);
if (ret) {
pr_err("%s: failed to set cpu voltage to %d\n",
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] cpufreq: fix false return check from "regulator_set_voltage"
2013-10-09 15:13 [PATCH] cpufreq: fix false return check from "regulator_set_voltage" Manish Badarkhe
@ 2013-10-12 3:21 ` Viresh Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2013-10-12 3:21 UTC (permalink / raw)
To: linux-arm-kernel
On 09/10/2013, Manish Badarkhe <badarkhe.manish@gmail.com> wrote:
> Currently, code checks false return value from "regulator_set_voltage"
> to show failure message. Modify the code to check proper return
> value from "regulator_set_voltage".
>
> Signed-off-by: Manish Badarkhe <badarkhe.manish@gmail.com>
> ---
> Based on master branch of linux-mainline.
>
> :100644 100644 0fac344... 1537f32... M drivers/cpufreq/exynos-cpufreq.c
> drivers/cpufreq/exynos-cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/exynos-cpufreq.c
> b/drivers/cpufreq/exynos-cpufreq.c
> index 0fac344..1537f32 100644
> --- a/drivers/cpufreq/exynos-cpufreq.c
> +++ b/drivers/cpufreq/exynos-cpufreq.c
> @@ -141,7 +141,7 @@ post_notify:
> if ((freqs.new < freqs.old) ||
> ((freqs.new > freqs.old) && safe_arm_volt)) {
> /* down the voltage after frequency change */
> - regulator_set_voltage(arm_regulator, arm_volt,
> + ret = regulator_set_voltage(arm_regulator, arm_volt,
> arm_volt);
> if (ret) {
> pr_err("%s: failed to set cpu voltage to %d\n",
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-12 3:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-09 15:13 [PATCH] cpufreq: fix false return check from "regulator_set_voltage" Manish Badarkhe
2013-10-12 3:21 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).