From: a.motakis@virtualopensystems.com (Antonios Motakis)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: SMMU: return NULL on error in arm_smmu_iova_to_phys
Date: Fri, 11 Oct 2013 15:24:47 +0200 [thread overview]
Message-ID: <1381497887-14586-2-git-send-email-a.motakis@virtualopensystems.com> (raw)
In-Reply-To: <1381497887-14586-1-git-send-email-a.motakis@virtualopensystems.com>
The return value of arm_smmu_iova_to_phys is directly passed to the
user of the IOMMU API via iommu_iova_to_phys; however the ARM SMMU
driver returns -EINVAL on error, which is not consistent with the
rest of the drivers implementing the IOMMU API. VFIO also relies on
the call returning NULL when a page has not been mapped already.
Signed-off-by: Antonios Motakis <a.motakis@virtualopensystems.com>
---
drivers/iommu/arm-smmu.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
index 8b71332..fe81b20 100644
--- a/drivers/iommu/arm-smmu.c
+++ b/drivers/iommu/arm-smmu.c
@@ -1480,10 +1480,7 @@ static phys_addr_t arm_smmu_iova_to_phys(struct iommu_domain *domain,
err_unlock:
spin_unlock(&smmu_domain->lock);
- dev_warn(smmu->dev,
- "invalid (corrupt?) page tables detected for iova 0x%llx\n",
- (unsigned long long)iova);
- return -EINVAL;
+ return NULL;
}
static int arm_smmu_domain_has_cap(struct iommu_domain *domain,
--
1.8.1.2
next prev parent reply other threads:[~2013-10-11 13:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 13:24 [PATCH 1/2] ARM: SMMU: add devices attached to the SMMU to an IOMMU group Antonios Motakis
2013-10-11 13:24 ` Antonios Motakis [this message]
2013-10-14 12:48 ` [PATCH 2/2] ARM: SMMU: return NULL on error in arm_smmu_iova_to_phys Will Deacon
2013-10-14 15:17 ` Antonios Motakis
2013-10-14 17:09 ` Will Deacon
2013-11-07 18:58 ` Will Deacon
2013-10-14 12:48 ` [PATCH 1/2] ARM: SMMU: add devices attached to the SMMU to an IOMMU group Will Deacon
2013-10-14 15:13 ` Antonios Motakis
2013-10-14 17:07 ` Will Deacon
2013-10-18 10:29 ` Antonios Motakis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381497887-14586-2-git-send-email-a.motakis@virtualopensystems.com \
--to=a.motakis@virtualopensystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).