From: l.stach@pengutronix.de (Lucas Stach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/5] mmc: sdhci-esdhc-imx: eliminate enum imx_esdhc_type
Date: Tue, 15 Oct 2013 08:50:44 +0200 [thread overview]
Message-ID: <1381819844.4243.7.camel@weser.hi.pengutronix.de> (raw)
In-Reply-To: <1381739024-24924-1-git-send-email-shawn.guo@linaro.org>
Am Montag, den 14.10.2013, 16:23 +0800 schrieb Shawn Guo:
> When I was reviewing Dong's imx6sl standard tuning patches, I found that
> it's a little clumsy to use enum imx_esdhc_type for handling features
> and quirks on different esdhc variants. Instead, the approach used in
> fec driver (drivers/net/ethernet/freescale/fec_main.c) should be more
> scalable in the long run. It defines flags for all those features and
> quirks and creates a mapping between esdhc variant and the flags.
>
> Actually, sdhci-esdhc-imx driver already has one such flag, i.e.
> ESDHC_FLAG_MULTIBLK_NO_INT, but there is currently an unnecessary
> translation between the flag and imx_esdhc_type. The series creates
> another 3 flags and identify features/quirks using these flags and then
> eliminate enum imx_esdhc_type completely.
>
Other than the comment on patch 2 this series, with the addition of
patch 6/6 is
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> Shawn Guo (5):
> mmc: sdhci-esdhc-imx: add flag ESDHC_FLAG_NO_DMAS_BITS
> mmc: sdhci-esdhc-imx: add flag ESDHC_FLAG_ENGCM07207
> mmc: sdhci-esdhc-imx: add flag ESDHC_FLAG_USDHC
> mmc: sdhci-esdhc-imx: pdev->id_entry should be immutable
> mmc: sdhci-esdhc-imx: eliminate enum imx_esdhc_type
>
> drivers/mmc/host/sdhci-esdhc-imx.c | 108 +++++++++++++++---------------------
> 1 file changed, 45 insertions(+), 63 deletions(-)
>
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5076 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2013-10-15 6:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 8:23 [PATCH 0/5] mmc: sdhci-esdhc-imx: eliminate enum imx_esdhc_type Shawn Guo
2013-10-14 8:23 ` [PATCH 1/5] mmc: sdhci-esdhc-imx: add flag ESDHC_FLAG_NO_DMAS_BITS Shawn Guo
2013-10-14 8:23 ` [PATCH 2/5] mmc: sdhci-esdhc-imx: add flag ESDHC_FLAG_ENGCM07207 Shawn Guo
2013-10-15 6:49 ` Lucas Stach
2013-10-14 8:23 ` [PATCH 3/5] mmc: sdhci-esdhc-imx: add flag ESDHC_FLAG_USDHC Shawn Guo
2013-10-14 8:23 ` [PATCH 4/5] mmc: sdhci-esdhc-imx: pdev->id_entry should be immutable Shawn Guo
2013-10-14 8:23 ` [PATCH 5/5] mmc: sdhci-esdhc-imx: eliminate enum imx_esdhc_type Shawn Guo
2013-10-14 8:31 ` Lucas Stach
2013-10-14 13:27 ` Shawn Guo
2013-10-14 13:56 ` Shawn Guo
2013-10-14 8:44 ` Lothar Waßmann
2013-10-15 4:55 ` [PATCH 6/6] mmc: sdhci-esdhc-imx: create struct esdhc_soc_data Shawn Guo
2013-10-15 6:50 ` Lucas Stach [this message]
2013-10-15 7:36 ` [PATCH 0/5] mmc: sdhci-esdhc-imx: eliminate enum imx_esdhc_type Dong Aisheng
2013-10-15 8:54 ` Shawn Guo
2013-10-16 15:19 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381819844.4243.7.camel@weser.hi.pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).