linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: christoffer.dall@linaro.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/9] KVM: ARM: fix the size of TTBCR_{T0SZ,T1SZ} masks
Date: Tue, 15 Oct 2013 17:49:35 -0700	[thread overview]
Message-ID: <1381884577-24747-8-git-send-email-christoffer.dall@linaro.org> (raw)
In-Reply-To: <1381884577-24747-1-git-send-email-christoffer.dall@linaro.org>

From: Jonathan Austin <jonathan.austin@arm.com>

The T{0,1}SZ fields of TTBCR are 3 bits wide when using the long descriptor
format. Likewise, the T0SZ field of the HTCR is 3-bits. KVM currently
defines TTBCR_T{0,1}SZ as 3, not 7.

The T0SZ mask is used to calculate the value for the HTCR, both to pick out
TTBCR.T0SZ and mask off the equivalent field in the HTCR during
read-modify-write. The incorrect mask size causes the (UNKNOWN) reset value
of HTCR.T0SZ to leak in to the calculated HTCR value. Linux will hang when
initializing KVM if HTCR's reset value has bit 2 set (sometimes the case on
A7/TC2)

Fixing T0SZ allows A7 cores to boot and T1SZ is also fixed for completeness.

Signed-off-by: Jonathan Austin <jonathan.austin@arm.com>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
---
 arch/arm/include/asm/kvm_arm.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/include/asm/kvm_arm.h b/arch/arm/include/asm/kvm_arm.h
index 64e9696..d556f03 100644
--- a/arch/arm/include/asm/kvm_arm.h
+++ b/arch/arm/include/asm/kvm_arm.h
@@ -95,12 +95,12 @@
 #define TTBCR_IRGN1	(3 << 24)
 #define TTBCR_EPD1	(1 << 23)
 #define TTBCR_A1	(1 << 22)
-#define TTBCR_T1SZ	(3 << 16)
+#define TTBCR_T1SZ	(7 << 16)
 #define TTBCR_SH0	(3 << 12)
 #define TTBCR_ORGN0	(3 << 10)
 #define TTBCR_IRGN0	(3 << 8)
 #define TTBCR_EPD0	(1 << 7)
-#define TTBCR_T0SZ	3
+#define TTBCR_T0SZ	(7 << 0)
 #define HTCR_MASK	(TTBCR_T0SZ | TTBCR_IRGN0 | TTBCR_ORGN0 | TTBCR_SH0)
 
 /* Hyp System Trap Register */
-- 
1.7.10.4

  parent reply	other threads:[~2013-10-16  0:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-16  0:49 [GIT PULL] KVM/ARM Updates for kvm/next Christoffer Dall
2013-10-16  0:49 ` [PATCH 1/9] KVM: ARM: Fix typo in comments of inject_abt() Christoffer Dall
2013-10-16  0:49 ` [PATCH 2/9] ARM: KVM: Implement kvm_vcpu_preferred_target() function Christoffer Dall
2013-10-16  0:49 ` [PATCH 3/9] ARM64: " Christoffer Dall
2013-10-16  0:49 ` [PATCH 4/9] ARM/ARM64: KVM: Implement KVM_ARM_PREFERRED_TARGET ioctl Christoffer Dall
2013-10-16  0:49 ` [PATCH 5/9] KVM: Add documentation for " Christoffer Dall
2013-10-16  0:49 ` [PATCH 6/9] KVM: ARM: Fix calculation of virtual CPU ID Christoffer Dall
2013-10-16  0:49 ` Christoffer Dall [this message]
2013-10-16  0:49 ` [PATCH 8/9] KVM: ARM: Add support for Cortex-A7 Christoffer Dall
2013-10-16  0:49 ` [PATCH 9/9] KVM: ARM: Remove non-ASCII space characters Christoffer Dall
2013-10-16 12:38 ` [GIT PULL] KVM/ARM Updates for kvm/next Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1381884577-24747-8-git-send-email-christoffer.dall@linaro.org \
    --to=christoffer.dall@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).