From: tim.kryger@linaro.org (Tim Kryger)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH v2 6/6] mmc: sdhci-bcm-kona: Add basic use of clocks
Date: Wed, 16 Oct 2013 14:47:10 -0700 [thread overview]
Message-ID: <1381960030-1640-7-git-send-email-tim.kryger@linaro.org> (raw)
In-Reply-To: <1381960030-1640-1-git-send-email-tim.kryger@linaro.org>
Enable the external clock needed by the host controller during the
probe and disable it during the remove.
Signed-off-by: Tim Kryger <tim.kryger@linaro.org>
Reviewed-by: Markus Mayer <markus.mayer@linaro.org>
Reviewed-by: Matt Porter <matt.porter@linaro.org>
---
drivers/mmc/host/sdhci-bcm-kona.c | 30 ++++++++++++++++++++++++++++--
1 file changed, 28 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c
index 85472d3..91db099 100644
--- a/drivers/mmc/host/sdhci-bcm-kona.c
+++ b/drivers/mmc/host/sdhci-bcm-kona.c
@@ -54,6 +54,7 @@
struct sdhci_bcm_kona_dev {
struct mutex write_lock; /* protect back to back writes */
+ struct clk *external_clk;
};
@@ -252,11 +253,29 @@ static int sdhci_bcm_kona_probe(struct platform_device *pdev)
mmc_of_parse(host->mmc);
if (!host->mmc->f_max) {
- dev_err(&pdev->dev, "Missing max-freq for SDHCI cfg\n");
+ dev_err(dev, "Missing max-freq for SDHCI cfg\n");
ret = -ENXIO;
goto err_pltfm_free;
}
+ /* Get and enable the external clock */
+ kona_dev->external_clk = devm_clk_get(dev, NULL);
+ if (IS_ERR(kona_dev->external_clk)) {
+ dev_err(dev, "Failed to get external clock\n");
+ ret = PTR_ERR(kona_dev->external_clk);
+ goto err_pltfm_free;
+ }
+
+ if (clk_set_rate(kona_dev->external_clk, host->mmc->f_max) != 0) {
+ dev_err(dev, "Failed to set rate external clock\n");
+ goto err_pltfm_free;
+ }
+
+ if (clk_prepare_enable(kona_dev->external_clk) != 0) {
+ dev_err(dev, "Failed to enable external clock\n");
+ goto err_pltfm_free;
+ }
+
dev_dbg(dev, "non-removable=%c\n",
(host->mmc->caps & MMC_CAP_NONREMOVABLE) ? 'Y' : 'N');
dev_dbg(dev, "cd_gpio %c, wp_gpio %c\n",
@@ -271,7 +290,7 @@ static int sdhci_bcm_kona_probe(struct platform_device *pdev)
ret = sdhci_bcm_kona_sd_reset(host);
if (ret)
- goto err_pltfm_free;
+ goto err_clk_disable;
sdhci_bcm_kona_sd_init(host);
@@ -307,6 +326,9 @@ err_remove_host:
err_reset:
sdhci_bcm_kona_sd_reset(host);
+err_clk_disable:
+ clk_disable_unprepare(kona_dev->external_clk);
+
err_pltfm_free:
sdhci_pltfm_free(pdev);
@@ -317,6 +339,8 @@ err_pltfm_free:
static int __exit sdhci_bcm_kona_remove(struct platform_device *pdev)
{
struct sdhci_host *host = platform_get_drvdata(pdev);
+ struct sdhci_pltfm_host *pltfm_priv = sdhci_priv(host);
+ struct sdhci_bcm_kona_dev *kona_dev = sdhci_pltfm_priv(pltfm_priv);
int dead;
u32 scratch;
@@ -326,6 +350,8 @@ static int __exit sdhci_bcm_kona_remove(struct platform_device *pdev)
dead = 1;
sdhci_remove_host(host, dead);
+ clk_disable_unprepare(kona_dev->external_clk);
+
sdhci_free_host(host);
return 0;
--
1.8.0.1
next prev parent reply other threads:[~2013-10-16 21:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 21:47 [RESEND PATCH v2 0/6] Update Kona drivers to use clocks Tim Kryger
2013-10-16 21:47 ` [RESEND PATCH v2 1/6] ARM: dts: Declare clocks as fixed on bcm11351 Tim Kryger
2013-11-08 10:53 ` Daniel Lezcano
2013-11-08 19:42 ` Tim Kryger
2013-11-08 21:35 ` Christian Daudt
2013-10-16 21:47 ` [RESEND PATCH v2 2/6] ARM: dts: Specify clocks for UARTs " Tim Kryger
2013-10-17 5:41 ` Christian Daudt
2013-10-17 6:14 ` Sebastian Hesselbarth
2013-10-17 13:56 ` Mark Rutland
2013-10-21 18:56 ` Tim Kryger
2013-10-16 21:47 ` [RESEND PATCH v2 3/6] ARM: dts: Specify clocks for SDHCIs " Tim Kryger
2013-10-16 21:47 ` [RESEND PATCH v2 4/6] clocksource: kona: Add basic use of external clock Tim Kryger
2013-10-17 14:05 ` Mark Rutland
2013-10-21 21:07 ` Tim Kryger
2013-10-16 21:47 ` [RESEND PATCH v2 5/6] ARM: dts: Specify clocks for timer on bcm11351 Tim Kryger
2013-10-17 14:06 ` Mark Rutland
2013-10-18 20:25 ` Tim Kryger
2013-10-16 21:47 ` Tim Kryger [this message]
2013-10-17 14:13 ` [RESEND PATCH v2 6/6] mmc: sdhci-bcm-kona: Add basic use of clocks Mark Rutland
2013-10-18 13:22 ` Matt Porter
2013-10-21 23:13 ` Tim Kryger
2013-10-17 13:47 ` [RESEND PATCH v2 0/6] Update Kona drivers to use clocks Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381960030-1640-7-git-send-email-tim.kryger@linaro.org \
--to=tim.kryger@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).