linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: i.MX6q: fix the wrong parent of can_root clock
@ 2013-10-30 11:25 jiada_wang at mentor.com
  2013-10-31  7:38 ` Shawn Guo
  0 siblings, 1 reply; 5+ messages in thread
From: jiada_wang at mentor.com @ 2013-10-30 11:25 UTC (permalink / raw)
  To: linux-arm-kernel

From: Jiada Wang <jiada_wang@mentor.com>

instead of pll3_usb_otg the parent of can_root clock
should be pll3_60m.

Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
---
 arch/arm/mach-imx/clk-imx6q.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-imx/clk-imx6q.c b/arch/arm/mach-imx/clk-imx6q.c
index 9181a24..ef85ac4 100644
--- a/arch/arm/mach-imx/clk-imx6q.c
+++ b/arch/arm/mach-imx/clk-imx6q.c
@@ -428,7 +428,7 @@ static void __init imx6q_clocks_init(struct device_node *ccm_node)
 	clk[asrc_podf]        = imx_clk_divider("asrc_podf",        "asrc_pred",         base + 0x30, 9,  3);
 	clk[spdif_pred]       = imx_clk_divider("spdif_pred",       "spdif_sel",         base + 0x30, 25, 3);
 	clk[spdif_podf]       = imx_clk_divider("spdif_podf",       "spdif_pred",        base + 0x30, 22, 3);
-	clk[can_root]         = imx_clk_divider("can_root",         "pll3_usb_otg",      base + 0x20, 2,  6);
+	clk[can_root]         = imx_clk_divider("can_root",         "pll3_60m",          base + 0x20, 2,  6);
 	clk[ecspi_root]       = imx_clk_divider("ecspi_root",       "pll3_60m",          base + 0x38, 19, 6);
 	clk[gpu2d_core_podf]  = imx_clk_divider("gpu2d_core_podf",  "gpu2d_core_sel",    base + 0x18, 23, 3);
 	clk[gpu3d_core_podf]  = imx_clk_divider("gpu3d_core_podf",  "gpu3d_core_sel",    base + 0x18, 26, 3);
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH] ARM: i.MX6q: fix the wrong parent of can_root clock
  2013-10-30 11:25 [PATCH] ARM: i.MX6q: fix the wrong parent of can_root clock jiada_wang at mentor.com
@ 2013-10-31  7:38 ` Shawn Guo
  2013-11-25 16:44   ` Marc Kleine-Budde
  0 siblings, 1 reply; 5+ messages in thread
From: Shawn Guo @ 2013-10-31  7:38 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Oct 30, 2013 at 04:25:51AM -0700, jiada_wang at mentor.com wrote:
> From: Jiada Wang <jiada_wang@mentor.com>
> 
> instead of pll3_usb_otg the parent of can_root clock
> should be pll3_60m.
> 
> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] ARM: i.MX6q: fix the wrong parent of can_root clock
  2013-10-31  7:38 ` Shawn Guo
@ 2013-11-25 16:44   ` Marc Kleine-Budde
  2013-11-26  2:19     ` Shawn Guo
  0 siblings, 1 reply; 5+ messages in thread
From: Marc Kleine-Budde @ 2013-11-25 16:44 UTC (permalink / raw)
  To: linux-arm-kernel

On 10/31/2013 08:38 AM, Shawn Guo wrote:
> On Wed, Oct 30, 2013 at 04:25:51AM -0700, jiada_wang at mentor.com wrote:
>> From: Jiada Wang <jiada_wang@mentor.com>
>>
>> instead of pll3_usb_otg the parent of can_root clock
>> should be pll3_60m.
>>
>> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
> 
> Applied, thanks.

Can you put stable on Cc?

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 259 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131125/ff7cd857/attachment.sig>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] ARM: i.MX6q: fix the wrong parent of can_root clock
  2013-11-25 16:44   ` Marc Kleine-Budde
@ 2013-11-26  2:19     ` Shawn Guo
  2013-11-26  8:34       ` Marc Kleine-Budde
  0 siblings, 1 reply; 5+ messages in thread
From: Shawn Guo @ 2013-11-26  2:19 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Nov 25, 2013 at 05:44:31PM +0100, Marc Kleine-Budde wrote:
> On 10/31/2013 08:38 AM, Shawn Guo wrote:
> > On Wed, Oct 30, 2013 at 04:25:51AM -0700, jiada_wang at mentor.com wrote:
> >> From: Jiada Wang <jiada_wang@mentor.com>
> >>
> >> instead of pll3_usb_otg the parent of can_root clock
> >> should be pll3_60m.
> >>
> >> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
> > 
> > Applied, thanks.
> 
> Can you put stable on Cc?

Sorry, it already hits mainline.

I generally do not judge if a patch is suitable for stable tree, and
rely on patch sender to explicitly request by marking stable and the
prerequisite commits if any.

Shawn

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] ARM: i.MX6q: fix the wrong parent of can_root clock
  2013-11-26  2:19     ` Shawn Guo
@ 2013-11-26  8:34       ` Marc Kleine-Budde
  0 siblings, 0 replies; 5+ messages in thread
From: Marc Kleine-Budde @ 2013-11-26  8:34 UTC (permalink / raw)
  To: linux-arm-kernel

On 11/26/2013 03:19 AM, Shawn Guo wrote:
> On Mon, Nov 25, 2013 at 05:44:31PM +0100, Marc Kleine-Budde wrote:
>> On 10/31/2013 08:38 AM, Shawn Guo wrote:
>>> On Wed, Oct 30, 2013 at 04:25:51AM -0700, jiada_wang at mentor.com wrote:
>>>> From: Jiada Wang <jiada_wang@mentor.com>
>>>>
>>>> instead of pll3_usb_otg the parent of can_root clock
>>>> should be pll3_60m.
>>>>
>>>> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
>>>
>>> Applied, thanks.
>>
>> Can you put stable on Cc?
> 
> Sorry, it already hits mainline.

No problem, I'll write stable and Greg directly.

> I generally do not judge if a patch is suitable for stable tree, and
> rely on patch sender to explicitly request by marking stable and the
> prerequisite commits if any.

Together with the Flexcan clock (can: flexcan: use correct clock as base
for bit rate calculation) this fixes the CAN on imx6.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 259 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131126/5ba0f0f8/attachment.sig>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-11-26  8:34 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-30 11:25 [PATCH] ARM: i.MX6q: fix the wrong parent of can_root clock jiada_wang at mentor.com
2013-10-31  7:38 ` Shawn Guo
2013-11-25 16:44   ` Marc Kleine-Budde
2013-11-26  2:19     ` Shawn Guo
2013-11-26  8:34       ` Marc Kleine-Budde

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).