From: b29396@freescale.com (Dong Aisheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] mmc: sdhci: replace msleep with mdelay for tuning
Date: Wed, 30 Oct 2013 22:10:41 +0800 [thread overview]
Message-ID: <1383142242-24989-2-git-send-email-b29396@freescale.com> (raw)
In-Reply-To: <1383142242-24989-1-git-send-email-b29396@freescale.com>
The former patch 404aceb may break the tuning process of SD3.0/eMMC4.5 cards.
It changed the mdelay in tuning process to msleep,
However, because the more delay of msleep(1) than mdelay(1), it will
easily lead to a 150ms timeout as limited by the spec.
We oberved tuning failed due to timeout on a Toshiba UHS and eMMC4.5 card
after this change. Thus, for the time sensitive tuning process, change it
back to mdelay as before.
The breaking patch is:
404aceb mmc: sdhci: Get rid of mdelay()s where it is safe and makes sense
Signed-off-by: Dong Aisheng <b29396@freescale.com>
---
drivers/mmc/host/sdhci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 22eab3a..2ef5314 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -1981,7 +1981,7 @@ static int sdhci_execute_tuning(struct mmc_host *mmc, u32 opcode)
ctrl = sdhci_readw(host, SDHCI_HOST_CONTROL2);
tuning_loop_counter--;
- msleep(1);
+ mdelay(1);
} while (ctrl & SDHCI_CTRL_EXEC_TUNING);
/*
--
1.7.2.rc3
next prev parent reply other threads:[~2013-10-30 14:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 14:10 [PATCH 0/2] mmc: sdhci-esdhc-imx: adding eMMC HS200 mode support Dong Aisheng
2013-10-30 14:10 ` Dong Aisheng [this message]
2013-10-31 7:17 ` [PATCH 1/2] mmc: sdhci: replace msleep with mdelay for tuning Shawn Guo
2013-10-30 14:10 ` [PATCH 2/2] mmc: sdhci-esdhc-imx: add eMMC HS200 mode support Dong Aisheng
2013-10-31 7:18 ` Shawn Guo
2013-11-13 11:17 ` Dong Aisheng
2013-11-26 21:39 ` [PATCH 0/2] mmc: sdhci-esdhc-imx: adding " Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383142242-24989-2-git-send-email-b29396@freescale.com \
--to=b29396@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).