From: peter.chen@freescale.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 08/11] usb: phy-mxs: Enable IC fixes for related SoCs
Date: Tue, 5 Nov 2013 09:49:40 +0800 [thread overview]
Message-ID: <1383616183-10511-9-git-send-email-peter.chen@freescale.com> (raw)
In-Reply-To: <1383616183-10511-1-git-send-email-peter.chen@freescale.com>
Some PHY bugs are fixed by IC logic, but these bits are not
enabled by default, so we enable them at driver.
Signed-off-by: Peter Chen <peter.chen@freescale.com>
---
drivers/usb/phy/phy-mxs-usb.c | 32 ++++++++++++++++++++++++++++++--
1 files changed, 30 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
index c794011..b7e1744 100644
--- a/drivers/usb/phy/phy-mxs-usb.c
+++ b/drivers/usb/phy/phy-mxs-usb.c
@@ -31,6 +31,10 @@
#define HW_USBPHY_CTRL_SET 0x34
#define HW_USBPHY_CTRL_CLR 0x38
+#define HW_USBPHY_IP 0x90
+#define HW_USBPHY_IP_SET 0x94
+#define HW_USBPHY_IP_CLR 0x98
+
#define BM_USBPHY_CTRL_SFTRST BIT(31)
#define BM_USBPHY_CTRL_CLKGATE BIT(30)
#define BM_USBPHY_CTRL_ENAUTOSET_USBCLKS BIT(26)
@@ -60,6 +64,18 @@
*/
#define MXS_PHY_SENDING_SOF_TOO_FAST BIT(2)
+/*
+ * IC fix for MXS_PHY_ABNORAML_IN_SUSPEND, bit 17 is the effective bit
+ * in HW_USBPHY_IP.
+ */
+#define MXS_PHY_FIX_ABNORAML_IN_SUSPEND BIT(17)
+
+/*
+ * IC fix for MXS_PHY_SENDING_SOF_TOO_FAST, bit 18 is the effective bit
+ * in HW_USBPHY_IP.
+ */
+#define MXS_PHY_FIX_SENDING_SOF_TOO_FAST BIT(18)
+
struct mxs_phy_platform_flag {
unsigned int flags;
};
@@ -70,11 +86,14 @@ static const struct mxs_phy_platform_flag imx23_phy_data = {
static const struct mxs_phy_platform_flag imx6q_phy_data = {
.flags = MXS_PHY_SENDING_SOF_TOO_FAST |
- MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS,
+ MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS |
+ MXS_PHY_FIX_ABNORAML_IN_SUSPEND,
};
static const struct mxs_phy_platform_flag imx6sl_phy_data = {
- .flags = MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS,
+ .flags = MXS_PHY_DISCONNECT_LINE_WITHOUT_VBUS |
+ MXS_PHY_FIX_ABNORAML_IN_SUSPEND |
+ MXS_PHY_FIX_SENDING_SOF_TOO_FAST,
};
static const struct of_device_id mxs_phy_dt_ids[] = {
@@ -118,6 +137,15 @@ static int mxs_phy_hw_init(struct mxs_phy *mxs_phy)
BM_USBPHY_CTRL_ENUTMILEVEL3,
base + HW_USBPHY_CTRL_SET);
+ /* Enable IC solution */
+ if (mxs_phy->flags & MXS_PHY_FIX_ABNORAML_IN_SUSPEND)
+ writel(MXS_PHY_FIX_ABNORAML_IN_SUSPEND,
+ base + HW_USBPHY_IP_SET);
+
+ if (mxs_phy->flags & MXS_PHY_FIX_SENDING_SOF_TOO_FAST)
+ writel(MXS_PHY_FIX_SENDING_SOF_TOO_FAST,
+ base + HW_USBPHY_IP_SET);
+
return 0;
}
--
1.7.1
next prev parent reply other threads:[~2013-11-05 1:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 1:49 [PATCH v3 00/11] Add power management support for MXS PHY Peter Chen
2013-11-05 1:49 ` [PATCH v3 01/11] usb: phy-mxs: Add platform judgement code Peter Chen
2013-11-05 2:29 ` Shawn Guo
2013-11-05 2:48 ` Peter Chen
2013-11-05 1:49 ` [PATCH v3 02/11] usb: phy-mxs: Add auto clock and power setting Peter Chen
2013-11-05 1:49 ` [PATCH v3 03/11] usb: doc: phy-mxs: update binding for adding anatop phandle Peter Chen
2013-11-05 2:34 ` Shawn Guo
2013-11-05 2:50 ` Peter Chen
2013-11-05 3:15 ` Shawn Guo
2013-11-05 1:49 ` [PATCH v3 04/11] ARM: dts: imx6: add anatop phandle for usbphy Peter Chen
2013-11-05 2:41 ` Shawn Guo
2013-11-05 2:53 ` Peter Chen
2013-11-05 3:16 ` Shawn Guo
2013-11-05 3:02 ` Peter Chen
2013-11-05 1:49 ` [PATCH v3 05/11] usb: phy-mxs: Add anatop regmap Peter Chen
2013-11-05 2:47 ` Shawn Guo
2013-11-05 5:17 ` Peter Chen
2013-11-05 1:49 ` [PATCH v3 06/11] usb: phy: add notify suspend and resume callback Peter Chen
2013-11-05 1:49 ` [PATCH v3 07/11] usb: phy-mxs: Add implementation of nofity_suspend and notify_resume Peter Chen
2013-11-05 1:49 ` Peter Chen [this message]
2013-11-05 21:02 ` [PATCH v3 08/11] usb: phy-mxs: Enable IC fixes for related SoCs Michał Mirosław
2013-11-06 7:35 ` Peter Chen
2013-11-05 1:49 ` [PATCH v3 09/11] usb: phy: Add set_wakeup API Peter Chen
2013-11-05 1:49 ` [PATCH v3 10/11] usb: phy-mxs: Add implementation of set_wakeup Peter Chen
2013-11-05 1:49 ` [PATCH v3 11/11] usb: phy-mxs: Add system suspend/resume API Peter Chen
2013-11-05 3:05 ` Shawn Guo
2013-11-05 2:59 ` Peter Chen
2013-11-05 4:04 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383616183-10511-9-git-send-email-peter.chen@freescale.com \
--to=peter.chen@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).