linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: voipac: Improve fixed voltage regulator definition
@ 2013-11-05 12:49 Rostislav Lisovy
  2013-11-06  3:35 ` Shawn Guo
  0 siblings, 1 reply; 2+ messages in thread
From: Rostislav Lisovy @ 2013-11-05 12:49 UTC (permalink / raw)
  To: linux-arm-kernel

Signed-off-by: Rostislav Lisovy <lisovy@gmail.com>
---
 arch/arm/boot/dts/imx53-voipac-dmm-668.dtsi |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx53-voipac-dmm-668.dtsi b/arch/arm/boot/dts/imx53-voipac-dmm-668.dtsi
index a7d03ad..4f1d8fa 100644
--- a/arch/arm/boot/dts/imx53-voipac-dmm-668.dtsi
+++ b/arch/arm/boot/dts/imx53-voipac-dmm-668.dtsi
@@ -27,9 +27,12 @@
 
 	regulators {
 		compatible = "simple-bus";
+		#address-cells = <1>;
+		#size-cells = <0>;
 
-		reg_3p3v: 3p3v {
+		reg_3p3v: regulator at 0 {
 			compatible = "regulator-fixed";
+			reg = <0>;
 			regulator-name = "3P3V";
 			regulator-min-microvolt = <3300000>;
 			regulator-max-microvolt = <3300000>;
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] ARM: dts: voipac: Improve fixed voltage regulator definition
  2013-11-05 12:49 [PATCH] ARM: dts: voipac: Improve fixed voltage regulator definition Rostislav Lisovy
@ 2013-11-06  3:35 ` Shawn Guo
  0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2013-11-06  3:35 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Nov 05, 2013 at 01:49:20PM +0100, Rostislav Lisovy wrote:
> Signed-off-by: Rostislav Lisovy <lisovy@gmail.com>
> ---
>  arch/arm/boot/dts/imx53-voipac-dmm-668.dtsi |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx53-voipac-dmm-668.dtsi b/arch/arm/boot/dts/imx53-voipac-dmm-668.dtsi
> index a7d03ad..4f1d8fa 100644
> --- a/arch/arm/boot/dts/imx53-voipac-dmm-668.dtsi
> +++ b/arch/arm/boot/dts/imx53-voipac-dmm-668.dtsi
> @@ -27,9 +27,12 @@
>  
>  	regulators {
>  		compatible = "simple-bus";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
>  
> -		reg_3p3v: 3p3v {
> +		reg_3p3v: regulator at 0 {

Yeah, instead of using arbitrary node name, the generic regulator at num is
more preferable. I will make this change to the rest of IMX dts files.

Applied, thanks.

Shawn

>  			compatible = "regulator-fixed";
> +			reg = <0>;
>  			regulator-name = "3P3V";
>  			regulator-min-microvolt = <3300000>;
>  			regulator-max-microvolt = <3300000>;
> -- 
> 1.7.10.4
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-11-06  3:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-05 12:49 [PATCH] ARM: dts: voipac: Improve fixed voltage regulator definition Rostislav Lisovy
2013-11-06  3:35 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).