* [PATCH 0/2] ARM & scripts: fix kallsyms regression
@ 2013-11-13 11:15 Ming Lei
2013-11-13 11:15 ` [PATCH 1/2] ARM: default PHYS_OFFSET if !MMU Ming Lei
2013-11-13 11:15 ` [PATCH 2/2] scripts/link-vmlinux.sh: only filter kernel symbols for arm Ming Lei
0 siblings, 2 replies; 7+ messages in thread
From: Ming Lei @ 2013-11-13 11:15 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
These two patches fix the regression on !MMU by below commit:
f6537f2f0eba4eba("scripts/kallsyms: filter symbols not
in kernel address space")
Thanks,
--
Ming Lei
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 1/2] ARM: default PHYS_OFFSET if !MMU
2013-11-13 11:15 [PATCH 0/2] ARM & scripts: fix kallsyms regression Ming Lei
@ 2013-11-13 11:15 ` Ming Lei
2013-11-13 11:46 ` Jonathan Austin
2013-11-13 11:15 ` [PATCH 2/2] scripts/link-vmlinux.sh: only filter kernel symbols for arm Ming Lei
1 sibling, 1 reply; 7+ messages in thread
From: Ming Lei @ 2013-11-13 11:15 UTC (permalink / raw)
To: linux-arm-kernel
From: Jonathan Austin <jonathan.austin@arm.com>
Set CONFIG_PAGE_OFFSET as PHYS_OFFSET when !MMU so that
we can keep CONFIG_PAGE_OFFSET same with PAGE_OFFSET.
This patch and patch 2/2 fix regression on !MMU by
f6537f2f0eba4eba("scripts/kallsyms: filter symbols not
in kernel address space")
Cc: <stable@vger.kernel.org>
Signed-off-by: Jonathan Austin <jonathan.austin@arm.com>
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
---
arch/arm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 799ef94..db708c4 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1560,6 +1560,7 @@ endchoice
config PAGE_OFFSET
hex
+ default PHYS_OFFSET if !MMU
default 0x40000000 if VMSPLIT_1G
default 0x80000000 if VMSPLIT_2G
default 0xC0000000
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 1/2] ARM: default PHYS_OFFSET if !MMU
2013-11-13 11:15 ` [PATCH 1/2] ARM: default PHYS_OFFSET if !MMU Ming Lei
@ 2013-11-13 11:46 ` Jonathan Austin
2013-11-13 13:39 ` Uwe Kleine-König
2013-12-04 16:39 ` Jonathan Austin
0 siblings, 2 replies; 7+ messages in thread
From: Jonathan Austin @ 2013-11-13 11:46 UTC (permalink / raw)
To: linux-arm-kernel
Hi Ming,
On 13/11/13 11:15, Ming Lei wrote:
> From: Jonathan Austin <jonathan.austin@arm.com>
>
> Set CONFIG_PAGE_OFFSET as PHYS_OFFSET when !MMU so that
> we can keep CONFIG_PAGE_OFFSET same with PAGE_OFFSET.
>
I'm not so sure about this commit message - I don't think
it makes sense...Should it not be more like:
------->8-------
Subject: ARM: set PAGE_OFFSET = PHYS_OFFSET if !MMU
With !MMU we still set PAGE_OFFSET to 0xC0000000, which
makes little sense and causes a regression on !MMU after
f6537f2f0eba4eba ("scripts/kallsyms: filter symbols not
kernel address space")
This patch sets PAGE_OFFSET to PHYS_OFFSET in the !MMU
case, fixing the regression (Tested on Cortex-R7/Vexpress)
--------8<---------
Russell: Will you pick this patch up from the list or does
it need to go in through the patch system?
Jonny
> This patch and patch 2/2 fix regression on !MMU by
> f6537f2f0eba4eba("scripts/kallsyms: filter symbols not
> in kernel address space")
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Jonathan Austin <jonathan.austin@arm.com>
> Signed-off-by: Ming Lei <tom.leiming@gmail.com>
> ---
> arch/arm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 799ef94..db708c4 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1560,6 +1560,7 @@ endchoice
>
> config PAGE_OFFSET
> hex
> + default PHYS_OFFSET if !MMU
> default 0x40000000 if VMSPLIT_1G
> default 0x80000000 if VMSPLIT_2G
> default 0xC0000000
>
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 1/2] ARM: default PHYS_OFFSET if !MMU
2013-11-13 11:46 ` Jonathan Austin
@ 2013-11-13 13:39 ` Uwe Kleine-König
2013-12-04 16:39 ` Jonathan Austin
1 sibling, 0 replies; 7+ messages in thread
From: Uwe Kleine-König @ 2013-11-13 13:39 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Nov 13, 2013 at 11:46:49AM +0000, Jonathan Austin wrote:
> Hi Ming,
>
> On 13/11/13 11:15, Ming Lei wrote:
> > From: Jonathan Austin <jonathan.austin@arm.com>
> >
> > Set CONFIG_PAGE_OFFSET as PHYS_OFFSET when !MMU so that
> > we can keep CONFIG_PAGE_OFFSET same with PAGE_OFFSET.
> >
>
> I'm not so sure about this commit message - I don't think
> it makes sense...Should it not be more like:
>
> ------->8-------
> Subject: ARM: set PAGE_OFFSET = PHYS_OFFSET if !MMU
>
> With !MMU we still set PAGE_OFFSET to 0xC0000000, which
> makes little sense and causes a regression on !MMU after
> f6537f2f0eba4eba ("scripts/kallsyms: filter symbols not
> kernel address space")
>
> This patch sets PAGE_OFFSET to PHYS_OFFSET in the !MMU
> case, fixing the regression (Tested on Cortex-R7/Vexpress)
> --------8<---------
I like this commit log better, too.
As CONFIG_PAGE_OFFSET is only used in scripts/kallsyms.c and
scripts/link-vmlinux.sh for !MMU.
Booting on efm32 with this patch works just fine, so if you want add my
Tested-by. But I'm unsure how valuable it is as I don't see a breakage
without it.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 1/2] ARM: default PHYS_OFFSET if !MMU
2013-11-13 11:46 ` Jonathan Austin
2013-11-13 13:39 ` Uwe Kleine-König
@ 2013-12-04 16:39 ` Jonathan Austin
1 sibling, 0 replies; 7+ messages in thread
From: Jonathan Austin @ 2013-12-04 16:39 UTC (permalink / raw)
To: linux-arm-kernel
Hi all,
On 13/11/13 11:46, Jonathan Austin wrote:
> Hi Ming,
>
> On 13/11/13 11:15, Ming Lei wrote:
>> From: Jonathan Austin <jonathan.austin@arm.com>
>>
>> Set CONFIG_PAGE_OFFSET as PHYS_OFFSET when !MMU so that
>> we can keep CONFIG_PAGE_OFFSET same with PAGE_OFFSET.
>>
>
> I'm not so sure about this commit message - I don't think
> it makes sense...Should it not be more like:
>
> ------->8-------
> Subject: ARM: set PAGE_OFFSET = PHYS_OFFSET if !MMU
>
> With !MMU we still set PAGE_OFFSET to 0xC0000000, which
> makes little sense and causes a regression on !MMU after
> f6537f2f0eba4eba ("scripts/kallsyms: filter symbols not
> kernel address space")
>
> This patch sets PAGE_OFFSET to PHYS_OFFSET in the !MMU
> case, fixing the regression (Tested on Cortex-R7/Vexpress)
> --------8<---------
>
> Russell: Will you pick this patch up from the list or does
> it need to go in through the patch system?
What's the status of this patch? Shall I put it in the patch system with
the commit message above? Or is it going via someone else?
Jonny
>
> Jonny
>
>> This patch and patch 2/2 fix regression on !MMU by
>> f6537f2f0eba4eba("scripts/kallsyms: filter symbols not
>> in kernel address space")
>>
>> Cc: <stable@vger.kernel.org>
>> Signed-off-by: Jonathan Austin <jonathan.austin@arm.com>
>> Signed-off-by: Ming Lei <tom.leiming@gmail.com>
>> ---
>> arch/arm/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index 799ef94..db708c4 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -1560,6 +1560,7 @@ endchoice
>>
>> config PAGE_OFFSET
>> hex
>> + default PHYS_OFFSET if !MMU
>> default 0x40000000 if VMSPLIT_1G
>> default 0x80000000 if VMSPLIT_2G
>> default 0xC0000000
>>
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] scripts/link-vmlinux.sh: only filter kernel symbols for arm
2013-11-13 11:15 [PATCH 0/2] ARM & scripts: fix kallsyms regression Ming Lei
2013-11-13 11:15 ` [PATCH 1/2] ARM: default PHYS_OFFSET if !MMU Ming Lei
@ 2013-11-13 11:15 ` Ming Lei
1 sibling, 0 replies; 7+ messages in thread
From: Ming Lei @ 2013-11-13 11:15 UTC (permalink / raw)
To: linux-arm-kernel
Actually CONFIG_PAGE_OFFSET isn't same with PAGE_OFFSET, so
it isn't easy to figue out PAGE_OFFSET defined in header
file from scripts.
Because CONFIG_PAGE_OFFSET may not be defined in some ARCHs(
64bit ARCH), or defined as bogus value in !MMU case, so
this patch only applys the filter on ARM when CONFIG_PAGE_OFFSET
is defined as the original problem is only on ARM.
Cc: <stable@vger.kernel.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Singed-off-by: Ming Lei <tom.leiming@gmail.com>
---
scripts/link-vmlinux.sh | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
index 32b10f5..2dcb377 100644
--- a/scripts/link-vmlinux.sh
+++ b/scripts/link-vmlinux.sh
@@ -82,7 +82,9 @@ kallsyms()
kallsymopt="${kallsymopt} --all-symbols"
fi
- kallsymopt="${kallsymopt} --page-offset=$CONFIG_PAGE_OFFSET"
+ if [ -n "${CONFIG_ARM}" ] && [ -n "${CONFIG_PAGE_OFFSET}" ]; then
+ kallsymopt="${kallsymopt} --page-offset=$CONFIG_PAGE_OFFSET"
+ fi
local aflags="${KBUILD_AFLAGS} ${KBUILD_AFLAGS_KERNEL} \
${NOSTDINC_FLAGS} ${LINUXINCLUDE} ${KBUILD_CPPFLAGS}"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 0/2] ARM & scripts: fix kallsyms regression
@ 2013-11-13 11:11 Ming Lei
0 siblings, 0 replies; 7+ messages in thread
From: Ming Lei @ 2013-11-13 11:11 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
These two patches fix the regression on !MMU by below commit:
f6537f2f0eba4eba("scripts/kallsyms: filter symbols not
in kernel address space")
Thanks,
--
Ming Lei
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-12-04 16:39 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-13 11:15 [PATCH 0/2] ARM & scripts: fix kallsyms regression Ming Lei
2013-11-13 11:15 ` [PATCH 1/2] ARM: default PHYS_OFFSET if !MMU Ming Lei
2013-11-13 11:46 ` Jonathan Austin
2013-11-13 13:39 ` Uwe Kleine-König
2013-12-04 16:39 ` Jonathan Austin
2013-11-13 11:15 ` [PATCH 2/2] scripts/link-vmlinux.sh: only filter kernel symbols for arm Ming Lei
-- strict thread matches above, loose matches on Subject: below --
2013-11-13 11:11 [PATCH 0/2] ARM & scripts: fix kallsyms regression Ming Lei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).