* [PATCH] ARM: dts: imx6qdl: disable spdif "rxtx5" clock option
@ 2013-11-16 15:14 Shawn Guo
2013-11-16 15:13 ` Russell King - ARM Linux
0 siblings, 1 reply; 3+ messages in thread
From: Shawn Guo @ 2013-11-16 15:14 UTC (permalink / raw)
To: linux-arm-kernel
The spdif "rxtx5" clock option is being set to ipg clk (62) by mistake.
This causes an incorrect time keeping when spdif driver is running,
because ipg is ancestor clock for clocksource while spdif driver will
change the rate of this clock in certain circumstance. Before the
correct clock for "rxtx5" option can be supplied, let's disable this
option for now by filling a dummy clock for it.
Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
arch/arm/boot/dts/imx6qdl.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index dcab03b..056b46b 100644
--- a/arch/arm/boot/dts/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/imx6qdl.dtsi
@@ -161,7 +161,7 @@
clocks = <&clks 197>, <&clks 3>,
<&clks 197>, <&clks 107>,
<&clks 0>, <&clks 118>,
- <&clks 62>, <&clks 139>,
+ <&clks 0>, <&clks 139>,
<&clks 0>;
clock-names = "core", "rxtx0",
"rxtx1", "rxtx2",
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] ARM: dts: imx6qdl: disable spdif "rxtx5" clock option
2013-11-16 15:14 [PATCH] ARM: dts: imx6qdl: disable spdif "rxtx5" clock option Shawn Guo
@ 2013-11-16 15:13 ` Russell King - ARM Linux
2013-11-16 15:28 ` Shawn Guo
0 siblings, 1 reply; 3+ messages in thread
From: Russell King - ARM Linux @ 2013-11-16 15:13 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Nov 16, 2013 at 11:14:07PM +0800, Shawn Guo wrote:
> The spdif "rxtx5" clock option is being set to ipg clk (62) by mistake.
> This causes an incorrect time keeping when spdif driver is running,
> because ipg is ancestor clock for clocksource while spdif driver will
> change the rate of this clock in certain circumstance. Before the
> correct clock for "rxtx5" option can be supplied, let's disable this
> option for now by filling a dummy clock for it.
Strangely, this looks exactly like the change I made here :)
Thanks Shawn.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM: dts: imx6qdl: disable spdif "rxtx5" clock option
2013-11-16 15:13 ` Russell King - ARM Linux
@ 2013-11-16 15:28 ` Shawn Guo
0 siblings, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2013-11-16 15:28 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Nov 16, 2013 at 03:13:31PM +0000, Russell King - ARM Linux wrote:
> On Sat, Nov 16, 2013 at 11:14:07PM +0800, Shawn Guo wrote:
> > The spdif "rxtx5" clock option is being set to ipg clk (62) by mistake.
> > This causes an incorrect time keeping when spdif driver is running,
> > because ipg is ancestor clock for clocksource while spdif driver will
> > change the rate of this clock in certain circumstance. Before the
> > correct clock for "rxtx5" option can be supplied, let's disable this
> > option for now by filling a dummy clock for it.
>
> Strangely, this looks exactly like the change I made here :)
Yeah, I tried very hard to find a different quick fix from the one in
your bug report, but failed :) I should mention it's your change.
Shawn
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-16 15:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-16 15:14 [PATCH] ARM: dts: imx6qdl: disable spdif "rxtx5" clock option Shawn Guo
2013-11-16 15:13 ` Russell King - ARM Linux
2013-11-16 15:28 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).