linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/10] ASoC: ux500_pcm: Extend Device Tree support to deal with DMA data
Date: Tue, 19 Nov 2013 11:07:45 +0000	[thread overview]
Message-ID: <1384859269-19801-7-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1384859269-19801-1-git-send-email-lee.jones@linaro.org>

Soon we will strip out pdata support from the Ux500 set of ASoC drivers.
When this happens it will have to supply a DMA slave_config to the
dmaengine. At the moment a great deal of this comes from pdata via
AUXDATA. We need to become independent of this soon. This patch starts
the process by allocating memory for the associated data structures and
fetches the MSP id used for const struct indexing.

Cc: alsa-devel at alsa-project.org
Cc: Mark Brown <broonie@kernel.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 sound/soc/ux500/ux500_msp_i2s.c | 56 ++++++++++++++++++++++++++++++-----------
 1 file changed, 41 insertions(+), 15 deletions(-)

diff --git a/sound/soc/ux500/ux500_msp_i2s.c b/sound/soc/ux500/ux500_msp_i2s.c
index 1ca8b08..7f2a4ac 100644
--- a/sound/soc/ux500/ux500_msp_i2s.c
+++ b/sound/soc/ux500/ux500_msp_i2s.c
@@ -646,6 +646,34 @@ int ux500_msp_i2s_close(struct ux500_msp *msp, unsigned int dir)
 
 }
 
+int ux500_msp_i2s_of_init_msp(struct platform_device *pdev,
+			      struct ux500_msp *msp,
+			      struct msp_i2s_platform_data **platform_data)
+{
+	struct msp_i2s_platform_data *pdata;
+
+	*platform_data = devm_kzalloc(&pdev->dev,
+				     sizeof(struct msp_i2s_platform_data),
+				     GFP_KERNEL);
+	pdata = *platform_data;
+	if (!pdata)
+		return -ENOMEM;
+
+	msp->playback_dma_data.dma_cfg = devm_kzalloc(&pdev->dev,
+					sizeof(struct stedma40_chan_cfg),
+					GFP_KERNEL);
+	if (!msp->playback_dma_data.dma_cfg)
+		return -ENOMEM;
+
+	msp->capture_dma_data.dma_cfg = devm_kzalloc(&pdev->dev,
+					sizeof(struct stedma40_chan_cfg),
+					GFP_KERNEL);
+	if (!msp->capture_dma_data.dma_cfg)
+		return -ENOMEM;
+
+	return 0;
+}
+
 int ux500_msp_i2s_init_msp(struct platform_device *pdev,
 			struct ux500_msp **msp_p,
 			struct msp_i2s_platform_data *platform_data)
@@ -653,30 +681,28 @@ int ux500_msp_i2s_init_msp(struct platform_device *pdev,
 	struct resource *res = NULL;
 	struct device_node *np = pdev->dev.of_node;
 	struct ux500_msp *msp;
+	int ret;
 
 	*msp_p = devm_kzalloc(&pdev->dev, sizeof(struct ux500_msp), GFP_KERNEL);
 	msp = *msp_p;
 	if (!msp)
 		return -ENOMEM;
 
-	if (np) {
-		if (!platform_data) {
-			platform_data = devm_kzalloc(&pdev->dev,
-				sizeof(struct msp_i2s_platform_data), GFP_KERNEL);
-			if (!platform_data)
-				return -ENOMEM;
-		}
-	} else
-		if (!platform_data)
+	if (!platform_data) {
+		if (np) {
+			ret = ux500_msp_i2s_of_init_msp(pdev, msp,
+							&platform_data);
+			if (ret)
+				return ret;
+		} else
 			return -EINVAL;
+	} else {
+		msp->playback_dma_data.dma_cfg = platform_data->msp_i2s_dma_tx;
+		msp->capture_dma_data.dma_cfg = platform_data->msp_i2s_dma_rx;
+		msp->id = platform_data->id;
+	}
 
-	dev_dbg(&pdev->dev, "%s: Enter (name: %s, id: %d).\n", __func__,
-		pdev->name, platform_data->id);
-
-	msp->id = platform_data->id;
 	msp->dev = &pdev->dev;
-	msp->playback_dma_data.dma_cfg = platform_data->msp_i2s_dma_tx;
-	msp->capture_dma_data.dma_cfg = platform_data->msp_i2s_dma_rx;
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	if (res == NULL) {
-- 
1.8.1.2

  parent reply	other threads:[~2013-11-19 11:07 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-19 11:07 [PATCH 00/10] ASoC: dma: ARM: ux500: Obtain DMA data from Device Tree Lee Jones
2013-11-19 11:07 ` [PATCH 01/10] dma: ste_dma40: Expand DT binding to accept 'high-priority channel' flag Lee Jones
2013-11-19 21:02   ` Linus Walleij
2013-11-19 11:07 ` [PATCH 02/10] dma: ste_dma40: Parse flags property for new 'high priority channel' request Lee Jones
2013-11-19 21:03   ` Linus Walleij
2013-11-19 11:07 ` [PATCH 03/10] ARM: ux500: Don't use enums for MSP IDs - for easy DT conversion Lee Jones
2013-11-19 11:07 ` [PATCH 04/10] ARM: ux500: Add DMA config bindings for MSP devices Lee Jones
2013-11-19 21:06   ` Linus Walleij
2013-11-19 11:07 ` [PATCH 05/10] ASoC: Ux500: Match platform by device node when booting Device Tree Lee Jones
2013-11-19 18:49   ` Mark Brown
2013-11-19 11:07 ` Lee Jones [this message]
2013-11-19 18:50   ` [PATCH 06/10] ASoC: ux500_pcm: Extend Device Tree support to deal with DMA data Mark Brown
2013-11-19 11:07 ` [PATCH 07/10] ASoC: ux500: Store DMA data in the DAI differently in the pdata and DT case Lee Jones
2013-11-19 18:51   ` Mark Brown
2013-12-02  7:35   ` [alsa-devel] " Olof Johansson
2013-12-02 10:12     ` Lee Jones
2013-12-02 13:54       ` Mark Brown
2013-12-02 14:03         ` Lee Jones
2013-12-02 14:04           ` Mark Brown
2013-12-04 17:45   ` Kevin Hilman
2013-12-04 18:03     ` Lee Jones
2013-11-19 11:07 ` [PATCH 08/10] ASoC: ux500_pcm: Differentiate between pdata and DT initialisation Lee Jones
2013-11-19 18:48   ` Mark Brown
2013-11-19 19:33     ` Lee Jones
2013-11-19 19:40       ` Lars-Peter Clausen
2013-11-19 20:09         ` Mark Brown
2013-11-19 11:07 ` [PATCH 09/10] ASoC: ux500_pcm: Take out pointless dev_dbg() call Lee Jones
2013-11-19 18:51   ` Mark Brown
2013-11-19 11:07 ` [PATCH 10/10] ASoC: ux500: Dynamically fill DAI driver data on probe Lee Jones
2013-11-19 18:53 ` [PATCH 00/10] ASoC: dma: ARM: ux500: Obtain DMA data from Device Tree Mark Brown
2013-11-29 16:03 ` Lee Jones
2013-11-29 16:42   ` Mark Brown
2013-11-29 17:37     ` Lee Jones
2013-11-29 18:21       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384859269-19801-7-git-send-email-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).