linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 07/10] ASoC: ux500: Store DMA data in the DAI differently in the pdata and DT case
Date: Tue, 19 Nov 2013 11:07:46 +0000	[thread overview]
Message-ID: <1384859269-19801-8-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1384859269-19801-1-git-send-email-lee.jones@linaro.org>

In this patch we do two things. Firstly, instead of open coding the
store of DMA data in to the DAI for later use, we use the API provided.
Secondly we create and store similar DMA data for the DT case, only
this time we use 'struct snd_dmaengine_dai_dma_data' which is provided
by the core for this very reason.

Cc: alsa-devel at alsa-project.org
Cc: Mark Brown <broonie@kernel.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 sound/soc/ux500/ux500_msp_dai.c | 42 +++++++++++++++++++++++++++++++++++++++--
 1 file changed, 40 insertions(+), 2 deletions(-)

diff --git a/sound/soc/ux500/ux500_msp_dai.c b/sound/soc/ux500/ux500_msp_dai.c
index c6fb5cc..8d1b01f 100644
--- a/sound/soc/ux500/ux500_msp_dai.c
+++ b/sound/soc/ux500/ux500_msp_dai.c
@@ -17,12 +17,14 @@
 #include <linux/bitops.h>
 #include <linux/platform_device.h>
 #include <linux/clk.h>
+#include <linux/of.h>
 #include <linux/regulator/consumer.h>
 #include <linux/mfd/dbx500-prcmu.h>
 #include <linux/platform_data/asoc-ux500-msp.h>
 
 #include <sound/soc.h>
 #include <sound/soc-dai.h>
+#include <sound/dmaengine_pcm.h>
 
 #include "ux500_msp_i2s.h"
 #include "ux500_msp_dai.h"
@@ -654,16 +656,52 @@ static int ux500_msp_dai_trigger(struct snd_pcm_substream *substream,
 	return ret;
 }
 
+static int ux500_msp_dai_of_probe(struct snd_soc_dai *dai)
+{
+	struct ux500_msp_i2s_drvdata *drvdata = dev_get_drvdata(dai->dev);
+	struct snd_dmaengine_dai_dma_data *playback_dma_data;
+	struct snd_dmaengine_dai_dma_data *capture_dma_data;
+
+	playback_dma_data = devm_kzalloc(dai->dev,
+					 sizeof(*playback_dma_data),
+					 GFP_KERNEL);
+	if (!playback_dma_data)
+		return -ENOMEM;
+
+	capture_dma_data = devm_kzalloc(dai->dev,
+					sizeof(*capture_dma_data),
+					GFP_KERNEL);
+	if (!capture_dma_data)
+		return -ENOMEM;
+
+	playback_dma_data->addr = drvdata->msp->playback_dma_data.tx_rx_addr;
+	capture_dma_data->addr = drvdata->msp->capture_dma_data.tx_rx_addr;
+
+	playback_dma_data->maxburst = 4;
+	capture_dma_data->maxburst = 4;
+
+	snd_soc_dai_init_dma_data(dai, playback_dma_data, capture_dma_data);
+
+	return 0;
+}
+
 static int ux500_msp_dai_probe(struct snd_soc_dai *dai)
 {
 	struct ux500_msp_i2s_drvdata *drvdata = dev_get_drvdata(dai->dev);
+	struct device_node *np = dai->dev->of_node;
+	int ret;
 
-	dai->playback_dma_data = &drvdata->msp->playback_dma_data;
-	dai->capture_dma_data = &drvdata->msp->capture_dma_data;
+	if (np) {
+		ret = ux500_msp_dai_of_probe(dai);
+		return ret;
+	}
 
 	drvdata->msp->playback_dma_data.data_size = drvdata->slot_width;
 	drvdata->msp->capture_dma_data.data_size = drvdata->slot_width;
 
+	snd_soc_dai_init_dma_data(dai,
+				  &drvdata->msp->playback_dma_data,
+				  &drvdata->msp->capture_dma_data);
 	return 0;
 }
 
-- 
1.8.1.2

  parent reply	other threads:[~2013-11-19 11:07 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-19 11:07 [PATCH 00/10] ASoC: dma: ARM: ux500: Obtain DMA data from Device Tree Lee Jones
2013-11-19 11:07 ` [PATCH 01/10] dma: ste_dma40: Expand DT binding to accept 'high-priority channel' flag Lee Jones
2013-11-19 21:02   ` Linus Walleij
2013-11-19 11:07 ` [PATCH 02/10] dma: ste_dma40: Parse flags property for new 'high priority channel' request Lee Jones
2013-11-19 21:03   ` Linus Walleij
2013-11-19 11:07 ` [PATCH 03/10] ARM: ux500: Don't use enums for MSP IDs - for easy DT conversion Lee Jones
2013-11-19 11:07 ` [PATCH 04/10] ARM: ux500: Add DMA config bindings for MSP devices Lee Jones
2013-11-19 21:06   ` Linus Walleij
2013-11-19 11:07 ` [PATCH 05/10] ASoC: Ux500: Match platform by device node when booting Device Tree Lee Jones
2013-11-19 18:49   ` Mark Brown
2013-11-19 11:07 ` [PATCH 06/10] ASoC: ux500_pcm: Extend Device Tree support to deal with DMA data Lee Jones
2013-11-19 18:50   ` Mark Brown
2013-11-19 11:07 ` Lee Jones [this message]
2013-11-19 18:51   ` [PATCH 07/10] ASoC: ux500: Store DMA data in the DAI differently in the pdata and DT case Mark Brown
2013-12-02  7:35   ` [alsa-devel] " Olof Johansson
2013-12-02 10:12     ` Lee Jones
2013-12-02 13:54       ` Mark Brown
2013-12-02 14:03         ` Lee Jones
2013-12-02 14:04           ` Mark Brown
2013-12-04 17:45   ` Kevin Hilman
2013-12-04 18:03     ` Lee Jones
2013-11-19 11:07 ` [PATCH 08/10] ASoC: ux500_pcm: Differentiate between pdata and DT initialisation Lee Jones
2013-11-19 18:48   ` Mark Brown
2013-11-19 19:33     ` Lee Jones
2013-11-19 19:40       ` Lars-Peter Clausen
2013-11-19 20:09         ` Mark Brown
2013-11-19 11:07 ` [PATCH 09/10] ASoC: ux500_pcm: Take out pointless dev_dbg() call Lee Jones
2013-11-19 18:51   ` Mark Brown
2013-11-19 11:07 ` [PATCH 10/10] ASoC: ux500: Dynamically fill DAI driver data on probe Lee Jones
2013-11-19 18:53 ` [PATCH 00/10] ASoC: dma: ARM: ux500: Obtain DMA data from Device Tree Mark Brown
2013-11-29 16:03 ` Lee Jones
2013-11-29 16:42   ` Mark Brown
2013-11-29 17:37     ` Lee Jones
2013-11-29 18:21       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384859269-19801-8-git-send-email-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).