From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Praveenkumar I <quic_ipkumar@quicinc.com>,
robert.marko@sartura.hr, luka.perkov@sartura.hr,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, vkoul@kernel.org, kishon@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, gregkh@linuxfoundation.org,
catalin.marinas@arm.com, will@kernel.org, p.zabel@pengutronix.de,
arnd@arndb.de, geert+renesas@glider.be, nfraprado@collabora.com,
rafal@milecki.pl, peng.fan@nxp.com, quic_wcheng@quicinc.com,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: quic_varada@quicinc.com
Subject: Re: [PATCH 6/9] arm64: dts: qcom: ipq5332: Add USB3 related nodes
Date: Tue, 29 Aug 2023 19:02:51 +0200 [thread overview]
Message-ID: <1384c4a4-2abc-4534-9dba-5c0da9605b05@linaro.org> (raw)
In-Reply-To: <20230829135818.2219438-7-quic_ipkumar@quicinc.com>
On 29/08/2023 15:58, Praveenkumar I wrote:
> Add SS UNIPHY and update controller node for USB3.
>
> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
> ---
> This patch depends on the below series which adds support for USB2 in
> IPQ5332
> https://lore.kernel.org/all/cover.1692699472.git.quic_varada@quicinc.com/
>
> arch/arm64/boot/dts/qcom/ipq5332.dtsi | 39 ++++++++++++++++++++++-----
> 1 file changed, 32 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> index e6baf694488c..7fbe6c9f4784 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> @@ -158,6 +158,27 @@ usbphy0: phy@7b000 {
> status = "disabled";
> };
>
> + ssuniphy0: ssuniphy@4b0000 {
From where did you get such pattern of node naming? Downstream, right?
Please, do not work on downstream but upstream.
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-29 17:03 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 13:58 [PATCH 0/9] Enable USB3 for IPQ5332 Praveenkumar I
2023-08-29 13:58 ` [PATCH 1/9] dt-bindings: phy: qcom,uniphy: Rename ipq4019 usb PHY to UNIPHY Praveenkumar I
2023-08-29 14:19 ` Dmitry Baryshkov
2023-08-31 11:53 ` Praveenkumar I
2023-08-31 12:17 ` Dmitry Baryshkov
2023-08-31 12:29 ` Praveenkumar I
2023-08-31 12:34 ` Dmitry Baryshkov
2023-08-31 12:50 ` Praveenkumar I
2023-08-29 16:53 ` Krzysztof Kozlowski
2023-08-29 13:58 ` [PATCH 2/9] phy: qcom: uniphy: Rename ipq4019 USB phy driver to UNIPHY driver Praveenkumar I
2023-08-29 16:55 ` Krzysztof Kozlowski
2023-08-31 13:08 ` Praveenkumar I
2023-08-29 13:58 ` [PATCH 3/9] phy: qcom: uniphy: Update UNIPHY driver to be a common driver Praveenkumar I
2023-08-29 14:37 ` Dmitry Baryshkov
2023-08-31 12:05 ` Praveenkumar I
2023-08-29 16:57 ` Krzysztof Kozlowski
2023-08-29 13:58 ` [PATCH 4/9] dt-bindings: phy: qcom,uniphy: Add ipq5332 USB3 SS UNIPHY Praveenkumar I
2023-08-29 14:16 ` Dmitry Baryshkov
2023-08-29 14:35 ` Rob Herring
2023-08-29 17:08 ` Krzysztof Kozlowski
2023-08-29 18:46 ` Dmitry Baryshkov
2023-08-29 16:16 ` Rob Herring
2023-08-29 16:59 ` Krzysztof Kozlowski
2023-08-29 13:58 ` [PATCH 5/9] dt-bindings: usb: dwc3: Update IPQ5332 compatible Praveenkumar I
2023-08-29 17:01 ` Krzysztof Kozlowski
2023-08-29 13:58 ` [PATCH 6/9] arm64: dts: qcom: ipq5332: Add USB3 related nodes Praveenkumar I
2023-08-29 14:46 ` Dmitry Baryshkov
2023-08-29 17:02 ` Krzysztof Kozlowski [this message]
2023-08-29 13:58 ` [PATCH 7/9] arm64: dts: qcom: ipq5332: Enable USB SS UNIPHY Praveenkumar I
2023-08-29 17:03 ` Krzysztof Kozlowski
2023-08-29 13:58 ` [PATCH 8/9] phy: qcom: uniphy: Add ipq5332 USB UNIPHY support Praveenkumar I
2023-08-29 14:45 ` Dmitry Baryshkov
[not found] ` <2ff8ef8e-c7d8-4a02-a764-ef2a3f83e87c@quicinc.com>
2023-08-31 12:21 ` Dmitry Baryshkov
2023-08-29 13:58 ` [PATCH 9/9] arm64: defconfig: Enable UNIPHY driver Praveenkumar I
2023-08-29 17:06 ` Krzysztof Kozlowski
2023-08-29 17:07 ` [PATCH 0/9] Enable USB3 for IPQ5332 Krzysztof Kozlowski
2023-08-31 12:14 ` Praveenkumar I
2023-08-31 12:15 ` Praveenkumar I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384c4a4-2abc-4534-9dba-5c0da9605b05@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=luka.perkov@sartura.hr \
--cc=nfraprado@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=peng.fan@nxp.com \
--cc=quic_ipkumar@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=rafal@milecki.pl \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).