linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: dbaryshkov@gmail.com (Dmitry Eremin-Solenikov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/6] arm: sa1100: h3100: refactor IrDA GPIO handling
Date: Thu, 21 Nov 2013 19:40:11 +0400	[thread overview]
Message-ID: <1385048414-9812-4-git-send-email-dbaryshkov@gmail.com> (raw)
In-Reply-To: <1385048414-9812-1-git-send-email-dbaryshkov@gmail.com>

As GPIOs are going to move to platform device, there is no guarantee
that they will be available at init_machine time.

Request and free all GPIOs from IrDA startup/shutdown callbacks and not
at init_machine time.

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
---
 arch/arm/mach-sa1100/h3100.c | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-sa1100/h3100.c b/arch/arm/mach-sa1100/h3100.c
index 5b78c9f..daa27c4 100644
--- a/arch/arm/mach-sa1100/h3100.c
+++ b/arch/arm/mach-sa1100/h3100.c
@@ -89,6 +89,11 @@ static void __init h3100_map_io(void)
 /*
  * This turns the IRDA power on or off on the Compaq H3100
  */
+static struct gpio h3100_irda_gpio[] = {
+	{ H3100_GPIO_IR_ON,	GPIOF_OUT_INIT_LOW, "IrDA power" },
+	{ H3100_GPIO_IR_FSEL,	GPIOF_OUT_INIT_LOW, "IrDA fsel" },
+};
+
 static int h3100_irda_set_power(struct device *dev, unsigned int state)
 {
 	gpio_set_value(H3100_GPIO_IR_ON, state);
@@ -100,14 +105,24 @@ static void h3100_irda_set_speed(struct device *dev, unsigned int speed)
 	gpio_set_value(H3100_GPIO_IR_FSEL, !(speed < 4000000));
 }
 
+static int h3100_irda_startup(struct device *dev)
+{
+	return gpio_request_array(h3100_irda_gpio, sizeof(h3100_irda_gpio));
+}
+
+static void h3100_irda_shutdown(struct device *dev)
+{
+	return gpio_free_array(h3100_irda_gpio, sizeof(h3100_irda_gpio));
+}
+
 static struct irda_platform_data h3100_irda_data = {
 	.set_power	= h3100_irda_set_power,
 	.set_speed	= h3100_irda_set_speed,
+	.startup	= h3100_irda_startup,
+	.shutdown	= h3100_irda_shutdown,
 };
 
 static struct gpio_default_state h3100_default_gpio[] = {
-	{ H3100_GPIO_IR_ON,	GPIO_MODE_OUT0, "IrDA power" },
-	{ H3100_GPIO_IR_FSEL,	GPIO_MODE_OUT0, "IrDA fsel" },
 	{ H3XXX_GPIO_COM_DCD,	GPIO_MODE_IN,	"COM DCD" },
 	{ H3XXX_GPIO_COM_CTS,	GPIO_MODE_IN,	"COM CTS" },
 	{ H3XXX_GPIO_COM_RTS,	GPIO_MODE_OUT0,	"COM RTS" },
-- 
1.8.4.2

  parent reply	other threads:[~2013-11-21 15:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-21 15:40 [PATCH 0/6] arm: sa1100: refactor h3xxx GPIO handling Dmitry Eremin-Solenikov
2013-11-21 15:40 ` [PATCH 1/6] arm: sa1100: h3100: refactor LCD " Dmitry Eremin-Solenikov
2013-11-26  8:52   ` Linus Walleij
2013-11-26  9:07     ` Dmitry Eremin-Solenikov
2013-11-26 12:31       ` Linus Walleij
2013-11-21 15:40 ` [PATCH 2/6] arm: sa1100: h3600: " Dmitry Eremin-Solenikov
2013-11-26  8:52   ` Linus Walleij
2013-11-21 15:40 ` Dmitry Eremin-Solenikov [this message]
2013-11-26  8:53   ` [PATCH 3/6] arm: sa1100: h3100: refactor IrDA " Linus Walleij
2013-11-21 15:40 ` [PATCH 4/6] arm: sa1100: h3600: " Dmitry Eremin-Solenikov
2013-11-26  8:54   ` Linus Walleij
2013-11-21 15:40 ` [PATCH 5/6] arm: sa1100: h3xxx: move serial port GPIO handling to common place Dmitry Eremin-Solenikov
2013-11-26  8:54   ` Linus Walleij
2013-11-21 15:40 ` [PATCH 6/6] arm: sa1100: h3xxx: drop hand-coded gpio_request_array analogue Dmitry Eremin-Solenikov
2013-11-26  8:55   ` Linus Walleij
2013-11-26  8:49 ` [PATCH 0/6] arm: sa1100: refactor h3xxx GPIO handling Linus Walleij
2013-11-26 10:12   ` Dmitry Eremin-Solenikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385048414-9812-4-git-send-email-dbaryshkov@gmail.com \
    --to=dbaryshkov@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).