From: dbaryshkov@gmail.com (Dmitry Eremin-Solenikov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/6] arm: sa1100: h3xxx: drop hand-coded gpio_request_array analogue
Date: Thu, 21 Nov 2013 19:40:14 +0400 [thread overview]
Message-ID: <1385048414-9812-7-git-send-email-dbaryshkov@gmail.com> (raw)
In-Reply-To: <1385048414-9812-1-git-send-email-dbaryshkov@gmail.com>
h3xxx_init_gpio() behaves alsmost like gpio_request_array. Also after
all GPIO refactoring it is unused. Drop it now.
Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
---
arch/arm/mach-sa1100/h3xxx.c | 31 -------------------------------
arch/arm/mach-sa1100/include/mach/h3xxx.h | 11 -----------
2 files changed, 42 deletions(-)
diff --git a/arch/arm/mach-sa1100/h3xxx.c b/arch/arm/mach-sa1100/h3xxx.c
index 82e8702..c79bf46 100644
--- a/arch/arm/mach-sa1100/h3xxx.c
+++ b/arch/arm/mach-sa1100/h3xxx.c
@@ -28,37 +28,6 @@
#include "generic.h"
-void h3xxx_init_gpio(struct gpio_default_state *s, size_t n)
-{
- while (n--) {
- const char *name = s->name;
- int err;
-
- if (!name)
- name = "[init]";
- err = gpio_request(s->gpio, name);
- if (err) {
- printk(KERN_ERR "gpio%u: unable to request: %d\n",
- s->gpio, err);
- continue;
- }
- if (s->mode >= 0) {
- err = gpio_direction_output(s->gpio, s->mode);
- } else {
- err = gpio_direction_input(s->gpio);
- }
- if (err) {
- printk(KERN_ERR "gpio%u: unable to set direction: %d\n",
- s->gpio, err);
- continue;
- }
- if (!s->name)
- gpio_free(s->gpio);
- s++;
- }
-}
-
-
/*
* H3xxx flash support
*/
diff --git a/arch/arm/mach-sa1100/include/mach/h3xxx.h b/arch/arm/mach-sa1100/include/mach/h3xxx.h
index c810620..603d434 100644
--- a/arch/arm/mach-sa1100/include/mach/h3xxx.h
+++ b/arch/arm/mach-sa1100/include/mach/h3xxx.h
@@ -79,17 +79,6 @@
#define H3600_EGPIO_LCD_5V_ON (H3XXX_EGPIO_BASE + 14) /* enable 5V to LCD. active high. */
#define H3600_EGPIO_LVDD_ON (H3XXX_EGPIO_BASE + 15) /* enable 9V and -6.5V to LCD. */
-struct gpio_default_state {
- int gpio;
- int mode;
- const char *name;
-};
-
-#define GPIO_MODE_IN -1
-#define GPIO_MODE_OUT0 0
-#define GPIO_MODE_OUT1 1
-
-void h3xxx_init_gpio(struct gpio_default_state *s, size_t n);
void __init h3xxx_map_io(void);
void __init h3xxx_mach_init(void);
--
1.8.4.2
next prev parent reply other threads:[~2013-11-21 15:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 15:40 [PATCH 0/6] arm: sa1100: refactor h3xxx GPIO handling Dmitry Eremin-Solenikov
2013-11-21 15:40 ` [PATCH 1/6] arm: sa1100: h3100: refactor LCD " Dmitry Eremin-Solenikov
2013-11-26 8:52 ` Linus Walleij
2013-11-26 9:07 ` Dmitry Eremin-Solenikov
2013-11-26 12:31 ` Linus Walleij
2013-11-21 15:40 ` [PATCH 2/6] arm: sa1100: h3600: " Dmitry Eremin-Solenikov
2013-11-26 8:52 ` Linus Walleij
2013-11-21 15:40 ` [PATCH 3/6] arm: sa1100: h3100: refactor IrDA " Dmitry Eremin-Solenikov
2013-11-26 8:53 ` Linus Walleij
2013-11-21 15:40 ` [PATCH 4/6] arm: sa1100: h3600: " Dmitry Eremin-Solenikov
2013-11-26 8:54 ` Linus Walleij
2013-11-21 15:40 ` [PATCH 5/6] arm: sa1100: h3xxx: move serial port GPIO handling to common place Dmitry Eremin-Solenikov
2013-11-26 8:54 ` Linus Walleij
2013-11-21 15:40 ` Dmitry Eremin-Solenikov [this message]
2013-11-26 8:55 ` [PATCH 6/6] arm: sa1100: h3xxx: drop hand-coded gpio_request_array analogue Linus Walleij
2013-11-26 8:49 ` [PATCH 0/6] arm: sa1100: refactor h3xxx GPIO handling Linus Walleij
2013-11-26 10:12 ` Dmitry Eremin-Solenikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385048414-9812-7-git-send-email-dbaryshkov@gmail.com \
--to=dbaryshkov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).