From: fabio.estevam@freescale.com (Fabio Estevam)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] backlight: pwm_bl: Do not make the regulator mandatory
Date: Thu, 21 Nov 2013 15:43:15 -0200 [thread overview]
Message-ID: <1385055795-24002-1-git-send-email-fabio.estevam@freescale.com> (raw)
Commit 22ceeee1 (pwm-backlight: Add power supply support) caused breakage on
boards that do not define the backlight regulator on their dts files.
Instead of making the backlight regulator mandatory, treat it as optional
instead, so that we do not have breakage.
This avoids the need for adding a dummy regulator on every dts file that uses
the pwm-backlight.
Tested on a mx6qsabresd.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
.../devicetree/bindings/video/backlight/pwm-backlight.txt | 2 +-
drivers/video/backlight/pwm_bl.c | 15 +++++++--------
2 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt b/Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt
index 764db86..ed3dc3c 100644
--- a/Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt
+++ b/Documentation/devicetree/bindings/video/backlight/pwm-backlight.txt
@@ -10,13 +10,13 @@ Required properties:
last value in the array represents a 100% duty cycle (brightest).
- default-brightness-level: the default brightness level (index into the
array defined by the "brightness-levels" property)
- - power-supply: regulator for supply voltage
Optional properties:
- pwm-names: a list of names for the PWM devices specified in the
"pwms" property (see PWM binding[0])
- enable-gpios: contains a single GPIO specifier for the GPIO which enables
and disables the backlight (see GPIO binding[1])
+ - power-supply: regulator for supply voltage
[0]: Documentation/devicetree/bindings/pwm/pwm.txt
[1]: Documentation/devicetree/bindings/gpio/gpio.txt
diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index fb80d68..fb3008c 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -50,9 +50,11 @@ static void pwm_backlight_power_on(struct pwm_bl_data *pb, int brightness)
if (pb->enabled)
return;
- err = regulator_enable(pb->power_supply);
- if (err < 0)
- dev_err(pb->dev, "failed to enable power supply\n");
+ if (!IS_ERR(pb->power_supply)) {
+ err = regulator_enable(pb->power_supply);
+ if (err < 0)
+ dev_err(pb->dev, "failed to enable power supply\n");
+ }
if (gpio_is_valid(pb->enable_gpio)) {
if (pb->enable_gpio_flags & PWM_BACKLIGHT_GPIO_ACTIVE_LOW)
@@ -80,7 +82,8 @@ static void pwm_backlight_power_off(struct pwm_bl_data *pb)
gpio_set_value(pb->enable_gpio, 0);
}
- regulator_disable(pb->power_supply);
+ if (!IS_ERR(pb->power_supply))
+ regulator_disable(pb->power_supply);
pb->enabled = false;
}
@@ -283,10 +286,6 @@ static int pwm_backlight_probe(struct platform_device *pdev)
}
pb->power_supply = devm_regulator_get(&pdev->dev, "power");
- if (IS_ERR(pb->power_supply)) {
- ret = PTR_ERR(pb->power_supply);
- goto err_gpio;
- }
pb->pwm = devm_pwm_get(&pdev->dev, NULL);
if (IS_ERR(pb->pwm)) {
--
1.8.1.2
next reply other threads:[~2013-11-21 17:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 17:43 Fabio Estevam [this message]
2013-11-22 0:42 ` [PATCH] backlight: pwm_bl: Do not make the regulator mandatory Marek Vasut
2013-11-22 14:22 ` Thierry Reding
2013-11-22 14:52 ` Mark Brown
2013-11-22 16:06 ` Fabio Estevam
2013-11-25 3:10 ` Shawn Guo
2013-11-25 13:26 ` Fabio Estevam
2013-11-25 13:37 ` Shawn Guo
2013-11-25 14:43 ` Fabio Estevam
2013-11-25 17:29 ` Mark Brown
2013-11-25 20:37 ` Fabio Estevam
2013-11-25 20:58 ` Fabio Estevam
2013-11-26 13:18 ` Mark Brown
2013-11-25 15:37 ` Mark Brown
2013-11-25 15:48 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385055795-24002-1-git-send-email-fabio.estevam@freescale.com \
--to=fabio.estevam@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).