From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: OMAP2+: Fix eMMC on n900 with device tree
Date: Thu, 21 Nov 2013 10:51:06 -0800 [thread overview]
Message-ID: <1385059866-10646-4-git-send-email-tony@atomide.com> (raw)
In-Reply-To: <1385059866-10646-1-git-send-email-tony@atomide.com>
Looks like we need to configure the regulators and use the pdata
quirk to make eMMC work with device tree.
It seems that mostly vmmc2 is used, and only some earlier revisions
like the macro board used vaux3.
Note that we can add support for the macro board later as needed
by including the common n900 .dts file and configuring the vaux3
instead of vmmc2, and adding support for the smc91x Ethernet.
Cc: devicetree at vger.kernel.org
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Sebastian Reichel <sre@debian.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
Can you guys please test this on production n900 devices?
I've tested it with my old macro board where I had to patch in vaux3
instead of vmmc2. I think there's some confusion in the legacy code
comments, or else I'm confused. In any case, vaux3 works for the macro
board, and I suspect that the production versions have vmmc2.
If this does not work and vaux3 as regulator works, please also dump
out the system_rev from your board.
---
arch/arm/boot/dts/omap3-n900.dts | 6 +++++-
arch/arm/mach-omap2/pdata-quirks.c | 1 +
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
index c4f20bf..392ced2 100644
--- a/arch/arm/boot/dts/omap3-n900.dts
+++ b/arch/arm/boot/dts/omap3-n900.dts
@@ -359,7 +359,11 @@
};
&mmc2 {
- status = "disabled";
+ /* most boards use vmmc2, only the macro boards use vaux3 */
+ vmmc-supply = <&vmmc2>;
+ vmmc_aux-supply = <&vsim>;
+ bus-width = <8>;
+ non-removable;
};
&mmc3 {
diff --git a/arch/arm/mach-omap2/pdata-quirks.c b/arch/arm/mach-omap2/pdata-quirks.c
index 10c7145..39f020c 100644
--- a/arch/arm/mach-omap2/pdata-quirks.c
+++ b/arch/arm/mach-omap2/pdata-quirks.c
@@ -139,6 +139,7 @@ struct of_dev_auxdata omap_auxdata_lookup[] __initdata = {
static struct pdata_init pdata_quirks[] __initdata = {
#ifdef CONFIG_ARCH_OMAP3
+ { "nokia,omap3-n900", hsmmc2_internal_input_clk, },
{ "nokia,omap3-n9", hsmmc2_internal_input_clk, },
{ "nokia,omap3-n950", hsmmc2_internal_input_clk, },
{ "isee,omap3-igep0020", omap3_igep0020_legacy_init, },
--
1.8.1.1
next prev parent reply other threads:[~2013-11-21 18:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 18:51 [PATCH 0/3] Yet more fixes for booting omaps with device tree Tony Lindgren
2013-11-21 18:51 ` [PATCH 1/3] ARM: OMAP2+: Fix more missing data for omap3.dtsi file Tony Lindgren
2013-11-21 18:51 ` [PATCH 2/3] ARM: OMAP2+: Add fixed regulator to omap2plus_defconfig Tony Lindgren
2013-11-21 18:51 ` Tony Lindgren [this message]
2013-11-21 23:17 ` [PATCH 3/3] ARM: OMAP2+: Fix eMMC on n900 with device tree Sebastian Reichel
2013-11-21 23:57 ` Tony Lindgren
2013-11-22 16:35 ` Sebastian Reichel
2013-11-22 17:14 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385059866-10646-4-git-send-email-tony@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).