From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 11/13] mfd: menelaus: start to use irqdomain
Date: Wed, 27 Nov 2013 13:06:55 -0600 [thread overview]
Message-ID: <1385579217-20127-12-git-send-email-balbi@ti.com> (raw)
In-Reply-To: <1385579217-20127-1-git-send-email-balbi@ti.com>
introduce an irq_chip and irq_domain for
menelaus driver. Following patches will
convert uses to traditional request_threaded_irq().
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
drivers/mfd/menelaus.c | 109 +++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 109 insertions(+)
diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c
index aa3c579..295fe84 100644
--- a/drivers/mfd/menelaus.c
+++ b/drivers/mfd/menelaus.c
@@ -34,6 +34,7 @@
#include <linux/module.h>
#include <linux/i2c.h>
#include <linux/interrupt.h>
+#include <linux/irqdomain.h>
#include <linux/sched.h>
#include <linux/mutex.h>
#include <linux/delay.h>
@@ -47,6 +48,7 @@
#include <asm/gpio.h>
#define DRIVER_NAME "menelaus"
+#define MENELAUS_NR_IRQS 16
#define MENELAUS_I2C_ADDRESS 0x72
@@ -168,11 +170,19 @@ struct menelaus_chip {
u8 rtc_control;
unsigned uie:1;
#endif
+ int irq_base;
unsigned vcore_hw_mode:1;
u8 mask1, mask2;
+ u8 ack1, ack2;
+
void (*handlers[16])(struct menelaus_chip *);
void (*mmc_callback)(void *data, u8 mask);
void *mmc_callback_data;
+
+ unsigned mask1_pending:1;
+ unsigned mask2_pending:1;
+ unsigned ack1_pending:1;
+ unsigned ack2_pending:1;
};
static struct menelaus_chip *the_menelaus;
@@ -235,6 +245,83 @@ static int menelaus_ack_irq(struct menelaus_chip *m, int irq)
return menelaus_write_reg(m, MENELAUS_INT_ACK1, 1 << irq);
}
+static void menelaus_irq_ack(struct irq_data *data)
+{
+ struct menelaus_chip *m = irq_data_get_irq_chip_data(data);
+ int irq = data->irq - m->irq_base;
+
+ if (irq > 7) {
+ m->ack2 |= BIT(irq);
+ m->ack2_pending = true;
+ } else {
+ m->ack1 |= BIT(irq);
+ m->ack1_pending = true;
+ }
+}
+
+static void menelaus_irq_mask(struct irq_data *data)
+{
+ struct menelaus_chip *m = irq_data_get_irq_chip_data(data);
+ int irq = data->irq - m->irq_base;
+
+ if (irq > 7) {
+ m->mask2 |= BIT(irq);
+ m->mask2_pending = true;
+ } else {
+ m->mask1 |= BIT(irq);
+ m->mask1_pending = true;
+ }
+}
+
+static void menelaus_irq_unmask(struct irq_data *data)
+{
+ struct menelaus_chip *m = irq_data_get_irq_chip_data(data);
+ int irq = data->irq - m->irq_base;
+
+ if (irq > 7) {
+ m->mask2 &= ~BIT(irq);
+ m->mask2_pending = true;
+ } else {
+ m->mask1 &= ~BIT(irq);
+ m->mask1_pending = true;
+ }
+}
+
+static void menelaus_irq_bus_lock(struct irq_data *data)
+{
+ struct menelaus_chip *m = irq_data_get_irq_chip_data(data);
+
+ mutex_lock(&m->lock);
+}
+
+static void menelaus_irq_bus_sync_unlock(struct irq_data *data)
+{
+ struct menelaus_chip *m = irq_data_get_irq_chip_data(data);
+
+ if (m->ack1_pending)
+ menelaus_write_reg(m, MENELAUS_INT_ACK1, m->ack1);
+
+ if (m->ack2_pending)
+ menelaus_write_reg(m, MENELAUS_INT_ACK2, m->ack2);
+
+ if (m->mask1_pending)
+ menelaus_write_reg(m, MENELAUS_INT_MASK1, m->mask1);
+
+ if (m->mask2_pending)
+ menelaus_write_reg(m, MENELAUS_INT_MASK2, m->mask2);
+
+ mutex_unlock(&m->lock);
+}
+
+static struct irq_chip menelaus_irq_chip = {
+ .name = "menelaus",
+ .irq_ack = menelaus_irq_ack,
+ .irq_mask = menelaus_irq_mask,
+ .irq_unmask = menelaus_irq_unmask,
+ .irq_bus_lock = menelaus_irq_bus_lock,
+ .irq_bus_sync_unlock = menelaus_irq_bus_sync_unlock,
+};
+
/* Adds a handler for an interrupt. Does not run in interrupt context */
static int menelaus_add_irq_work(struct menelaus_chip *m, int irq,
void (*handler)(struct menelaus_chip *))
@@ -1186,8 +1273,11 @@ static int menelaus_probe(struct i2c_client *client,
const struct i2c_device_id *id)
{
struct menelaus_chip *m;
+ struct device_node *node = client->dev.of_node;
int rev = 0, val;
int err = 0;
+ int irq_base;
+ int i;
struct menelaus_platform_data *menelaus_pdata =
dev_get_platdata(&client->dev);
@@ -1206,6 +1296,25 @@ static int menelaus_probe(struct i2c_client *client,
the_menelaus = m;
m->client = client;
+ irq_base = irq_alloc_descs(-1, 0, MENELAUS_NR_IRQS, 0);
+ if (irq_base < 0) {
+ dev_err(&client->dev, "failed to allocate irq descs\n");
+ return irq_base;
+ }
+
+ irq_domain_add_legacy(node, MENELAUS_NR_IRQS, irq_base, 0,
+ &irq_domain_simple_ops, m);
+
+ m->irq_base = irq_base;
+
+ for (i = irq_base; i < irq_base + MENELAUS_NR_IRQS; i++) {
+ irq_set_chip_and_handler(i, &menelaus_irq_chip,
+ handle_simple_irq);
+ irq_set_nested_thread(i, 1);
+ irq_set_chip_data(i, m);
+ set_irq_flags(i, IRQF_VALID);
+ }
+
/* If a true probe check the device */
rev = menelaus_read_reg(m, MENELAUS_REV);
if (rev < 0) {
--
1.8.4.GIT
next prev parent reply other threads:[~2013-11-27 19:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 19:06 [PATCH 00/13] mfd: menelaus: a few cleanups Felipe Balbi
2013-11-27 19:06 ` [PATCH 01/13] mfd: menelaus: drop __exit section annotation Felipe Balbi
2013-11-27 19:06 ` [PATCH 02/13] mfd: menelaus: switch over to module_i2c_driver Felipe Balbi
2013-11-27 19:06 ` [PATCH 03/13] mfd: menelaus: convert to threaded irq Felipe Balbi
2013-11-27 19:06 ` [PATCH 04/13] mfd: menelaus: remove unnecessary loop Felipe Balbi
2013-11-27 19:06 ` [PATCH 05/13] mfd: menelaus: use for_each_set_bit() Felipe Balbi
2013-11-27 19:06 ` [PATCH 06/13] mfd: menelaus: pass menelaus pointer as argument to enable/disable irq Felipe Balbi
2013-11-27 19:06 ` [PATCH 07/13] mfd: menelaus: limit the usage of the_menelaus Felipe Balbi
2013-11-27 19:06 ` [PATCH 08/13] mfd: menelaus: pass menelaus_chip pointer to add/remove irq functions Felipe Balbi
2013-11-27 19:06 ` [PATCH 09/13] mfd: menelaus: pass menelaus_chip pointer to get/set voltage Felipe Balbi
2013-11-27 19:06 ` [PATCH 10/13] mfd: menelaus: pass menelaus_chip argument to menelaus <-> time helpers Felipe Balbi
2013-11-27 19:06 ` Felipe Balbi [this message]
2013-11-27 19:06 ` [PATCH 12/13] mfd: menelaus: switch all children to threaded_irq Felipe Balbi
2013-11-27 19:06 ` [PATCH 13/13] mfd: menelaus: remove unnecessary definition Felipe Balbi
2013-11-27 20:02 ` [PATCH 00/13] mfd: menelaus: a few cleanups Aaro Koskinen
2013-11-27 20:11 ` Felipe Balbi
2013-11-27 20:46 ` Aaro Koskinen
2013-11-28 3:00 ` Felipe Balbi
2013-11-28 9:32 ` Lee Jones
2013-11-28 21:34 ` Aaro Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385579217-20127-12-git-send-email-balbi@ti.com \
--to=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).