linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ivan.lam2014@gmail.com (ivan lam)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm/crash_dump.c: fix Oops caused by overflow converted from pfn to phys
Date: Sun,  1 Dec 2013 16:32:09 +0800	[thread overview]
Message-ID: <1385886729-27190-1-git-send-email-ivan.lam2014@gmail.com> (raw)

In Cortex-A9 machine, with LPAE feature enabled and physical address space
larger than 4G, Capture kernel will Oops on reading the /proc/vmcore file.

In copy_oldmem_page function, it simply use "pfn << PAGE_SHIFT" to get
the physical address, but this will cause overflow when LPAE enabled and
physical address space is larger than 4G, thus get the result as 0 and
cause Oops.

Fix it to use __pfn_to_phys instead. __pfn_to_phys will first cast the pfn
to type phys_addr_t which is the type u64 when LPAE enabled, and left shifted
by PAGE_SHIFT to get the proper physical address.

Signed-off-by: ivan lam <ivan.lam2014@gmail.com>
---
 arch/arm/kernel/crash_dump.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/kernel/crash_dump.c b/arch/arm/kernel/crash_dump.c
index 90c50d4..5d1286d 100644
--- a/arch/arm/kernel/crash_dump.c
+++ b/arch/arm/kernel/crash_dump.c
@@ -39,7 +39,7 @@ ssize_t copy_oldmem_page(unsigned long pfn, char *buf,
 	if (!csize)
 		return 0;
 
-	vaddr = ioremap(pfn << PAGE_SHIFT, PAGE_SIZE);
+	vaddr = ioremap(__pfn_to_phys(pfn), PAGE_SIZE);
 	if (!vaddr)
 		return -ENOMEM;
 
-- 
1.7.9.5

                 reply	other threads:[~2013-12-01  8:32 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385886729-27190-1-git-send-email-ivan.lam2014@gmail.com \
    --to=ivan.lam2014@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).