linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] ARM: dts: Add missing clock names for exynos4412 dwmmc node
@ 2013-12-01 10:11 Alex Ling
  2013-12-02  9:52 ` Mark Rutland
  0 siblings, 1 reply; 3+ messages in thread
From: Alex Ling @ 2013-12-01 10:11 UTC (permalink / raw)
  To: linux-arm-kernel

This patch adds "biu" and "ciu" clock names for exynos4412 dwmmc
node. Without this patch, dwmmc host driver will skip enabling the
two clocks and it will break dwmmc host function on exynos4412.
Tested on FriendlyARM TINY4412 board.

Signed-off-by: Alex Ling <kasimling@gmail.com>
---
 arch/arm/boot/dts/exynos4412.dtsi |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi
index e743e67..67bef99 100644
--- a/arch/arm/boot/dts/exynos4412.dtsi
+++ b/arch/arm/boot/dts/exynos4412.dtsi
@@ -67,5 +67,7 @@
 		interrupts = <0 77 0>;
 		#address-cells = <1>;
 		#size-cells = <0>;
+		clocks = <&clock 301>, <&clock 149>;
+		clock-names = "biu", "ciu";
 	};
 };
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 1/1] ARM: dts: Add missing clock names for exynos4412 dwmmc node
  2013-12-01 10:11 [PATCH 1/1] ARM: dts: Add missing clock names for exynos4412 dwmmc node Alex Ling
@ 2013-12-02  9:52 ` Mark Rutland
  2013-12-02 14:01   ` Alex Ling
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Rutland @ 2013-12-02  9:52 UTC (permalink / raw)
  To: linux-arm-kernel

On Sun, Dec 01, 2013 at 10:11:47AM +0000, Alex Ling wrote:
> This patch adds "biu" and "ciu" clock names for exynos4412 dwmmc
> node. Without this patch, dwmmc host driver will skip enabling the
> two clocks and it will break dwmmc host function on exynos4412.
> Tested on FriendlyARM TINY4412 board.

The patch description is a little off; this patch adds the clocks as
well as the clock-names.

The patch itself looks fine to me.

Mark.

> 
> Signed-off-by: Alex Ling <kasimling@gmail.com>
> ---
>  arch/arm/boot/dts/exynos4412.dtsi |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi
> index e743e67..67bef99 100644
> --- a/arch/arm/boot/dts/exynos4412.dtsi
> +++ b/arch/arm/boot/dts/exynos4412.dtsi
> @@ -67,5 +67,7 @@
>  		interrupts = <0 77 0>;
>  		#address-cells = <1>;
>  		#size-cells = <0>;
> +		clocks = <&clock 301>, <&clock 149>;
> +		clock-names = "biu", "ciu";
>  	};
>  };
> -- 
> 1.7.9.5
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/1] ARM: dts: Add missing clock names for exynos4412 dwmmc node
  2013-12-02  9:52 ` Mark Rutland
@ 2013-12-02 14:01   ` Alex Ling
  0 siblings, 0 replies; 3+ messages in thread
From: Alex Ling @ 2013-12-02 14:01 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Dec 2, 2013 at 5:52 PM, Mark Rutland <mark.rutland@arm.com> wrote:
> On Sun, Dec 01, 2013 at 10:11:47AM +0000, Alex Ling wrote:
>> This patch adds "biu" and "ciu" clock names for exynos4412 dwmmc
>> node. Without this patch, dwmmc host driver will skip enabling the
>> two clocks and it will break dwmmc host function on exynos4412.
>> Tested on FriendlyARM TINY4412 board.
>
> The patch description is a little off; this patch adds the clocks as
> well as the clock-names.
Well noted. I'll update the description later. Thanks!
>
> The patch itself looks fine to me.
>
> Mark.
>
>>
>> Signed-off-by: Alex Ling <kasimling@gmail.com>
>> ---
>>  arch/arm/boot/dts/exynos4412.dtsi |    2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi
>> index e743e67..67bef99 100644
>> --- a/arch/arm/boot/dts/exynos4412.dtsi
>> +++ b/arch/arm/boot/dts/exynos4412.dtsi
>> @@ -67,5 +67,7 @@
>>               interrupts = <0 77 0>;
>>               #address-cells = <1>;
>>               #size-cells = <0>;
>> +             clocks = <&clock 301>, <&clock 149>;
>> +             clock-names = "biu", "ciu";
>>       };
>>  };
>> --
>> 1.7.9.5
>>
>>

BR,
Alex

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-12-02 14:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-01 10:11 [PATCH 1/1] ARM: dts: Add missing clock names for exynos4412 dwmmc node Alex Ling
2013-12-02  9:52 ` Mark Rutland
2013-12-02 14:01   ` Alex Ling

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).