linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] crypto: Fully restore ahash request before completing
Date: Sun,  1 Dec 2013 22:20:19 +0100	[thread overview]
Message-ID: <1385932823-3860-1-git-send-email-marex@denx.de> (raw)

When finishing the ahash request, the ahash_op_unaligned_done() will
call complete() on the request. Yet, this will not call the correct
complete callback. The correct complete callback was previously stored
in the requests' private data, as seen in ahash_op_unaligned(). This
patch restores the correct complete callback and .data field of the
request before calling complete() on it.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David S. Miller <davem@davemloft.net>
Cc: Fabio Estevam <fabio.estevam@freescale.com>
Cc: Shawn Guo <shawn.guo@linaro.org>
Cc: linux-crypto at vger.kernel.org
---
 crypto/ahash.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/crypto/ahash.c b/crypto/ahash.c
index 793a27f..a92dc38 100644
--- a/crypto/ahash.c
+++ b/crypto/ahash.c
@@ -213,7 +213,10 @@ static void ahash_op_unaligned_done(struct crypto_async_request *req, int err)
 
 	ahash_op_unaligned_finish(areq, err);
 
-	complete(data, err);
+	areq->base.complete = complete;
+	areq->base.data = data;
+
+	complete(&areq->base, err);
 }
 
 static int ahash_op_unaligned(struct ahash_request *req,
-- 
1.8.4.2

             reply	other threads:[~2013-12-01 21:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-01 21:20 Marek Vasut [this message]
2013-12-01 21:20 ` [PATCH 2/5] ARM: mxs: crypto: Remove the old DCP driver Marek Vasut
2013-12-03 11:07   ` Shawn Guo
2013-12-03 12:28     ` Marek Vasut
2013-12-01 21:20 ` [PATCH V2 3/5] ARM: mxs: crypto: Add Freescale MXS " Marek Vasut
2013-12-03 11:10   ` Shawn Guo
2013-12-10 19:19     ` Marek Vasut
2013-12-01 21:20 ` [PATCH 4/5] ARM: mxs: dts: Enable DCP for MXS Marek Vasut
2013-12-01 21:20 ` [PATCH 5/5] crypto: Sort drivers/crypto/Makefile Marek Vasut
  -- strict thread matches above, loose matches on Subject: below --
2013-12-10 19:26 [PATCH 1/5] crypto: Fully restore ahash request before completing Marek Vasut
2013-12-20 12:04 ` Herbert Xu
2013-12-27  0:21   ` Marek Vasut
2013-12-30  9:01     ` Herbert Xu
2014-01-03 15:10       ` Tom Lendacky
2014-01-03 22:33         ` Herbert Xu
2014-01-04  7:20           ` Marek Vasut
2014-01-05 13:05 ` Herbert Xu
2014-01-05 15:33   ` Marek Vasut
2014-01-05 23:29     ` Herbert Xu
2014-01-14 17:34       ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1385932823-3860-1-git-send-email-marex@denx.de \
    --to=marex@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).