* [PATCH] ARM: at91: add usart3 alias to dtsi
@ 2013-12-02 10:13 Nicolas Ferre
2013-12-02 11:36 ` boris brezillon
2013-12-02 12:53 ` [PATCH v2] " Nicolas Ferre
0 siblings, 2 replies; 5+ messages in thread
From: Nicolas Ferre @ 2013-12-02 10:13 UTC (permalink / raw)
To: linux-arm-kernel
Alias was missing for SoC of the at91sam9x5 familly that embed USART3.
Preripheral node and pinctrl declarations are already in the
at91sam9x5_usart3.dtsi file.
Reported-by: Jiri Prchal <jiri.prchal@aksignal.cz>
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
arch/arm/boot/dts/at91sam9g25.dtsi | 4 ++++
arch/arm/boot/dts/at91sam9x25.dtsi | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/at91sam9g25.dtsi b/arch/arm/boot/dts/at91sam9g25.dtsi
index 17b879990914..d4650b4e9ebb 100644
--- a/arch/arm/boot/dts/at91sam9g25.dtsi
+++ b/arch/arm/boot/dts/at91sam9g25.dtsi
@@ -14,6 +14,10 @@
model = "Atmel AT91SAM9G25 SoC";
compatible = "atmel,at91sam9g25", "atmel,at91sam9x5";
+ aliases {
+ serial4 = &usart3;
+ };
+
ahb {
apb {
pinctrl at fffff400 {
diff --git a/arch/arm/boot/dts/at91sam9x25.dtsi b/arch/arm/boot/dts/at91sam9x25.dtsi
index c2554219f7a4..aceee86f60eb 100644
--- a/arch/arm/boot/dts/at91sam9x25.dtsi
+++ b/arch/arm/boot/dts/at91sam9x25.dtsi
@@ -15,6 +15,10 @@
model = "Atmel AT91SAM9X25 SoC";
compatible = "atmel,at91sam9x25", "atmel,at91sam9x5";
+ aliases {
+ serial4 = &usart3;
+ };
+
ahb {
apb {
pinctrl at fffff400 {
--
1.8.2.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] ARM: at91: add usart3 alias to dtsi
2013-12-02 10:13 [PATCH] ARM: at91: add usart3 alias to dtsi Nicolas Ferre
@ 2013-12-02 11:36 ` boris brezillon
2013-12-02 12:47 ` Nicolas Ferre
2013-12-02 12:53 ` [PATCH v2] " Nicolas Ferre
1 sibling, 1 reply; 5+ messages in thread
From: boris brezillon @ 2013-12-02 11:36 UTC (permalink / raw)
To: linux-arm-kernel
Hi Nicolas,
Le 02/12/2013 11:13, Nicolas Ferre a ?crit :
> Alias was missing for SoC of the at91sam9x5 familly that embed USART3.
> Preripheral node and pinctrl declarations are already in the
> at91sam9x5_usart3.dtsi file.
>
> Reported-by: Jiri Prchal <jiri.prchal@aksignal.cz>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> arch/arm/boot/dts/at91sam9g25.dtsi | 4 ++++
> arch/arm/boot/dts/at91sam9x25.dtsi | 4 ++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/at91sam9g25.dtsi b/arch/arm/boot/dts/at91sam9g25.dtsi
> index 17b879990914..d4650b4e9ebb 100644
> --- a/arch/arm/boot/dts/at91sam9g25.dtsi
> +++ b/arch/arm/boot/dts/at91sam9g25.dtsi
> @@ -14,6 +14,10 @@
> model = "Atmel AT91SAM9G25 SoC";
> compatible = "atmel,at91sam9g25", "atmel,at91sam9x5";
>
> + aliases {
> + serial4 = &usart3;
> + };
> +
Shouldn't this go into at91sam9x5_usart3.dtsi ?
This way you would have the same alias for all the SoCs supporting usart3.
Best Regards,
Boris
> ahb {
> apb {
> pinctrl at fffff400 {
> diff --git a/arch/arm/boot/dts/at91sam9x25.dtsi b/arch/arm/boot/dts/at91sam9x25.dtsi
> index c2554219f7a4..aceee86f60eb 100644
> --- a/arch/arm/boot/dts/at91sam9x25.dtsi
> +++ b/arch/arm/boot/dts/at91sam9x25.dtsi
> @@ -15,6 +15,10 @@
> model = "Atmel AT91SAM9X25 SoC";
> compatible = "atmel,at91sam9x25", "atmel,at91sam9x5";
>
> + aliases {
> + serial4 = &usart3;
> + };
> +
> ahb {
> apb {
> pinctrl at fffff400 {
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] ARM: at91: add usart3 alias to dtsi
2013-12-02 11:36 ` boris brezillon
@ 2013-12-02 12:47 ` Nicolas Ferre
0 siblings, 0 replies; 5+ messages in thread
From: Nicolas Ferre @ 2013-12-02 12:47 UTC (permalink / raw)
To: linux-arm-kernel
On 02/12/2013 12:36, boris brezillon :
> Hi Nicolas,
>
> Le 02/12/2013 11:13, Nicolas Ferre a ?crit :
>> Alias was missing for SoC of the at91sam9x5 familly that embed USART3.
>> Preripheral node and pinctrl declarations are already in the
>> at91sam9x5_usart3.dtsi file.
>>
>> Reported-by: Jiri Prchal <jiri.prchal@aksignal.cz>
>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>> ---
>> arch/arm/boot/dts/at91sam9g25.dtsi | 4 ++++
>> arch/arm/boot/dts/at91sam9x25.dtsi | 4 ++++
>> 2 files changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/at91sam9g25.dtsi b/arch/arm/boot/dts/at91sam9g25.dtsi
>> index 17b879990914..d4650b4e9ebb 100644
>> --- a/arch/arm/boot/dts/at91sam9g25.dtsi
>> +++ b/arch/arm/boot/dts/at91sam9g25.dtsi
>> @@ -14,6 +14,10 @@
>> model = "Atmel AT91SAM9G25 SoC";
>> compatible = "atmel,at91sam9g25", "atmel,at91sam9x5";
>>
>> + aliases {
>> + serial4 = &usart3;
>> + };
>> +
>
> Shouldn't this go into at91sam9x5_usart3.dtsi ?
> This way you would have the same alias for all the SoCs supporting usart3.
Indeed, I was focused on the product itself but it definitively makes
sense to move it in the at91sam9x5_usart3.dtsi
Thanks, bye,
>> ahb {
>> apb {
>> pinctrl at fffff400 {
>> diff --git a/arch/arm/boot/dts/at91sam9x25.dtsi b/arch/arm/boot/dts/at91sam9x25.dtsi
>> index c2554219f7a4..aceee86f60eb 100644
>> --- a/arch/arm/boot/dts/at91sam9x25.dtsi
>> +++ b/arch/arm/boot/dts/at91sam9x25.dtsi
>> @@ -15,6 +15,10 @@
>> model = "Atmel AT91SAM9X25 SoC";
>> compatible = "atmel,at91sam9x25", "atmel,at91sam9x5";
>>
>> + aliases {
>> + serial4 = &usart3;
>> + };
>> +
>> ahb {
>> apb {
>> pinctrl at fffff400 {
>
>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] ARM: at91: add usart3 alias to dtsi
2013-12-02 10:13 [PATCH] ARM: at91: add usart3 alias to dtsi Nicolas Ferre
2013-12-02 11:36 ` boris brezillon
@ 2013-12-02 12:53 ` Nicolas Ferre
2013-12-02 12:55 ` boris brezillon
1 sibling, 1 reply; 5+ messages in thread
From: Nicolas Ferre @ 2013-12-02 12:53 UTC (permalink / raw)
To: linux-arm-kernel
Alias was missing for SoC of the at91sam9x5 familly that embed USART3.
Reported-by: Jiri Prchal <jiri.prchal@aksignal.cz>
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Boris Brezillon <b.brezillon@overkiz.com>
---
arch/arm/boot/dts/at91sam9x5_usart3.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/at91sam9x5_usart3.dtsi b/arch/arm/boot/dts/at91sam9x5_usart3.dtsi
index 2347e9563cef..6801106fa1f8 100644
--- a/arch/arm/boot/dts/at91sam9x5_usart3.dtsi
+++ b/arch/arm/boot/dts/at91sam9x5_usart3.dtsi
@@ -11,6 +11,10 @@
#include <dt-bindings/interrupt-controller/irq.h>
/ {
+ aliases {
+ serial4 = &usart3;
+ };
+
ahb {
apb {
pinctrl at fffff400 {
--
1.8.2.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v2] ARM: at91: add usart3 alias to dtsi
2013-12-02 12:53 ` [PATCH v2] " Nicolas Ferre
@ 2013-12-02 12:55 ` boris brezillon
0 siblings, 0 replies; 5+ messages in thread
From: boris brezillon @ 2013-12-02 12:55 UTC (permalink / raw)
To: linux-arm-kernel
On 02/12/2013 13:53, Nicolas Ferre wrote:
> Alias was missing for SoC of the at91sam9x5 familly that embed USART3.
Acked-by: Boris BREZILLON <b.brezillon@overkiz.com>
>
> Reported-by: Jiri Prchal <jiri.prchal@aksignal.cz>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> Cc: Boris Brezillon <b.brezillon@overkiz.com>
> ---
> arch/arm/boot/dts/at91sam9x5_usart3.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/at91sam9x5_usart3.dtsi b/arch/arm/boot/dts/at91sam9x5_usart3.dtsi
> index 2347e9563cef..6801106fa1f8 100644
> --- a/arch/arm/boot/dts/at91sam9x5_usart3.dtsi
> +++ b/arch/arm/boot/dts/at91sam9x5_usart3.dtsi
> @@ -11,6 +11,10 @@
> #include <dt-bindings/interrupt-controller/irq.h>
>
> / {
> + aliases {
> + serial4 = &usart3;
> + };
> +
> ahb {
> apb {
> pinctrl at fffff400 {
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-12-02 12:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-02 10:13 [PATCH] ARM: at91: add usart3 alias to dtsi Nicolas Ferre
2013-12-02 11:36 ` boris brezillon
2013-12-02 12:47 ` Nicolas Ferre
2013-12-02 12:53 ` [PATCH v2] " Nicolas Ferre
2013-12-02 12:55 ` boris brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).