From: al.stone@linaro.org (al.stone at linaro.org)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/5] ACPI: in HW reduced mode, using FADT PM information is not allowed.
Date: Wed, 4 Dec 2013 14:22:06 -0700 [thread overview]
Message-ID: <1386192127-28564-5-git-send-email-al.stone@linaro.org> (raw)
In-Reply-To: <1386192127-28564-1-git-send-email-al.stone@linaro.org>
From: Al Stone <al.stone@linaro.org>
Per the ACPI 5.0 specification, section 5.2.9, none of the power
management fields in the FADT are to be used. Short-circuit using
any of those fields in acpi_processor_get_power_info_fadt().
Signed-off-by: Al Stone <al.stone@linaro.org>
---
drivers/acpi/processor_idle.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
index 8b48c08..a419fcb 100644
--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -271,6 +271,14 @@ static int acpi_processor_get_power_info_fadt(struct acpi_processor *pr)
if (!pr->pblk)
return -ENODEV;
+ /*
+ * Using power management information from the FADT is not
+ * allowed when in HW reduced mode. See ACPI 5.0, section
+ * 5.2.9.
+ */
+ if (acpi_gbl_reduced_hardware)
+ return -ENODEV;
+
/* if info is obtained from pblk/fadt, type equals state */
pr->power.states[ACPI_STATE_C2].type = ACPI_STATE_C2;
pr->power.states[ACPI_STATE_C3].type = ACPI_STATE_C3;
--
1.8.3.1
next prev parent reply other threads:[~2013-12-04 21:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 21:22 [PATCH v3 0/5] Hardware Reduced Mode Cleanup for ACPI al.stone at linaro.org
[not found] ` < 1386192127-28564-2-git-send-email-al.stone@linaro.org>
2013-12-04 21:22 ` [PATCH v3 1/5] ACPI: introduce CONFIG_ACPI_REDUCED_HARDWARE to enable this ACPI mode al.stone at linaro.org
2013-12-10 12:35 ` [Linaro-acpi] " Grant Likely
2013-12-10 12:37 ` Grant Likely
2013-12-10 15:05 ` Hanjun Guo
2013-12-10 22:49 ` Grant Likely
2013-12-11 2:06 ` Rob Herring
2013-12-11 8:33 ` Graeme Gregory
2013-12-12 20:31 ` Al Stone
2013-12-04 21:22 ` [PATCH v3 2/5] ACPI: bus master reload not supported in reduced HW mode al.stone at linaro.org
2013-12-10 12:38 ` [Linaro-acpi] " Grant Likely
2013-12-04 21:22 ` [PATCH v3 3/5] ACPI: HW reduced mode does not allow use of the FADT sci_interrupt field al.stone at linaro.org
2013-12-04 21:22 ` al.stone at linaro.org [this message]
2013-12-04 21:22 ` [PATCH v3 5/5] ACPI: do not map/unmap memory regions for FADT entries in reduced HW mode al.stone at linaro.org
2013-12-10 12:40 ` [Linaro-acpi] " Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386192127-28564-5-git-send-email-al.stone@linaro.org \
--to=al.stone@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).