linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tim.kryger@linaro.org (Tim Kryger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 5/8] mmc: sdhci-bcm-kona: Add basic use of clocks
Date: Thu, 5 Dec 2013 11:20:41 -0800	[thread overview]
Message-ID: <1386271244-3927-6-git-send-email-tim.kryger@linaro.org> (raw)
In-Reply-To: <1386271244-3927-1-git-send-email-tim.kryger@linaro.org>

Enable the external clock needed by the host controller during the
probe and disable it during the remove.

Signed-off-by: Tim Kryger <tim.kryger@linaro.org>
Reviewed-by: Markus Mayer <markus.mayer@linaro.org>
Reviewed-by: Matt Porter <matt.porter@linaro.org>
---
 drivers/mmc/host/sdhci-bcm-kona.c | 37 +++++++++++++++++++++++++++++++++++--
 1 file changed, 35 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c
index 7a190fe..923eefa 100644
--- a/drivers/mmc/host/sdhci-bcm-kona.c
+++ b/drivers/mmc/host/sdhci-bcm-kona.c
@@ -54,6 +54,7 @@
 
 struct sdhci_bcm_kona_dev {
 	struct mutex	write_lock; /* protect back to back writes */
+	struct clk	*external_clk;
 };
 
 
@@ -257,6 +258,24 @@ static int sdhci_bcm_kona_probe(struct platform_device *pdev)
 		goto err_pltfm_free;
 	}
 
+	/* Get and enable the external clock */
+	kona_dev->external_clk = devm_clk_get(dev, NULL);
+	if (IS_ERR(kona_dev->external_clk)) {
+		dev_err(dev, "Failed to get external clock\n");
+		ret = PTR_ERR(kona_dev->external_clk);
+		goto err_pltfm_free;
+	}
+
+	if (clk_set_rate(kona_dev->external_clk, host->mmc->f_max) != 0) {
+		dev_err(dev, "Failed to set rate external clock\n");
+		goto err_pltfm_free;
+	}
+
+	if (clk_prepare_enable(kona_dev->external_clk) != 0) {
+		dev_err(dev, "Failed to enable external clock\n");
+		goto err_pltfm_free;
+	}
+
 	dev_dbg(dev, "non-removable=%c\n",
 		(host->mmc->caps & MMC_CAP_NONREMOVABLE) ? 'Y' : 'N');
 	dev_dbg(dev, "cd_gpio %c, wp_gpio %c\n",
@@ -271,7 +290,7 @@ static int sdhci_bcm_kona_probe(struct platform_device *pdev)
 
 	ret = sdhci_bcm_kona_sd_reset(host);
 	if (ret)
-		goto err_pltfm_free;
+		goto err_clk_disable;
 
 	sdhci_bcm_kona_sd_init(host);
 
@@ -307,6 +326,9 @@ err_remove_host:
 err_reset:
 	sdhci_bcm_kona_sd_reset(host);
 
+err_clk_disable:
+	clk_disable_unprepare(kona_dev->external_clk);
+
 err_pltfm_free:
 	sdhci_pltfm_free(pdev);
 
@@ -316,7 +338,18 @@ err_pltfm_free:
 
 static int __exit sdhci_bcm_kona_remove(struct platform_device *pdev)
 {
-	return sdhci_pltfm_unregister(pdev);
+	struct sdhci_host *host = platform_get_drvdata(pdev);
+	struct sdhci_pltfm_host *pltfm_priv = sdhci_priv(host);
+	struct sdhci_bcm_kona_dev *kona_dev = sdhci_pltfm_priv(pltfm_priv);
+	int dead = (readl(host->ioaddr + SDHCI_INT_STATUS) == 0xffffffff);
+
+	sdhci_remove_host(host, dead);
+
+	clk_disable_unprepare(kona_dev->external_clk);
+
+	sdhci_pltfm_free(pdev);
+
+	return 0;
 }
 
 static struct platform_driver sdhci_bcm_kona_driver = {
-- 
1.8.0.1

  parent reply	other threads:[~2013-12-05 19:20 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-05 19:20 [PATCH v4 0/8] Update Kona drivers to use clocks Tim Kryger
2013-12-05 19:20 ` [PATCH v4 1/8] ARM: dts: Declare clocks as fixed on bcm11351 Tim Kryger
2013-12-10  7:18   ` Christian Daudt
2013-12-10 20:26     ` Tim Kryger
2013-12-13  7:48       ` Christian Daudt
2013-12-13 15:56         ` Tim Kryger
2013-12-05 19:20 ` [PATCH v4 2/8] ARM: dts: Specify clocks for UARTs " Tim Kryger
2013-12-13  7:56   ` Christian Daudt
2013-12-05 19:20 ` [PATCH v4 3/8] Documentation: dt: kona-sdhci: Add clocks property Tim Kryger
2013-12-13  8:02   ` Christian Daudt
2013-12-05 19:20 ` [PATCH v4 4/8] ARM: dts: Specify clocks for SDHCIs on bcm11351 Tim Kryger
2013-12-13  8:22   ` Christian Daudt
2013-12-05 19:20 ` Tim Kryger [this message]
2013-12-14  8:14   ` [PATCH v4 5/8] mmc: sdhci-bcm-kona: Add basic use of clocks Christian Daudt
2013-12-23  8:26     ` Christian Daudt
2014-01-07 19:37     ` Tim Kryger
2014-01-24 17:07       ` Tim Kryger
2014-02-24 19:33         ` Matt Porter
2014-02-24 19:40           ` Chris Ball
2013-12-05 19:20 ` [PATCH v4 6/8] Documentation: dt: kona-timer: Add clocks property Tim Kryger
2013-12-14  8:19   ` Christian Daudt
2013-12-05 19:20 ` [PATCH v4 7/8] clocksource: kona: Add basic use of external clock Tim Kryger
2013-12-14  8:26   ` Christian Daudt
2013-12-16 10:34   ` Daniel Lezcano
2013-12-05 19:20 ` [PATCH v4 8/8] ARM: dts: Specify clocks for timer on bcm11351 Tim Kryger
2013-12-13  8:06   ` Christian Daudt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386271244-3927-6-git-send-email-tim.kryger@linaro.org \
    --to=tim.kryger@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).