From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] rtc: pxa: drop unused #define TIMER_FREQ
Date: Sat, 7 Dec 2013 23:30:49 +0100 [thread overview]
Message-ID: <1386455449-19678-1-git-send-email-u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <87mwkc77d8.fsf@free.fr>
It seems this symbol was unused since the driver was introduced in
commit dc94436 (rtc: driver for pxa27x and pxa3xx SoC) back in 2009.
As a by-product this patch makes the driver stop "using" the symbol
CLOCK_TICK_RATE which is about to be removed very soon (for ARM).
Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
---
Changes since (implicit) v1, sent with
Message-id:1383942318-12569-1-git-send-email-u.kleine-koenig at pengutronix.de:
- drop define instead of s/CLOCK_TICK_RATE/get_clock_tick_rate()/; thanks to
Robert Jarzmik for pointing that out.
Note I intend to send this patch as part of a series that removes
<mach/timex.h> (and so CLOCK_TICK_RATE) on ARM. So dear maintainer please don't
take this patch but give your blessing that I can take it. (Note, I'm not sure
who's ack I need here; according to MAINTAINERS Alessandro Zummo maintains the
rtc subsystem, but he doesn't seem to be that active for some time and it's
mostly akpm who takes patches.)
drivers/rtc/rtc-pxa.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/rtc/rtc-pxa.c b/drivers/rtc/rtc-pxa.c
index a355f2b..cccbf9d 100644
--- a/drivers/rtc/rtc-pxa.c
+++ b/drivers/rtc/rtc-pxa.c
@@ -32,7 +32,6 @@
#include <mach/hardware.h>
-#define TIMER_FREQ CLOCK_TICK_RATE
#define RTC_DEF_DIVIDER (32768 - 1)
#define RTC_DEF_TRIM 0
#define MAXFREQ_PERIODIC 1000
--
1.8.4.3
next prev parent reply other threads:[~2013-12-07 22:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 20:25 [PATCH] rtc: pxa: drop usage of CLOCK_TICK_RATE Uwe Kleine-König
2013-11-13 5:37 ` Haojian Zhuang
2013-11-26 13:37 ` Uwe Kleine-König
2013-11-27 1:26 ` Haojian Zhuang
2013-12-07 20:07 ` Robert Jarzmik
2013-12-07 22:30 ` Uwe Kleine-König [this message]
2013-12-08 10:45 ` [PATCH v2] rtc: pxa: drop unused #define TIMER_FREQ Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386455449-19678-1-git-send-email-u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).