linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ivan.khoronzhuk@ti.com (Ivan Khoronzhuk)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/9] mtd: nand: davinci: return ENOMEM if memory allocation is failed
Date: Tue, 17 Dec 2013 15:36:05 +0200	[thread overview]
Message-ID: <1387287365-19731-1-git-send-email-ivan.khoronzhuk@ti.com> (raw)
In-Reply-To: <1387285155-19182-1-git-send-email-ivan.khoronzhuk@ti.com>

In case when memory allocation is failed the driver should return
ENOMEM instead of ENODEV.

Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
Reviewed-by: Taras Kondratiuk <taras@ti.com>
Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
---
 drivers/mtd/nand/davinci_nand.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
index 584c1f4..4577fb4 100644
--- a/drivers/mtd/nand/davinci_nand.c
+++ b/drivers/mtd/nand/davinci_nand.c
@@ -541,7 +541,7 @@ static struct davinci_nand_pdata
 				GFP_KERNEL);
 		pdev->dev.platform_data = pdata;
 		if (!pdata)
-			return NULL;
+			return ERR_PTR(-ENOMEM);
 		if (!of_property_read_u32(pdev->dev.of_node,
 			"ti,davinci-chipselect", &prop))
 			pdev->id = prop;
@@ -598,6 +598,9 @@ static int nand_davinci_probe(struct platform_device *pdev)
 	nand_ecc_modes_t		ecc_mode;
 
 	pdata = nand_davinci_get_pdata(pdev);
+	if (IS_ERR(pdata))
+		return PTR_ERR(pdata);
+
 	/* insist on board-specific configuration */
 	if (!pdata)
 		return -ENODEV;
-- 
1.7.9.5

  parent reply	other threads:[~2013-12-17 13:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-17 12:59 [PATCH v4 0/9] Reuse davinci-nand driver for Keystone arch Ivan Khoronzhuk
2013-12-17 13:33 ` [PATCH v4 1/9] mtd: nand: davinci: fix driver registration Ivan Khoronzhuk
2013-12-17 13:36 ` Ivan Khoronzhuk [this message]
2013-12-17 13:36 ` [PATCH v4 3/9] mtd: nand: davinci: check required ti, davinci-chipselect property Ivan Khoronzhuk
2013-12-17 13:37 ` [PATCH v4 4/9] mtd: nand: davinci: simplify error handling Ivan Khoronzhuk
2013-12-17 13:37 ` [PATCH v4 5/9] mtd: nand: davinci: move bindings under mtd Ivan Khoronzhuk
2013-12-17 13:37 ` [PATCH v4 6/9] mtd: nand: davinci: extend description of bindings Ivan Khoronzhuk
2013-12-17 13:37 ` [PATCH v4 7/9] mtd: nand: davinci: adjust DT properties to MTD generic Ivan Khoronzhuk
2013-12-17 13:38 ` [PATCH v4 8/9] mtd: nand: davinci: reuse driver for Keystone arch Ivan Khoronzhuk
2013-12-17 13:38 ` [PATCH v4 9/9] mtd: nand: davinci: don't request AEMIF address range Ivan Khoronzhuk
2013-12-18  7:14 ` [PATCH v4 0/9] Reuse davinci-nand driver for Keystone arch Brian Norris
2013-12-18 11:09   ` ivan.khoronzhuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387287365-19731-1-git-send-email-ivan.khoronzhuk@ti.com \
    --to=ivan.khoronzhuk@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).