linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mpa@pengutronix.de (Markus Pargmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 5/9] ASoC: fsl-ssi: Add offline_config flag
Date: Wed, 18 Dec 2013 12:57:41 +0100	[thread overview]
Message-ID: <1387367865-26391-6-git-send-email-mpa@pengutronix.de> (raw)
In-Reply-To: <1387367865-26391-1-git-send-email-mpa@pengutronix.de>

imx50-ssi and later versions of this IP support online reconfiguration
of all registers. The reference manual does not list any registers that
can only be configured while the SSI unit is disabled. This patch
introduces the flag for later use.

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
 sound/soc/fsl/fsl_ssi.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index c361730..7a87d06 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -156,6 +156,7 @@ struct fsl_ssi_private {
 	bool imx_ac97;
 	bool use_dma;
 	u8 i2s_mode;
+	bool offline_config;
 	struct clk *clk;
 	struct snd_dmaengine_dai_dma_data dma_params_tx;
 	struct snd_dmaengine_dai_dma_data dma_params_rx;
@@ -979,6 +980,24 @@ static int fsl_ssi_probe(struct platform_device *pdev)
                 /* Older 8610 DTs didn't have the fifo-depth property */
 		ssi_private->fifo_depth = 8;
 
+	/*
+	 * imx51 and later SoCs have a slightly different IP that allows the
+	 * SSI configuration while the SSI unit is running.
+	 *
+	 * More important, it is necessary on those SoCs to configure the
+	 * sperate TX/RX DMA bits just before starting the stream
+	 * (fsl_ssi_trigger). The SDMA unit has to be configured before fsl_ssi
+	 * sends any DMA requests to the SDMA unit, otherwise it is not defined
+	 * how the SDMA unit handles the DMA request.
+	 *
+	 * SDMA units are present on devices starting at imx35 but the imx35
+	 * reference manual states that the DMA bits should not be changed
+	 * while the SSI unit is running (SSIEN). So we support the necessary
+	 * online configuration of fsl-ssi starting at imx51.
+	 */
+	if (hw_type != FSL_SSI_MX51)
+		ssi_private->offline_config = true;
+
 	if (hw_type == FSL_SSI_MX21 || hw_type == FSL_SSI_MX51) {
 		u32 dma_events[2];
 		ssi_private->ssi_on_imx = true;
-- 
1.8.5.1

  parent reply	other threads:[~2013-12-18 11:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-18 11:57 [PATCH v3 0/9] ASoC: fsl-ssi: offline/online configuration and cleanups Markus Pargmann
2013-12-18 11:57 ` [PATCH v3 1/9] ASoC: fsl-ssi: Fix probe error handling Markus Pargmann
2013-12-19 13:03   ` Mark Brown
2013-12-20  9:52     ` Markus Pargmann
2013-12-18 11:57 ` [PATCH v3 2/9] ASoC: fsl-ssi: Move sysfs stats to debugfs Markus Pargmann
2013-12-18 11:57 ` [PATCH v3 3/9] ASoC: fsl-ssi: Add imx51-ssi and of_device_id matching Markus Pargmann
2013-12-18 11:57 ` [PATCH v3 4/9] ASoC: fsl-ssi: Fix interrupt mapping and release Markus Pargmann
2013-12-20  9:05   ` Nicolin Chen
2013-12-20 10:31     ` Markus Pargmann
2013-12-18 11:57 ` Markus Pargmann [this message]
2013-12-19 13:16   ` [PATCH v3 5/9] ASoC: fsl-ssi: Add offline_config flag Mark Brown
2013-12-20 10:08     ` Markus Pargmann
2013-12-18 11:57 ` [PATCH v3 6/9] ASoC: fsl-ssi: Add configuration helper functions Markus Pargmann
2013-12-18 11:57 ` [PATCH v3 7/9] ASoC: fsl-ssi: Move RX/TX configuration to seperate functions Markus Pargmann
2013-12-18 11:57 ` [PATCH v3 8/9] ASoC: fsl-ssi: Drop ac97 specific trigger function Markus Pargmann
2013-12-18 11:57 ` [PATCH v3 9/9] ARM: DTS: imx5* imx6*, use imx51-ssi Markus Pargmann
2013-12-18 13:58   ` Shawn Guo
2013-12-18 14:10     ` Markus Pargmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387367865-26391-6-git-send-email-mpa@pengutronix.de \
    --to=mpa@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).