* [PATCH 2/3] ARM: dts: Add the missing "\" key in non-US keyboards for exynos5250-snow [not found] <1387492578-22068-1-git-send-email-dianders@chromium.org> @ 2013-12-19 22:36 ` Doug Anderson 2013-12-20 21:08 ` Kukjin Kim 2013-12-19 22:36 ` [PATCH 3/3] ARM: dts: Fix exynos5250-snow's search key to be L_META Doug Anderson 1 sibling, 1 reply; 3+ messages in thread From: Doug Anderson @ 2013-12-19 22:36 UTC (permalink / raw) To: linux-arm-kernel When the exynos5250 device tree was sent upstream the keyboard mapping was missing the 2nd instance of the "\" key. There are two copies of the "\" because it simply has a different row and column on US and non-US keyboards. For more details, see the previous patch in this series: (mkbp: Fix problems with backslash). Signed-off-by: Doug Anderson <dianders@chromium.org> --- arch/arm/boot/dts/exynos5250-snow.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts index fd711e2..28fe2e2 100644 --- a/arch/arm/boot/dts/exynos5250-snow.dts +++ b/arch/arm/boot/dts/exynos5250-snow.dts @@ -130,6 +130,7 @@ 0x04060024 /* J */ 0x04080027 /* ; */ 0x04090026 /* L */ + 0x040a002b /* \ */ 0x040b001c /* ENTER */ 0x0501002c /* Z */ -- 1.8.5.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/3] ARM: dts: Add the missing "\" key in non-US keyboards for exynos5250-snow 2013-12-19 22:36 ` [PATCH 2/3] ARM: dts: Add the missing "\" key in non-US keyboards for exynos5250-snow Doug Anderson @ 2013-12-20 21:08 ` Kukjin Kim 0 siblings, 0 replies; 3+ messages in thread From: Kukjin Kim @ 2013-12-20 21:08 UTC (permalink / raw) To: linux-arm-kernel On 12/20/13 07:36, Doug Anderson wrote: > When the exynos5250 device tree was sent upstream the keyboard mapping > was missing the 2nd instance of the "\" key. There are two copies of > the "\" because it simply has a different row and column on US and > non-US keyboards. > > For more details, see the previous patch in this series: (mkbp: Fix > problems with backslash). > > Signed-off-by: Doug Anderson<dianders@chromium.org> > --- > arch/arm/boot/dts/exynos5250-snow.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts > index fd711e2..28fe2e2 100644 > --- a/arch/arm/boot/dts/exynos5250-snow.dts > +++ b/arch/arm/boot/dts/exynos5250-snow.dts > @@ -130,6 +130,7 @@ > 0x04060024 /* J */ > 0x04080027 /* ; */ > 0x04090026 /* L */ > + 0x040a002b /* \ */ > 0x040b001c /* ENTER */ > > 0x0501002c /* Z */ OK, Applied this(2/3) and next one(3/3) into fixes for v3.14. If these patches should be sent for 3.13 or before, please let me know. Thanks and Merry Christmas ;-) - Kukjin ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 3/3] ARM: dts: Fix exynos5250-snow's search key to be L_META [not found] <1387492578-22068-1-git-send-email-dianders@chromium.org> 2013-12-19 22:36 ` [PATCH 2/3] ARM: dts: Add the missing "\" key in non-US keyboards for exynos5250-snow Doug Anderson @ 2013-12-19 22:36 ` Doug Anderson 1 sibling, 0 replies; 3+ messages in thread From: Doug Anderson @ 2013-12-19 22:36 UTC (permalink / raw) To: linux-arm-kernel The device tree sent upstream for exynos5250-snow encoded the search key as CAPSLK. However in all ChromeOS kernels it is L_META. One can certainly have long debates about which it ought to be, but I'm proposing setting it to L_META because: * That's how _all_ ChromeOS kernels do it and will do it. * There is no L_META key on the board, so it's nice to have. * For those people who really want it to be caps lock, they can use xmodmap or somesuch. Signed-off-by: Doug Anderson <dianders@chromium.org> --- arch/arm/boot/dts/exynos5250-snow.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts index 28fe2e2..c65f52a 100644 --- a/arch/arm/boot/dts/exynos5250-snow.dts +++ b/arch/arm/boot/dts/exynos5250-snow.dts @@ -85,7 +85,7 @@ keypad,num-rows = <8>; keypad,num-columns = <13>; google,needs-ghost-filter; - linux,keymap = <0x0001003a /* CAPSLK */ + linux,keymap = <0x0001007d /* L_META */ 0x0002003b /* F1 */ 0x00030030 /* B */ 0x00040044 /* F10 */ -- 1.8.5.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-20 21:08 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <1387492578-22068-1-git-send-email-dianders@chromium.org> 2013-12-19 22:36 ` [PATCH 2/3] ARM: dts: Add the missing "\" key in non-US keyboards for exynos5250-snow Doug Anderson 2013-12-20 21:08 ` Kukjin Kim 2013-12-19 22:36 ` [PATCH 3/3] ARM: dts: Fix exynos5250-snow's search key to be L_META Doug Anderson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).