From: mpa@pengutronix.de (Markus Pargmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 5/9] ASoC: fsl-ssi: Add offline_config flag
Date: Fri, 20 Dec 2013 14:11:32 +0100 [thread overview]
Message-ID: <1387545096-2334-6-git-send-email-mpa@pengutronix.de> (raw)
In-Reply-To: <1387545096-2334-1-git-send-email-mpa@pengutronix.de>
imx50-ssi and later versions of this IP support online reconfiguration
of all registers. The reference manual does not list any registers that
can only be configured while the SSI unit is disabled. This patch
introduces the flag for later use.
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
sound/soc/fsl/fsl_ssi.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index f37bcbe..2f25525 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -159,6 +159,7 @@ struct fsl_ssi_private {
bool use_dma;
bool baudclk_locked;
bool irq_stats;
+ bool offline_config;
u8 i2s_mode;
spinlock_t baudclk_lock;
struct clk *baudclk;
@@ -1251,6 +1252,32 @@ static int fsl_ssi_probe(struct platform_device *pdev)
ssi_private->baudclk_locked = false;
spin_lock_init(&ssi_private->baudclk_lock);
+ /*
+ * imx51 and later SoCs have a slightly different IP that allows the
+ * SSI configuration while the SSI unit is running.
+ *
+ * More important, it is necessary on those SoCs to configure the
+ * sperate TX/RX DMA bits just before starting the stream
+ * (fsl_ssi_trigger). The SDMA unit has to be configured before fsl_ssi
+ * sends any DMA requests to the SDMA unit, otherwise it is not defined
+ * how the SDMA unit handles the DMA request.
+ *
+ * SDMA units are present on devices starting at imx35 but the imx35
+ * reference manual states that the DMA bits should not be changed
+ * while the SSI unit is running (SSIEN). So we support the necessary
+ * online configuration of fsl-ssi starting at imx51.
+ */
+ switch (hw_type) {
+ case FSL_SSI_MCP8610:
+ case FSL_SSI_MX21:
+ case FSL_SSI_MX35:
+ ssi_private->offline_config = true;
+ break;
+ case FSL_SSI_MX51:
+ ssi_private->offline_config = false;
+ break;
+ }
+
if (hw_type == FSL_SSI_MX21 || hw_type == FSL_SSI_MX51 ||
hw_type == FSL_SSI_MX35) {
u32 dma_events[2];
--
1.8.5.1
next prev parent reply other threads:[~2013-12-20 13:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 13:11 [PATCH v4 0/9] ASoC: fsl-ssi: offline/online configuration and cleanups Markus Pargmann
2013-12-20 13:11 ` [PATCH v4 1/9] ASoC: fsl-ssi: Fix probe error handling Markus Pargmann
2014-01-08 17:18 ` Mark Brown
2013-12-20 13:11 ` [PATCH v4 2/9] ASoC: fsl-ssi: Move sysfs stats to debugfs Markus Pargmann
2014-01-08 17:18 ` Mark Brown
2013-12-20 13:11 ` [PATCH v4 3/9] ASoC: fsl-ssi: Add imx51-ssi and of_device_id matching Markus Pargmann
2014-01-08 17:18 ` Mark Brown
2013-12-20 13:11 ` [PATCH v4 4/9] ASoC: fsl-ssi: Fix interrupt stats for imx Markus Pargmann
2014-01-08 17:19 ` Mark Brown
2013-12-20 13:11 ` Markus Pargmann [this message]
2013-12-20 13:11 ` [PATCH v4 6/9] ASoC: fsl-ssi: Add configuration helper functions Markus Pargmann
2013-12-20 13:11 ` [PATCH v4 7/9] ASoC: fsl-ssi: Move RX/TX configuration to seperate functions Markus Pargmann
2013-12-20 13:11 ` [PATCH v4 8/9] ASoC: fsl-ssi: Drop ac97 specific trigger function Markus Pargmann
2013-12-20 13:11 ` [PATCH v4 9/9] ARM: DTS: imx5* imx6*, use imx51-ssi Markus Pargmann
2014-01-16 15:55 ` Markus Pargmann
2014-01-17 5:32 ` Shawn Guo
2014-01-08 17:21 ` [PATCH v4 0/9] ASoC: fsl-ssi: offline/online configuration and cleanups Mark Brown
2014-01-09 10:16 ` [PATCH 0/2] fsl-ssi fixups Markus Pargmann
2014-01-09 10:16 ` [PATCH 1/2] ASoC: fsl-ssi doc: Add list of supported compatibles Markus Pargmann
2014-01-09 10:16 ` [PATCH 2/2] ASoC: fsl-ssi: Fix stats compile warning Markus Pargmann
2014-01-09 13:55 ` [PATCH 0/2] fsl-ssi fixups Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387545096-2334-6-git-send-email-mpa@pengutronix.de \
--to=mpa@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).