* [PATCH 1/7] clk: tegra: Fix PLLP rate table
2013-12-27 0:44 [PATCH 0/7] misc Tegra clock fixes Andrew Bresticker
@ 2013-12-27 0:44 ` Andrew Bresticker
2013-12-27 0:44 ` [PATCH 2/7] clk: tegra: Fix PLLD mnp table Andrew Bresticker
` (7 subsequent siblings)
8 siblings, 0 replies; 12+ messages in thread
From: Andrew Bresticker @ 2013-12-27 0:44 UTC (permalink / raw)
To: linux-arm-kernel
From: Gabe Black <gabeblack@chromium.org>
This table had settings for 216MHz, but PLLP is (and is supposed to be)
configured at 408MHz. If that table is used and PLLP_BASE_OVRRIDE is
not set, the kernel will panic in clk_pll_recalc_rate().
Signed-off-by: Gabe Black <gabeblack@google.com>
Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
---
drivers/clk/tegra/clk-tegra124.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/clk/tegra/clk-tegra124.c b/drivers/clk/tegra/clk-tegra124.c
index aff86b5..28bb238 100644
--- a/drivers/clk/tegra/clk-tegra124.c
+++ b/drivers/clk/tegra/clk-tegra124.c
@@ -516,11 +516,11 @@ static struct div_nmp pllp_nmp = {
};
static struct tegra_clk_pll_freq_table pll_p_freq_table[] = {
- {12000000, 216000000, 432, 12, 1, 8},
- {13000000, 216000000, 432, 13, 1, 8},
- {16800000, 216000000, 360, 14, 1, 8},
- {19200000, 216000000, 360, 16, 1, 8},
- {26000000, 216000000, 432, 26, 1, 8},
+ {12000000, 408000000, 408, 12, 0, 8},
+ {13000000, 408000000, 408, 13, 0, 8},
+ {16800000, 408000000, 340, 14, 0, 8},
+ {19200000, 408000000, 340, 16, 0, 8},
+ {26000000, 408000000, 408, 26, 0, 8},
{0, 0, 0, 0, 0, 0},
};
--
1.8.5.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/7] clk: tegra: Fix PLLD mnp table
2013-12-27 0:44 [PATCH 0/7] misc Tegra clock fixes Andrew Bresticker
2013-12-27 0:44 ` [PATCH 1/7] clk: tegra: Fix PLLP rate table Andrew Bresticker
@ 2013-12-27 0:44 ` Andrew Bresticker
2013-12-27 0:44 ` [PATCH 3/7] clk: tegra: PLLD2 fixes for hdmi Andrew Bresticker
` (6 subsequent siblings)
8 siblings, 0 replies; 12+ messages in thread
From: Andrew Bresticker @ 2013-12-27 0:44 UTC (permalink / raw)
To: linux-arm-kernel
From: Rhyland Klein <rklein@nvidia.com>
PLLD was using the same mnp table as PLLP. Fix it to use its own
table which is different from PLLP's.
Signed-off-by: Rhyland Klein <rklein@nvidia.com>
Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
---
drivers/clk/tegra/clk-tegra124.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/tegra/clk-tegra124.c b/drivers/clk/tegra/clk-tegra124.c
index 28bb238..14c3f2f 100644
--- a/drivers/clk/tegra/clk-tegra124.c
+++ b/drivers/clk/tegra/clk-tegra124.c
@@ -570,6 +570,15 @@ static struct tegra_clk_pll_params pll_a_params = {
.flags = TEGRA_PLL_HAS_CPCON | TEGRA_PLL_USE_LOCK,
};
+static struct div_nmp plld_nmp = {
+ .divm_shift = 0,
+ .divm_width = 5,
+ .divn_shift = 8,
+ .divn_width = 11,
+ .divp_shift = 20,
+ .divp_width = 3,
+};
+
static struct tegra_clk_pll_freq_table pll_d_freq_table[] = {
{12000000, 216000000, 864, 12, 4, 12},
{13000000, 216000000, 864, 13, 4, 12},
@@ -603,7 +612,7 @@ static struct tegra_clk_pll_params pll_d_params = {
.lock_mask = PLL_BASE_LOCK,
.lock_enable_bit_idx = PLLDU_MISC_LOCK_ENABLE,
.lock_delay = 1000,
- .div_nmp = &pllp_nmp,
+ .div_nmp = &plld_nmp,
.freq_table = pll_d_freq_table,
.flags = TEGRA_PLL_HAS_CPCON | TEGRA_PLL_SET_LFCON |
TEGRA_PLL_USE_LOCK,
--
1.8.5.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 3/7] clk: tegra: PLLD2 fixes for hdmi
2013-12-27 0:44 [PATCH 0/7] misc Tegra clock fixes Andrew Bresticker
2013-12-27 0:44 ` [PATCH 1/7] clk: tegra: Fix PLLP rate table Andrew Bresticker
2013-12-27 0:44 ` [PATCH 2/7] clk: tegra: Fix PLLD mnp table Andrew Bresticker
@ 2013-12-27 0:44 ` Andrew Bresticker
2013-12-27 0:44 ` [PATCH 4/7] clk: tegra: fix host1x clock on Tegra124 Andrew Bresticker
` (5 subsequent siblings)
8 siblings, 0 replies; 12+ messages in thread
From: Andrew Bresticker @ 2013-12-27 0:44 UTC (permalink / raw)
To: linux-arm-kernel
From: David Ung <davidu@nvidia.com>
Set correct pll_d2_out0 divider and correct the p div values for pll_d2.
Signed-off-by: David Ung <davidu@nvidia.com>
Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
---
drivers/clk/tegra/clk-tegra124.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/clk/tegra/clk-tegra124.c b/drivers/clk/tegra/clk-tegra124.c
index 14c3f2f..0fc9126 100644
--- a/drivers/clk/tegra/clk-tegra124.c
+++ b/drivers/clk/tegra/clk-tegra124.c
@@ -619,12 +619,11 @@ static struct tegra_clk_pll_params pll_d_params = {
};
static struct tegra_clk_pll_freq_table tegra124_pll_d2_freq_table[] = {
- { 12000000, 148500000, 99, 1, 8},
- { 12000000, 594000000, 99, 1, 1},
- { 13000000, 594000000, 91, 1, 1}, /* actual: 591.5 MHz */
- { 16800000, 594000000, 71, 1, 1}, /* actual: 596.4 MHz */
- { 19200000, 594000000, 62, 1, 1}, /* actual: 595.2 MHz */
- { 26000000, 594000000, 91, 2, 1}, /* actual: 591.5 MHz */
+ { 12000000, 594000000, 99, 1, 2},
+ { 13000000, 594000000, 91, 1, 2}, /* actual: 591.5 MHz */
+ { 16800000, 594000000, 71, 1, 2}, /* actual: 596.4 MHz */
+ { 19200000, 594000000, 62, 1, 2}, /* actual: 595.2 MHz */
+ { 26000000, 594000000, 91, 2, 2}, /* actual: 591.5 MHz */
{ 0, 0, 0, 0, 0, 0 },
};
@@ -1295,9 +1294,9 @@ static void __init tegra124_pll_init(void __iomem *clk_base,
clk_register_clkdev(clk, "pll_d2", NULL);
clks[TEGRA124_CLK_PLL_D2] = clk;
- /* PLLD2_OUT0 ?? */
+ /* PLLD2_OUT0 */
clk = clk_register_fixed_factor(NULL, "pll_d2_out0", "pll_d2",
- CLK_SET_RATE_PARENT, 1, 2);
+ CLK_SET_RATE_PARENT, 1, 1);
clk_register_clkdev(clk, "pll_d2_out0", NULL);
clks[TEGRA124_CLK_PLL_D2_OUT0] = clk;
--
1.8.5.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 4/7] clk: tegra: fix host1x clock on Tegra124
2013-12-27 0:44 [PATCH 0/7] misc Tegra clock fixes Andrew Bresticker
` (2 preceding siblings ...)
2013-12-27 0:44 ` [PATCH 3/7] clk: tegra: PLLD2 fixes for hdmi Andrew Bresticker
@ 2013-12-27 0:44 ` Andrew Bresticker
2013-12-27 0:44 ` [PATCH 5/7] clk: tegra: fix sdmmc clks on Tegra1x4 Andrew Bresticker
` (4 subsequent siblings)
8 siblings, 0 replies; 12+ messages in thread
From: Andrew Bresticker @ 2013-12-27 0:44 UTC (permalink / raw)
To: linux-arm-kernel
From: Mark Zhang <markz@nvidia.com>
The host1x clock on Tegra124 is a 3-bit wide mux with 6 parents.
Change thte id to tegra_clk_host1x_8 so that the correct clock gets
registered.
Signed-off-by: Mark Zhang <markz@nvidia.com>
Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
---
drivers/clk/tegra/clk-tegra124.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/tegra/clk-tegra124.c b/drivers/clk/tegra/clk-tegra124.c
index 0fc9126..743ccb4 100644
--- a/drivers/clk/tegra/clk-tegra124.c
+++ b/drivers/clk/tegra/clk-tegra124.c
@@ -775,7 +775,7 @@ static struct tegra_clk tegra124_clks[tegra_clk_max] __initdata = {
[tegra_clk_gr3d] = { .dt_id = TEGRA124_CLK_GR_3D, .present = true },
[tegra_clk_disp2] = { .dt_id = TEGRA124_CLK_DISP2, .present = true },
[tegra_clk_disp1] = { .dt_id = TEGRA124_CLK_DISP1, .present = true },
- [tegra_clk_host1x] = { .dt_id = TEGRA124_CLK_HOST1X, .present = true },
+ [tegra_clk_host1x_8] = { .dt_id = TEGRA124_CLK_HOST1X, .present = true },
[tegra_clk_vcp] = { .dt_id = TEGRA124_CLK_VCP, .present = true },
[tegra_clk_i2s0] = { .dt_id = TEGRA124_CLK_I2S0, .present = true },
[tegra_clk_apbdma] = { .dt_id = TEGRA124_CLK_APBDMA, .present = true },
--
1.8.5.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 5/7] clk: tegra: fix sdmmc clks on Tegra1x4
2013-12-27 0:44 [PATCH 0/7] misc Tegra clock fixes Andrew Bresticker
` (3 preceding siblings ...)
2013-12-27 0:44 ` [PATCH 4/7] clk: tegra: fix host1x clock on Tegra124 Andrew Bresticker
@ 2013-12-27 0:44 ` Andrew Bresticker
2013-12-27 0:44 ` [PATCH 6/7] clk: tegra: cclk_lp has a pllx/2 divider Andrew Bresticker
` (3 subsequent siblings)
8 siblings, 0 replies; 12+ messages in thread
From: Andrew Bresticker @ 2013-12-27 0:44 UTC (permalink / raw)
To: linux-arm-kernel
The sdmmc clocks on Tegra114 and Tegra124 are 3-bit wide muxes with
6 parents. Add support for tegra_clk_sdmmc*_8 and switch Tegra114
and Tegra124 to use these clocks instead.
Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
---
drivers/clk/tegra/clk-id.h | 4 ++++
drivers/clk/tegra/clk-tegra-periph.c | 4 ++++
drivers/clk/tegra/clk-tegra114.c | 8 ++++----
drivers/clk/tegra/clk-tegra124.c | 8 ++++----
4 files changed, 16 insertions(+), 8 deletions(-)
diff --git a/drivers/clk/tegra/clk-id.h b/drivers/clk/tegra/clk-id.h
index cf0c323..c39613c 100644
--- a/drivers/clk/tegra/clk-id.h
+++ b/drivers/clk/tegra/clk-id.h
@@ -180,9 +180,13 @@ enum clk_id {
tegra_clk_sbc6_8,
tegra_clk_sclk,
tegra_clk_sdmmc1,
+ tegra_clk_sdmmc1_8,
tegra_clk_sdmmc2,
+ tegra_clk_sdmmc2_8,
tegra_clk_sdmmc3,
+ tegra_clk_sdmmc3_8,
tegra_clk_sdmmc4,
+ tegra_clk_sdmmc4_8,
tegra_clk_se,
tegra_clk_soc_therm,
tegra_clk_sor0,
diff --git a/drivers/clk/tegra/clk-tegra-periph.c b/drivers/clk/tegra/clk-tegra-periph.c
index 5c35885..c212473 100644
--- a/drivers/clk/tegra/clk-tegra-periph.c
+++ b/drivers/clk/tegra/clk-tegra-periph.c
@@ -465,6 +465,10 @@ static struct tegra_periph_init_data periph_clks[] = {
MUX("adx1", mux_plla_pllc_pllp_clkm, CLK_SOURCE_ADX1, 180, TEGRA_PERIPH_ON_APB, tegra_clk_adx1),
MUX("amx1", mux_plla_pllc_pllp_clkm, CLK_SOURCE_AMX1, 185, TEGRA_PERIPH_ON_APB, tegra_clk_amx1),
MUX("vi_sensor2", mux_pllm_pllc2_c_c3_pllp_plla, CLK_SOURCE_VI_SENSOR2, 20, TEGRA_PERIPH_NO_RESET, tegra_clk_vi_sensor2),
+ MUX8("sdmmc1", mux_pllp_pllc2_c_c3_pllm_clkm, CLK_SOURCE_SDMMC1, 14, 0, tegra_clk_sdmmc1_8),
+ MUX8("sdmmc2", mux_pllp_pllc2_c_c3_pllm_clkm, CLK_SOURCE_SDMMC2, 9, 0, tegra_clk_sdmmc2_8),
+ MUX8("sdmmc3", mux_pllp_pllc2_c_c3_pllm_clkm, CLK_SOURCE_SDMMC3, 69, 0, tegra_clk_sdmmc3_8),
+ MUX8("sdmmc4", mux_pllp_pllc2_c_c3_pllm_clkm, CLK_SOURCE_SDMMC4, 15, 0, tegra_clk_sdmmc4_8),
MUX8("sbc1", mux_pllp_pllc2_c_c3_pllm_clkm, CLK_SOURCE_SBC1, 41, TEGRA_PERIPH_ON_APB, tegra_clk_sbc1_8),
MUX8("sbc2", mux_pllp_pllc2_c_c3_pllm_clkm, CLK_SOURCE_SBC2, 44, TEGRA_PERIPH_ON_APB, tegra_clk_sbc2_8),
MUX8("sbc3", mux_pllp_pllc2_c_c3_pllm_clkm, CLK_SOURCE_SBC3, 46, TEGRA_PERIPH_ON_APB, tegra_clk_sbc3_8),
diff --git a/drivers/clk/tegra/clk-tegra114.c b/drivers/clk/tegra/clk-tegra114.c
index 90d9d25..80431f0 100644
--- a/drivers/clk/tegra/clk-tegra114.c
+++ b/drivers/clk/tegra/clk-tegra114.c
@@ -682,12 +682,12 @@ static struct tegra_clk tegra114_clks[tegra_clk_max] __initdata = {
[tegra_clk_timer] = { .dt_id = TEGRA114_CLK_TIMER, .present = true },
[tegra_clk_uarta] = { .dt_id = TEGRA114_CLK_UARTA, .present = true },
[tegra_clk_uartd] = { .dt_id = TEGRA114_CLK_UARTD, .present = true },
- [tegra_clk_sdmmc2] = { .dt_id = TEGRA114_CLK_SDMMC2, .present = true },
+ [tegra_clk_sdmmc2_8] = { .dt_id = TEGRA114_CLK_SDMMC2, .present = true },
[tegra_clk_i2s1] = { .dt_id = TEGRA114_CLK_I2S1, .present = true },
[tegra_clk_i2c1] = { .dt_id = TEGRA114_CLK_I2C1, .present = true },
[tegra_clk_ndflash] = { .dt_id = TEGRA114_CLK_NDFLASH, .present = true },
- [tegra_clk_sdmmc1] = { .dt_id = TEGRA114_CLK_SDMMC1, .present = true },
- [tegra_clk_sdmmc4] = { .dt_id = TEGRA114_CLK_SDMMC4, .present = true },
+ [tegra_clk_sdmmc1_8] = { .dt_id = TEGRA114_CLK_SDMMC1, .present = true },
+ [tegra_clk_sdmmc4_8] = { .dt_id = TEGRA114_CLK_SDMMC4, .present = true },
[tegra_clk_pwm] = { .dt_id = TEGRA114_CLK_PWM, .present = true },
[tegra_clk_i2s0] = { .dt_id = TEGRA114_CLK_I2S0, .present = true },
[tegra_clk_i2s2] = { .dt_id = TEGRA114_CLK_I2S2, .present = true },
@@ -723,7 +723,7 @@ static struct tegra_clk tegra114_clks[tegra_clk_max] __initdata = {
[tegra_clk_bsev] = { .dt_id = TEGRA114_CLK_BSEV, .present = true },
[tegra_clk_i2c3] = { .dt_id = TEGRA114_CLK_I2C3, .present = true },
[tegra_clk_sbc4_8] = { .dt_id = TEGRA114_CLK_SBC4, .present = true },
- [tegra_clk_sdmmc3] = { .dt_id = TEGRA114_CLK_SDMMC3, .present = true },
+ [tegra_clk_sdmmc3_8] = { .dt_id = TEGRA114_CLK_SDMMC3, .present = true },
[tegra_clk_owr] = { .dt_id = TEGRA114_CLK_OWR, .present = true },
[tegra_clk_csite] = { .dt_id = TEGRA114_CLK_CSITE, .present = true },
[tegra_clk_la] = { .dt_id = TEGRA114_CLK_LA, .present = true },
diff --git a/drivers/clk/tegra/clk-tegra124.c b/drivers/clk/tegra/clk-tegra124.c
index 743ccb4..b4cf650 100644
--- a/drivers/clk/tegra/clk-tegra124.c
+++ b/drivers/clk/tegra/clk-tegra124.c
@@ -761,12 +761,12 @@ static struct tegra_clk tegra124_clks[tegra_clk_max] __initdata = {
[tegra_clk_rtc] = { .dt_id = TEGRA124_CLK_RTC, .present = true },
[tegra_clk_timer] = { .dt_id = TEGRA124_CLK_TIMER, .present = true },
[tegra_clk_uarta] = { .dt_id = TEGRA124_CLK_UARTA, .present = true },
- [tegra_clk_sdmmc2] = { .dt_id = TEGRA124_CLK_SDMMC2, .present = true },
+ [tegra_clk_sdmmc2_8] = { .dt_id = TEGRA124_CLK_SDMMC2, .present = true },
[tegra_clk_i2s1] = { .dt_id = TEGRA124_CLK_I2S1, .present = true },
[tegra_clk_i2c1] = { .dt_id = TEGRA124_CLK_I2C1, .present = true },
[tegra_clk_ndflash] = { .dt_id = TEGRA124_CLK_NDFLASH, .present = true },
- [tegra_clk_sdmmc1] = { .dt_id = TEGRA124_CLK_SDMMC1, .present = true },
- [tegra_clk_sdmmc4] = { .dt_id = TEGRA124_CLK_SDMMC4, .present = true },
+ [tegra_clk_sdmmc1_8] = { .dt_id = TEGRA124_CLK_SDMMC1, .present = true },
+ [tegra_clk_sdmmc4_8] = { .dt_id = TEGRA124_CLK_SDMMC4, .present = true },
[tegra_clk_pwm] = { .dt_id = TEGRA124_CLK_PWM, .present = true },
[tegra_clk_i2s2] = { .dt_id = TEGRA124_CLK_I2S2, .present = true },
[tegra_clk_gr2d] = { .dt_id = TEGRA124_CLK_GR_2D, .present = true },
@@ -802,7 +802,7 @@ static struct tegra_clk tegra124_clks[tegra_clk_max] __initdata = {
[tegra_clk_uartd] = { .dt_id = TEGRA124_CLK_UARTD, .present = true },
[tegra_clk_i2c3] = { .dt_id = TEGRA124_CLK_I2C3, .present = true },
[tegra_clk_sbc4] = { .dt_id = TEGRA124_CLK_SBC4, .present = true },
- [tegra_clk_sdmmc3] = { .dt_id = TEGRA124_CLK_SDMMC3, .present = true },
+ [tegra_clk_sdmmc3_8] = { .dt_id = TEGRA124_CLK_SDMMC3, .present = true },
[tegra_clk_pcie] = { .dt_id = TEGRA124_CLK_PCIE, .present = true },
[tegra_clk_owr] = { .dt_id = TEGRA124_CLK_OWR, .present = true },
[tegra_clk_afi] = { .dt_id = TEGRA124_CLK_AFI, .present = true },
--
1.8.5.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 6/7] clk: tegra: cclk_lp has a pllx/2 divider
2013-12-27 0:44 [PATCH 0/7] misc Tegra clock fixes Andrew Bresticker
` (4 preceding siblings ...)
2013-12-27 0:44 ` [PATCH 5/7] clk: tegra: fix sdmmc clks on Tegra1x4 Andrew Bresticker
@ 2013-12-27 0:44 ` Andrew Bresticker
2013-12-27 0:44 ` [PATCH 7/7] clk: tegra: use max divider if divider overflows Andrew Bresticker
` (2 subsequent siblings)
8 siblings, 0 replies; 12+ messages in thread
From: Andrew Bresticker @ 2013-12-27 0:44 UTC (permalink / raw)
To: linux-arm-kernel
When pll_x is the parent of cclk_lp, PLLX_DIV2_BYPASS_LP determines
whether cclk_lp output is divided by 2. Set TEGRA_DIVIDER_2 so that
the clk_super driver is aware of this.
Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
---
drivers/clk/tegra/clk-tegra-super-gen4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/tegra/clk-tegra-super-gen4.c b/drivers/clk/tegra/clk-tegra-super-gen4.c
index 05dce4a..feb3201 100644
--- a/drivers/clk/tegra/clk-tegra-super-gen4.c
+++ b/drivers/clk/tegra/clk-tegra-super-gen4.c
@@ -120,7 +120,7 @@ void __init tegra_super_clk_gen4_init(void __iomem *clk_base,
ARRAY_SIZE(cclk_lp_parents),
CLK_SET_RATE_PARENT,
clk_base + CCLKLP_BURST_POLICY,
- 0, 4, 8, 9, NULL);
+ TEGRA_DIVIDER_2, 4, 8, 9, NULL);
*dt_clk = clk;
}
--
1.8.5.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 7/7] clk: tegra: use max divider if divider overflows
2013-12-27 0:44 [PATCH 0/7] misc Tegra clock fixes Andrew Bresticker
` (5 preceding siblings ...)
2013-12-27 0:44 ` [PATCH 6/7] clk: tegra: cclk_lp has a pllx/2 divider Andrew Bresticker
@ 2013-12-27 0:44 ` Andrew Bresticker
2013-12-29 22:02 ` [PATCH 0/7] misc Tegra clock fixes Mike Turquette
2014-01-08 22:28 ` Andrew Bresticker
8 siblings, 0 replies; 12+ messages in thread
From: Andrew Bresticker @ 2013-12-27 0:44 UTC (permalink / raw)
To: linux-arm-kernel
When requesting a rate less than the minimum clock rate for a divider,
use the maximum divider value instead of bailing out with an error.
This matches the behavior of the generic clock divider.
Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
---
drivers/clk/tegra/clk-divider.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/tegra/clk-divider.c b/drivers/clk/tegra/clk-divider.c
index 4d75b1f..290f9c1 100644
--- a/drivers/clk/tegra/clk-divider.c
+++ b/drivers/clk/tegra/clk-divider.c
@@ -59,7 +59,7 @@ static int get_div(struct tegra_clk_frac_div *divider, unsigned long rate,
return 0;
if (divider_ux1 > get_max_div(divider))
- return -EINVAL;
+ return get_max_div(divider);
return divider_ux1;
}
--
1.8.5.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 0/7] misc Tegra clock fixes
2013-12-27 0:44 [PATCH 0/7] misc Tegra clock fixes Andrew Bresticker
` (6 preceding siblings ...)
2013-12-27 0:44 ` [PATCH 7/7] clk: tegra: use max divider if divider overflows Andrew Bresticker
@ 2013-12-29 22:02 ` Mike Turquette
2014-01-08 22:28 ` Andrew Bresticker
8 siblings, 0 replies; 12+ messages in thread
From: Mike Turquette @ 2013-12-29 22:02 UTC (permalink / raw)
To: linux-arm-kernel
Quoting Andrew Bresticker (2013-12-26 16:44:20)
> Fixes for various clock-related issues found during bringup of
> Tegra124-based Venice2 and Norrin boards.
Acked-by: Mike Turquette <mturquette@linaro.org>
>
> Andrew Bresticker (3):
> clk: tegra: fix sdmmc clks on Tegra1x4
> clk: tegra: cclk_lp has a pllx/2 divider
> clk: tegra: use max divider if divider overflows
>
> David Ung (1):
> clk: tegra: PLLD2 fixes for hdmi
>
> Gabe Black (1):
> clk: tegra: Fix PLLP rate table
>
> Mark Zhang (1):
> clk: tegra: fix host1x clock on Tegra124
>
> Rhyland Klein (1):
> clk: tegra: Fix PLLD mnp table
>
> drivers/clk/tegra/clk-divider.c | 2 +-
> drivers/clk/tegra/clk-id.h | 4 +++
> drivers/clk/tegra/clk-tegra-periph.c | 4 +++
> drivers/clk/tegra/clk-tegra-super-gen4.c | 2 +-
> drivers/clk/tegra/clk-tegra114.c | 8 +++---
> drivers/clk/tegra/clk-tegra124.c | 46 +++++++++++++++++++-------------
> 6 files changed, 41 insertions(+), 25 deletions(-)
>
> --
> 1.8.5.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 0/7] misc Tegra clock fixes
2013-12-27 0:44 [PATCH 0/7] misc Tegra clock fixes Andrew Bresticker
` (7 preceding siblings ...)
2013-12-29 22:02 ` [PATCH 0/7] misc Tegra clock fixes Mike Turquette
@ 2014-01-08 22:28 ` Andrew Bresticker
2014-01-08 22:41 ` Stephen Warren
8 siblings, 1 reply; 12+ messages in thread
From: Andrew Bresticker @ 2014-01-08 22:28 UTC (permalink / raw)
To: linux-arm-kernel
Hi Stephen, Peter,
> Fixes for various clock-related issues found during bringup of
> Tegra124-based Venice2 and Norrin boards.
>
> Andrew Bresticker (3):
> clk: tegra: fix sdmmc clks on Tegra1x4
> clk: tegra: cclk_lp has a pllx/2 divider
> clk: tegra: use max divider if divider overflows
>
> David Ung (1):
> clk: tegra: PLLD2 fixes for hdmi
>
> Gabe Black (1):
> clk: tegra: Fix PLLP rate table
>
> Mark Zhang (1):
> clk: tegra: fix host1x clock on Tegra124
>
> Rhyland Klein (1):
> clk: tegra: Fix PLLD mnp table
>
> drivers/clk/tegra/clk-divider.c | 2 +-
> drivers/clk/tegra/clk-id.h | 4 +++
> drivers/clk/tegra/clk-tegra-periph.c | 4 +++
> drivers/clk/tegra/clk-tegra-super-gen4.c | 2 +-
> drivers/clk/tegra/clk-tegra114.c | 8 +++---
> drivers/clk/tegra/clk-tegra124.c | 46 +++++++++++++++++++-------------
> 6 files changed, 41 insertions(+), 25 deletions(-)
Any comments on this series?
Thanks!
Andrew
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 0/7] misc Tegra clock fixes
2014-01-08 22:28 ` Andrew Bresticker
@ 2014-01-08 22:41 ` Stephen Warren
2014-01-13 16:08 ` Peter De Schrijver
0 siblings, 1 reply; 12+ messages in thread
From: Stephen Warren @ 2014-01-08 22:41 UTC (permalink / raw)
To: linux-arm-kernel
On 01/08/2014 03:28 PM, Andrew Bresticker wrote:
> Hi Stephen, Peter,
>
>> Fixes for various clock-related issues found during bringup of
>> Tegra124-based Venice2 and Norrin boards.
...
> Any comments on this series?
Peter owns drivers/clk/tegra/, so I assume he'll handle these patches. I
briefly looked at them when they were posted and didn't see any issues.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 0/7] misc Tegra clock fixes
2014-01-08 22:41 ` Stephen Warren
@ 2014-01-13 16:08 ` Peter De Schrijver
0 siblings, 0 replies; 12+ messages in thread
From: Peter De Schrijver @ 2014-01-13 16:08 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 08, 2014 at 11:41:02PM +0100, Stephen Warren wrote:
> On 01/08/2014 03:28 PM, Andrew Bresticker wrote:
> > Hi Stephen, Peter,
> >
> >> Fixes for various clock-related issues found during bringup of
> >> Tegra124-based Venice2 and Norrin boards.
> ...
> > Any comments on this series?
>
> Peter owns drivers/clk/tegra/, so I assume he'll handle these patches. I
> briefly looked at them when they were posted and didn't see any issues.
>
Yes. I will... I'm still waiting for the existing pull request to show up though...
^ permalink raw reply [flat|nested] 12+ messages in thread