* [GIT PULL] ARM : cpuidle: 3.13 fix
@ 2013-12-30 11:00 Daniel Lezcano
2013-12-30 11:02 ` [PATCH] ARM/cpuidle: remove __init tag from Calxeda cpuidle probe function Daniel Lezcano
2013-12-31 21:30 ` [GIT PULL] ARM : cpuidle: 3.13 fix Rafael J. Wysocki
0 siblings, 2 replies; 7+ messages in thread
From: Daniel Lezcano @ 2013-12-30 11:00 UTC (permalink / raw)
To: linux-arm-kernel
Hi Rafael,
this pull request provides a single fix for the calxeda cpuidle driver.
It is based on v3.13-rc6.
* Andre Przywara fixed a compilation warning due to the driver probe
function prototype mismatch for the calxeda cpuidle driver
Thanks
-- Daniel
The following changes since commit 802eee95bde72fd0cd0f3a5b2098375a487d1eda:
Linux 3.13-rc6 (2013-12-29 16:01:33 -0800)
are available in the git repository at:
git://git.linaro.org/people/daniel.lezcano/linux.git cpuidle/3.13-fixes
for you to fetch changes up to 5781532ebecd9e0b7b5fc25d78030bdec635f4ac:
ARM/cpuidle: remove __init tag from Calxeda cpuidle probe function
(2013-12-30 11:55:20 +0100)
----------------------------------------------------------------
Andre Przywara (1):
ARM/cpuidle: remove __init tag from Calxeda cpuidle probe function
drivers/cpuidle/cpuidle-calxeda.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH] ARM/cpuidle: remove __init tag from Calxeda cpuidle probe function
2013-12-30 11:00 [GIT PULL] ARM : cpuidle: 3.13 fix Daniel Lezcano
@ 2013-12-30 11:02 ` Daniel Lezcano
2013-12-31 21:30 ` [GIT PULL] ARM : cpuidle: 3.13 fix Rafael J. Wysocki
1 sibling, 0 replies; 7+ messages in thread
From: Daniel Lezcano @ 2013-12-30 11:02 UTC (permalink / raw)
To: linux-arm-kernel
From: Andre Przywara <andre.przywara@linaro.org>
Commit 60a66e370007e8535b7a561353b07b37deaf35ba changed the Calxeda
cpuidle driver to a platform driver, copying the __init tag from the
_init() to the newly used _probe() function. However, "probe should
not be __init." (Rob said ;-)
Remove the __init tag to fix a section mismatch in the Calxeda
cpuidle driver.
Signed-off-by: Andre Przywara <andre.przywara@linaro.org>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/cpuidle/cpuidle-calxeda.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpuidle/cpuidle-calxeda.c b/drivers/cpuidle/cpuidle-calxeda.c
index 3679563..6e51114 100644
--- a/drivers/cpuidle/cpuidle-calxeda.c
+++ b/drivers/cpuidle/cpuidle-calxeda.c
@@ -65,7 +65,7 @@ static struct cpuidle_driver calxeda_idle_driver = {
.state_count = 2,
};
-static int __init calxeda_cpuidle_probe(struct platform_device *pdev)
+static int calxeda_cpuidle_probe(struct platform_device *pdev)
{
return cpuidle_register(&calxeda_idle_driver, NULL);
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread* [GIT PULL] ARM : cpuidle: 3.13 fix
2013-12-30 11:00 [GIT PULL] ARM : cpuidle: 3.13 fix Daniel Lezcano
2013-12-30 11:02 ` [PATCH] ARM/cpuidle: remove __init tag from Calxeda cpuidle probe function Daniel Lezcano
@ 2013-12-31 21:30 ` Rafael J. Wysocki
1 sibling, 0 replies; 7+ messages in thread
From: Rafael J. Wysocki @ 2013-12-31 21:30 UTC (permalink / raw)
To: linux-arm-kernel
On Monday, December 30, 2013 12:00:56 PM Daniel Lezcano wrote:
> Hi Rafael,
>
> this pull request provides a single fix for the calxeda cpuidle driver.
> It is based on v3.13-rc6.
>
> * Andre Przywara fixed a compilation warning due to the driver probe
> function prototype mismatch for the calxeda cpuidle driver
>
> Thanks
> -- Daniel
>
> The following changes since commit 802eee95bde72fd0cd0f3a5b2098375a487d1eda:
>
> Linux 3.13-rc6 (2013-12-29 16:01:33 -0800)
>
> are available in the git repository at:
>
> git://git.linaro.org/people/daniel.lezcano/linux.git cpuidle/3.13-fixes
>
> for you to fetch changes up to 5781532ebecd9e0b7b5fc25d78030bdec635f4ac:
>
> ARM/cpuidle: remove __init tag from Calxeda cpuidle probe function
> (2013-12-30 11:55:20 +0100)
>
> ----------------------------------------------------------------
> Andre Przywara (1):
> ARM/cpuidle: remove __init tag from Calxeda cpuidle probe function
>
> drivers/cpuidle/cpuidle-calxeda.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Pulled and pushed out (into the fixes branch).
Thanks and Happy New Year!
Rafael
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM/cpuidle: remove __init tag from Calxeda cpuidle probe function
@ 2013-12-13 20:49 Andre Przywara
2013-12-13 21:57 ` Daniel Lezcano
0 siblings, 1 reply; 7+ messages in thread
From: Andre Przywara @ 2013-12-13 20:49 UTC (permalink / raw)
To: linux-arm-kernel
Commit 60a66e370007e8535b7a561353b07b37deaf35ba changed the Calxeda
cpuidle driver to a platform driver, copying the __init tag from the
_init() to the newly used _probe() function. However, "probe should
not be __init." (Rob said ;-)
Remove the __init tag to fix a section mismatch in the Calxeda
cpuidle driver.
Signed-off-by: Andre Przywara <andre.przywara@linaro.org>
---
drivers/cpuidle/cpuidle-calxeda.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpuidle/cpuidle-calxeda.c b/drivers/cpuidle/cpuidle-calxeda.c
index 3679563..6e51114 100644
--- a/drivers/cpuidle/cpuidle-calxeda.c
+++ b/drivers/cpuidle/cpuidle-calxeda.c
@@ -65,7 +65,7 @@ static struct cpuidle_driver calxeda_idle_driver = {
.state_count = 2,
};
-static int __init calxeda_cpuidle_probe(struct platform_device *pdev)
+static int calxeda_cpuidle_probe(struct platform_device *pdev)
{
return cpuidle_register(&calxeda_idle_driver, NULL);
}
--
1.7.12.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] ARM/cpuidle: remove __init tag from Calxeda cpuidle probe function
2013-12-13 20:49 [PATCH] ARM/cpuidle: remove __init tag from Calxeda cpuidle probe function Andre Przywara
@ 2013-12-13 21:57 ` Daniel Lezcano
2013-12-13 22:47 ` Andre Przywara
0 siblings, 1 reply; 7+ messages in thread
From: Daniel Lezcano @ 2013-12-13 21:57 UTC (permalink / raw)
To: linux-arm-kernel
On 12/13/2013 09:49 PM, Andre Przywara wrote:
> Commit 60a66e370007e8535b7a561353b07b37deaf35ba changed the Calxeda
> cpuidle driver to a platform driver, copying the __init tag from the
> _init() to the newly used _probe() function. However, "probe should
> not be __init." (Rob said ;-)
> Remove the __init tag to fix a section mismatch in the Calxeda
> cpuidle driver.
>
> Signed-off-by: Andre Przywara <andre.przywara@linaro.org>
> ---
Applied to my tree for 3.14.
Thanks for the fix.
-- Daniel
> drivers/cpuidle/cpuidle-calxeda.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpuidle/cpuidle-calxeda.c b/drivers/cpuidle/cpuidle-calxeda.c
> index 3679563..6e51114 100644
> --- a/drivers/cpuidle/cpuidle-calxeda.c
> +++ b/drivers/cpuidle/cpuidle-calxeda.c
> @@ -65,7 +65,7 @@ static struct cpuidle_driver calxeda_idle_driver = {
> .state_count = 2,
> };
>
> -static int __init calxeda_cpuidle_probe(struct platform_device *pdev)
> +static int calxeda_cpuidle_probe(struct platform_device *pdev)
> {
> return cpuidle_register(&calxeda_idle_driver, NULL);
> }
>
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH] ARM/cpuidle: remove __init tag from Calxeda cpuidle probe function
2013-12-13 21:57 ` Daniel Lezcano
@ 2013-12-13 22:47 ` Andre Przywara
2013-12-14 9:04 ` Daniel Lezcano
0 siblings, 1 reply; 7+ messages in thread
From: Andre Przywara @ 2013-12-13 22:47 UTC (permalink / raw)
To: linux-arm-kernel
On 12/13/2013 10:57 PM, Daniel Lezcano wrote:
> On 12/13/2013 09:49 PM, Andre Przywara wrote:
>> Commit 60a66e370007e8535b7a561353b07b37deaf35ba changed the Calxeda
>> cpuidle driver to a platform driver, copying the __init tag from the
>> _init() to the newly used _probe() function. However, "probe should
>> not be __init." (Rob said ;-)
>> Remove the __init tag to fix a section mismatch in the Calxeda
>> cpuidle driver.
>>
>> Signed-off-by: Andre Przywara <andre.przywara@linaro.org>
>> ---
>
> Applied to my tree for 3.14.
Daniel,
thanks!
But since this is a regression (3.12 compiles fine), can someone please
push this still for 3.13? If I am not mistaken, the rework was
introduced in the last merge window, so I'd consider this a bug fix.
Thanks,
Andre.
> Thanks for the fix.
>
> -- Daniel
>
>> drivers/cpuidle/cpuidle-calxeda.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/cpuidle/cpuidle-calxeda.c
>> b/drivers/cpuidle/cpuidle-calxeda.c
>> index 3679563..6e51114 100644
>> --- a/drivers/cpuidle/cpuidle-calxeda.c
>> +++ b/drivers/cpuidle/cpuidle-calxeda.c
>> @@ -65,7 +65,7 @@ static struct cpuidle_driver calxeda_idle_driver = {
>> .state_count = 2,
>> };
>>
>> -static int __init calxeda_cpuidle_probe(struct platform_device *pdev)
>> +static int calxeda_cpuidle_probe(struct platform_device *pdev)
>> {
>> return cpuidle_register(&calxeda_idle_driver, NULL);
>> }
>>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH] ARM/cpuidle: remove __init tag from Calxeda cpuidle probe function
2013-12-13 22:47 ` Andre Przywara
@ 2013-12-14 9:04 ` Daniel Lezcano
0 siblings, 0 replies; 7+ messages in thread
From: Daniel Lezcano @ 2013-12-14 9:04 UTC (permalink / raw)
To: linux-arm-kernel
On 12/13/2013 11:47 PM, Andre Przywara wrote:
> On 12/13/2013 10:57 PM, Daniel Lezcano wrote:
>> On 12/13/2013 09:49 PM, Andre Przywara wrote:
>>> Commit 60a66e370007e8535b7a561353b07b37deaf35ba changed the Calxeda
>>> cpuidle driver to a platform driver, copying the __init tag from the
>>> _init() to the newly used _probe() function. However, "probe should
>>> not be __init." (Rob said ;-)
>>> Remove the __init tag to fix a section mismatch in the Calxeda
>>> cpuidle driver.
>>>
>>> Signed-off-by: Andre Przywara <andre.przywara@linaro.org>
>>> ---
>>
>> Applied to my tree for 3.14.
>
> Daniel,
>
> thanks!
> But since this is a regression (3.12 compiles fine), can someone please
> push this still for 3.13? If I am not mistaken, the rework was
> introduced in the last merge window, so I'd consider this a bug fix.
Yep. Done.
-- Daniel
>> Thanks for the fix.
>
>>
>> -- Daniel
>>
>>> drivers/cpuidle/cpuidle-calxeda.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/cpuidle/cpuidle-calxeda.c
>>> b/drivers/cpuidle/cpuidle-calxeda.c
>>> index 3679563..6e51114 100644
>>> --- a/drivers/cpuidle/cpuidle-calxeda.c
>>> +++ b/drivers/cpuidle/cpuidle-calxeda.c
>>> @@ -65,7 +65,7 @@ static struct cpuidle_driver calxeda_idle_driver = {
>>> .state_count = 2,
>>> };
>>>
>>> -static int __init calxeda_cpuidle_probe(struct platform_device *pdev)
>>> +static int calxeda_cpuidle_probe(struct platform_device *pdev)
>>> {
>>> return cpuidle_register(&calxeda_idle_driver, NULL);
>>> }
>>>
>>
>>
>
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-12-31 21:30 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-30 11:00 [GIT PULL] ARM : cpuidle: 3.13 fix Daniel Lezcano
2013-12-30 11:02 ` [PATCH] ARM/cpuidle: remove __init tag from Calxeda cpuidle probe function Daniel Lezcano
2013-12-31 21:30 ` [GIT PULL] ARM : cpuidle: 3.13 fix Rafael J. Wysocki
-- strict thread matches above, loose matches on Subject: below --
2013-12-13 20:49 [PATCH] ARM/cpuidle: remove __init tag from Calxeda cpuidle probe function Andre Przywara
2013-12-13 21:57 ` Daniel Lezcano
2013-12-13 22:47 ` Andre Przywara
2013-12-14 9:04 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).