From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A431CDB47E for ; Wed, 11 Oct 2023 20:02:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qeRZaAGsoy3hPoxh+RMQD1UDd4YmUxkG/ioZn3g1vsg=; b=V7DWcVPs6HPj6N maR4NKfpZkA6GRt9sPcpZWNHmxGjWB9hlklzZ/xKFzwaJ6OfIsWTQU5rC8v+VvQqDepkVnlhJkQ+j /+EItnYgExlQceHP93OanNFo0x12voBQAIgyI/X+KsktDvVmkpLbeBS23fVakTrRvN0SvMTBkHctu 2FCqyR1TjVhnLdv1s/974bG/bItrEbHFdhZYs+CQ4fnRNh7JsYPe96C/o6qmHtuTn4jCcTD8xtRD2 RjZP6yF+M0rbUMiYh1SnlL5f9Q6Q/zql+JdNXbqX7+hcioYm435EK0gbIQFhdaCiaZbPpwmd+IX0+ HjbAMxZdmuN1nrbG9wCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qqfOv-00GbTA-1A; Wed, 11 Oct 2023 20:01:49 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qqfOr-00GbQI-2n for linux-arm-kernel@lists.infradead.org; Wed, 11 Oct 2023 20:01:47 +0000 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-32157c8e4c7so219373f8f.1 for ; Wed, 11 Oct 2023 13:01:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697054500; x=1697659300; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vJroCQ5f7MWlIlaijqfjlzkCzCi0InBWPA+64vhHzGc=; b=HF21A29TDXuP7s9RlKqujAOCKWjGScID1BV/p64wHM9E24+JRGoCLfmlMPC1V0wLPt cU8h53kE9v/j2mPOuVKH/d37PIg5C9G8RNF6iqxfvgxGxtowvPMaAtIPfp7Un3f1HSpi 5DJkbxOW1SjeSfnp3m700aZcoW+pDX8Glc6Y9MQZEZDY64jf78iuyJpZqKmuaRAQ7cL0 5wRjidhlhlJNpB/1la7DgG7CSmsXG3azF5dQyMbaTytoY6wJKDWP1tAjrUmcFiROVmj8 UqIA3qTHBqmhKFvOKAMpTxlwPvEx0dypLvIcuAsnwvrDxGEE23FnLfDVkFj6GyR5OLRS OajA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697054500; x=1697659300; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vJroCQ5f7MWlIlaijqfjlzkCzCi0InBWPA+64vhHzGc=; b=ZKBwzzBmSGd7BdFCJYh+4jduWjubtIXub/t6PoR4NeBswSzqS4wS7M1m1MBtNlI1TE hAOaCc8d6JrG4VpywMcolxMpN1LcM+azvoQy+huCxTIFzQRTGN+ZtLz27Zw4az1mbrFs 5b9DcOq5EO5ocCHeI2glO7lcTZzC0PV5y9BUt/cnRT24nPtEOFdWhiSjvQWa+tLvYEIJ ipAAmQfjePyhmUDn20PqALtTqRDzgbSKLA2V3mP45HndEASDD2knLb5+9kJGCaV6KCqy Juts/1INJ8sd6i8iK4s2mHl2nDGDXnjHIPgV/A9Yy2yfg3TqJt1BygGuKzjKbY/0+D9P CbGA== X-Gm-Message-State: AOJu0YynD+B4A/tqI7KIR27SggIww+WS/ljmgkV8ROr7dz/60bnVM1+c RLhgZWWsJD25KM342SIAh2g= X-Google-Smtp-Source: AGHT+IEYYG1g8e0+HZgSWRaku+rRsiOSJnc04Ze6VUY+cqtVVM63VjUX6K7a9c5dGy9q/VUE9K3TJA== X-Received: by 2002:adf:dd8f:0:b0:313:f45f:74a1 with SMTP id x15-20020adfdd8f000000b00313f45f74a1mr20263516wrl.51.1697054500257; Wed, 11 Oct 2023 13:01:40 -0700 (PDT) Received: from ?IPV6:2a02:8071:b783:140:927c:82ba:d32d:99c1? ([2a02:8071:b783:140:927c:82ba:d32d:99c1]) by smtp.gmail.com with ESMTPSA id j15-20020a5d604f000000b003259b068ba6sm16437370wrt.7.2023.10.11.13.01.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Oct 2023 13:01:39 -0700 (PDT) Message-ID: <1388bb68-dc55-489d-bb3c-517ffcf4443d@gmail.com> Date: Wed, 11 Oct 2023 22:01:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 01/15] firmware: qcom: move Qualcomm code into its own directory To: Bartosz Golaszewski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Elliot Berman , Krzysztof Kozlowski , Guru Das Srinagesh , Andrew Halaney , Alex Elder , Srini Kandagatla Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@quicinc.com, Bartosz Golaszewski References: <20231009153427.20951-1-brgl@bgdev.pl> <20231009153427.20951-2-brgl@bgdev.pl> Content-Language: en-US From: Maximilian Luz In-Reply-To: <20231009153427.20951-2-brgl@bgdev.pl> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231011_130145_933373_A4C8F3DA X-CRM114-Status: GOOD ( 28.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/9/23 17:34, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > We're getting more and more qcom specific .c files in drivers/firmware/ > and about to get even more. Create a separate directory for Qualcomm > firmware drivers and move existing sources in there. > > Signed-off-by: Bartosz Golaszewski > Acked-by: Elliot Berman > Reviewed-by: Krzysztof Kozlowski Reviewed-by: Maximilian Luz > --- > MAINTAINERS | 4 +- > drivers/firmware/Kconfig | 48 +--------------- > drivers/firmware/Makefile | 5 +- > drivers/firmware/qcom/Kconfig | 56 +++++++++++++++++++ > drivers/firmware/qcom/Makefile | 9 +++ > drivers/firmware/{ => qcom}/qcom_qseecom.c | 0 > .../{ => qcom}/qcom_qseecom_uefisecapp.c | 0 > drivers/firmware/{ => qcom}/qcom_scm-legacy.c | 0 > drivers/firmware/{ => qcom}/qcom_scm-smc.c | 0 > drivers/firmware/{ => qcom}/qcom_scm.c | 0 > drivers/firmware/{ => qcom}/qcom_scm.h | 0 > 11 files changed, 69 insertions(+), 53 deletions(-) > create mode 100644 drivers/firmware/qcom/Kconfig > create mode 100644 drivers/firmware/qcom/Makefile > rename drivers/firmware/{ => qcom}/qcom_qseecom.c (100%) > rename drivers/firmware/{ => qcom}/qcom_qseecom_uefisecapp.c (100%) > rename drivers/firmware/{ => qcom}/qcom_scm-legacy.c (100%) > rename drivers/firmware/{ => qcom}/qcom_scm-smc.c (100%) > rename drivers/firmware/{ => qcom}/qcom_scm.c (100%) > rename drivers/firmware/{ => qcom}/qcom_scm.h (100%) > > diff --git a/MAINTAINERS b/MAINTAINERS > index c934244acc31..0d032572cce0 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -17930,13 +17930,13 @@ QUALCOMM QSEECOM DRIVER > M: Maximilian Luz > L: linux-arm-msm@vger.kernel.org > S: Maintained > -F: drivers/firmware/qcom_qseecom.c > +F: drivers/firmware/qcom/qcom_qseecom.c > > QUALCOMM QSEECOM UEFISECAPP DRIVER > M: Maximilian Luz > L: linux-arm-msm@vger.kernel.org > S: Maintained > -F: drivers/firmware/qcom_qseecom_uefisecapp.c > +F: drivers/firmware/qcom/qcom_qseecom_uefisecapp.c > > QUALCOMM RMNET DRIVER > M: Subash Abhinov Kasiviswanathan > diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig > index 817e011a8945..74d00b0c83fe 100644 > --- a/drivers/firmware/Kconfig > +++ b/drivers/firmware/Kconfig > @@ -188,53 +188,6 @@ config MTK_ADSP_IPC > ADSP exists on some mtk processors. > Client might use shared memory to exchange information with ADSP. > > -config QCOM_SCM > - tristate > - > -config QCOM_SCM_DOWNLOAD_MODE_DEFAULT > - bool "Qualcomm download mode enabled by default" > - depends on QCOM_SCM > - help > - A device with "download mode" enabled will upon an unexpected > - warm-restart enter a special debug mode that allows the user to > - "download" memory content over USB for offline postmortem analysis. > - The feature can be enabled/disabled on the kernel command line. > - > - Say Y here to enable "download mode" by default. > - > -config QCOM_QSEECOM > - bool "Qualcomm QSEECOM interface driver" > - depends on QCOM_SCM=y > - select AUXILIARY_BUS > - help > - Various Qualcomm SoCs have a Secure Execution Environment (SEE) running > - in the Trust Zone. This module provides an interface to that via the > - QSEECOM mechanism, using SCM calls. > - > - The QSEECOM interface allows, among other things, access to applications > - running in the SEE. An example of such an application is 'uefisecapp', > - which is required to access UEFI variables on certain systems. If > - selected, the interface will also attempt to detect and register client > - devices for supported applications. > - > - Select Y here to enable the QSEECOM interface driver. > - > -config QCOM_QSEECOM_UEFISECAPP > - bool "Qualcomm SEE UEFI Secure App client driver" > - depends on QCOM_QSEECOM > - depends on EFI > - help > - Various Qualcomm SoCs do not allow direct access to EFI variables. > - Instead, these need to be accessed via the UEFI Secure Application > - (uefisecapp), residing in the Secure Execution Environment (SEE). > - > - This module provides a client driver for uefisecapp, installing efivar > - operations to allow the kernel accessing EFI variables, and via that also > - provide user-space with access to EFI variables via efivarfs. > - > - Select Y here to provide access to EFI variables on the aforementioned > - platforms. > - > config SYSFB > bool > select BOOT_VESA_SUPPORT > @@ -320,6 +273,7 @@ source "drivers/firmware/efi/Kconfig" > source "drivers/firmware/imx/Kconfig" > source "drivers/firmware/meson/Kconfig" > source "drivers/firmware/psci/Kconfig" > +source "drivers/firmware/qcom/Kconfig" > source "drivers/firmware/smccc/Kconfig" > source "drivers/firmware/tegra/Kconfig" > source "drivers/firmware/xilinx/Kconfig" > diff --git a/drivers/firmware/Makefile b/drivers/firmware/Makefile > index cb18fd8882dc..5f9dab82e1a0 100644 > --- a/drivers/firmware/Makefile > +++ b/drivers/firmware/Makefile > @@ -17,10 +17,6 @@ obj-$(CONFIG_FIRMWARE_MEMMAP) += memmap.o > obj-$(CONFIG_MTK_ADSP_IPC) += mtk-adsp-ipc.o > obj-$(CONFIG_RASPBERRYPI_FIRMWARE) += raspberrypi.o > obj-$(CONFIG_FW_CFG_SYSFS) += qemu_fw_cfg.o > -obj-$(CONFIG_QCOM_SCM) += qcom-scm.o > -qcom-scm-objs += qcom_scm.o qcom_scm-smc.o qcom_scm-legacy.o > -obj-$(CONFIG_QCOM_QSEECOM) += qcom_qseecom.o > -obj-$(CONFIG_QCOM_QSEECOM_UEFISECAPP) += qcom_qseecom_uefisecapp.o > obj-$(CONFIG_SYSFB) += sysfb.o > obj-$(CONFIG_SYSFB_SIMPLEFB) += sysfb_simplefb.o > obj-$(CONFIG_TI_SCI_PROTOCOL) += ti_sci.o > @@ -36,6 +32,7 @@ obj-$(CONFIG_GOOGLE_FIRMWARE) += google/ > obj-y += efi/ > obj-y += imx/ > obj-y += psci/ > +obj-y += qcom/ > obj-y += smccc/ > obj-y += tegra/ > obj-y += xilinx/ > diff --git a/drivers/firmware/qcom/Kconfig b/drivers/firmware/qcom/Kconfig > new file mode 100644 > index 000000000000..3f05d9854ddf > --- /dev/null > +++ b/drivers/firmware/qcom/Kconfig > @@ -0,0 +1,56 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +# > +# For a description of the syntax of this configuration file, > +# see Documentation/kbuild/kconfig-language.rst. > +# > + > +menu "Qualcomm firmware drivers" > + > +config QCOM_SCM > + tristate > + > +config QCOM_SCM_DOWNLOAD_MODE_DEFAULT > + bool "Qualcomm download mode enabled by default" > + depends on QCOM_SCM > + help > + A device with "download mode" enabled will upon an unexpected > + warm-restart enter a special debug mode that allows the user to > + "download" memory content over USB for offline postmortem analysis. > + The feature can be enabled/disabled on the kernel command line. > + > + Say Y here to enable "download mode" by default. > + > +config QCOM_QSEECOM > + bool "Qualcomm QSEECOM interface driver" > + depends on QCOM_SCM=y > + select AUXILIARY_BUS > + help > + Various Qualcomm SoCs have a Secure Execution Environment (SEE) running > + in the Trust Zone. This module provides an interface to that via the > + QSEECOM mechanism, using SCM calls. > + > + The QSEECOM interface allows, among other things, access to applications > + running in the SEE. An example of such an application is 'uefisecapp', > + which is required to access UEFI variables on certain systems. If > + selected, the interface will also attempt to detect and register client > + devices for supported applications. > + > + Select Y here to enable the QSEECOM interface driver. > + > +config QCOM_QSEECOM_UEFISECAPP > + bool "Qualcomm SEE UEFI Secure App client driver" > + depends on QCOM_QSEECOM > + depends on EFI > + help > + Various Qualcomm SoCs do not allow direct access to EFI variables. > + Instead, these need to be accessed via the UEFI Secure Application > + (uefisecapp), residing in the Secure Execution Environment (SEE). > + > + This module provides a client driver for uefisecapp, installing efivar > + operations to allow the kernel accessing EFI variables, and via that also > + provide user-space with access to EFI variables via efivarfs. > + > + Select Y here to provide access to EFI variables on the aforementioned > + platforms. > + > +endmenu > diff --git a/drivers/firmware/qcom/Makefile b/drivers/firmware/qcom/Makefile > new file mode 100644 > index 000000000000..c9f12ee8224a > --- /dev/null > +++ b/drivers/firmware/qcom/Makefile > @@ -0,0 +1,9 @@ > +# SPDX-License-Identifier: GPL-2.0 > +# > +# Makefile for the linux kernel. > +# > + > +obj-$(CONFIG_QCOM_SCM) += qcom-scm.o > +qcom-scm-objs += qcom_scm.o qcom_scm-smc.o qcom_scm-legacy.o > +obj-$(CONFIG_QCOM_QSEECOM) += qcom_qseecom.o > +obj-$(CONFIG_QCOM_QSEECOM_UEFISECAPP) += qcom_qseecom_uefisecapp.o > diff --git a/drivers/firmware/qcom_qseecom.c b/drivers/firmware/qcom/qcom_qseecom.c > similarity index 100% > rename from drivers/firmware/qcom_qseecom.c > rename to drivers/firmware/qcom/qcom_qseecom.c > diff --git a/drivers/firmware/qcom_qseecom_uefisecapp.c b/drivers/firmware/qcom/qcom_qseecom_uefisecapp.c > similarity index 100% > rename from drivers/firmware/qcom_qseecom_uefisecapp.c > rename to drivers/firmware/qcom/qcom_qseecom_uefisecapp.c > diff --git a/drivers/firmware/qcom_scm-legacy.c b/drivers/firmware/qcom/qcom_scm-legacy.c > similarity index 100% > rename from drivers/firmware/qcom_scm-legacy.c > rename to drivers/firmware/qcom/qcom_scm-legacy.c > diff --git a/drivers/firmware/qcom_scm-smc.c b/drivers/firmware/qcom/qcom_scm-smc.c > similarity index 100% > rename from drivers/firmware/qcom_scm-smc.c > rename to drivers/firmware/qcom/qcom_scm-smc.c > diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c > similarity index 100% > rename from drivers/firmware/qcom_scm.c > rename to drivers/firmware/qcom/qcom_scm.c > diff --git a/drivers/firmware/qcom_scm.h b/drivers/firmware/qcom/qcom_scm.h > similarity index 100% > rename from drivers/firmware/qcom_scm.h > rename to drivers/firmware/qcom/qcom_scm.h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel